From 0b1be909703a3d08ae8c2cf76ab141a744839eab Mon Sep 17 00:00:00 2001 From: Roman Vasilets Date: Thu, 25 Jun 2015 18:26:43 +0300 Subject: Change default values from [] to None Its well known fact that python default values initialized only once at the stage if creation function. So if we call function with parameter foo=[] as default value and change foo.append("bar") at the next call of the function default value would be ["bar"]. It will save. Change-Id: Iba9e55bc2d4dfd811ce7d068b6a9cceae7c000d6 --- ceilometerclient/v1/meters.py | 3 ++- ceilometerclient/v2/statistics.py | 5 ++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/ceilometerclient/v1/meters.py b/ceilometerclient/v1/meters.py index c8a784b..223bfb3 100644 --- a/ceilometerclient/v1/meters.py +++ b/ceilometerclient/v1/meters.py @@ -18,8 +18,9 @@ import six from ceilometerclient.common import base -def _get_opt_path(simple_params=[], **kwargs): +def _get_opt_path(simple_params=None, **kwargs): l = [] + simple_params = simple_params or [] # get simple paramters for key in simple_params: val = kwargs.get(key) diff --git a/ceilometerclient/v2/statistics.py b/ceilometerclient/v2/statistics.py index a5cce23..4775238 100644 --- a/ceilometerclient/v2/statistics.py +++ b/ceilometerclient/v2/statistics.py @@ -44,7 +44,10 @@ class StatisticsManager(base.Manager): ) return url_aggregates - def list(self, meter_name, q=None, period=None, groupby=[], aggregates=[]): + def list(self, meter_name, q=None, period=None, groupby=None, + aggregates=None): + groupby = groupby or [] + aggregates = aggregates or [] p = ['period=%s' % period] if period else [] if isinstance(groupby, six.string_types): groupby = [groupby] -- cgit v1.2.1