From 6ed98bd6d67e730fc7dc652dcb020b2883e49916 Mon Sep 17 00:00:00 2001 From: Anh Tran Date: Tue, 27 Sep 2016 09:11:44 +0700 Subject: Using assertIsNone() instead of assertEqual(None) Following OpenStack Style Guidelines[1]: [H203] Unit test assertions tend to give better messages for more specific assertions. As a result, assertIsNone(...) is preferred over assertEqual(None, ...) and assertIs(..,None) [1] http://docs.openstack.org/developer/hacking/#unit-tests-and-assertraises Change-Id: Iae83c4360336cf07b6045615ff38933f52844499 --- ceilometerclient/tests/unit/v2/test_alarms.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ceilometerclient/tests/unit/v2/test_alarms.py b/ceilometerclient/tests/unit/v2/test_alarms.py index 44fa50c..0557318 100644 --- a/ceilometerclient/tests/unit/v2/test_alarms.py +++ b/ceilometerclient/tests/unit/v2/test_alarms.py @@ -400,7 +400,7 @@ class AlarmManagerTest(testtools.TestCase): alarm = self.mgr.update(alarm_id='unk-alarm-id', **UPDATE_ALARM) except exc.CommandError: pass - self.assertEqual(alarm, None) + self.assertIsNone(alarm) def test_delete_from_alarm_class(self): alarm = self.mgr.get(alarm_id='alarm-id') -- cgit v1.2.1