From dec8d4a9ee9208b33a08141d04879369d7210da0 Mon Sep 17 00:00:00 2001 From: Eric Harney Date: Mon, 7 Nov 2022 14:44:51 -0500 Subject: Add test coverage for shell snapshot-create w/ metadata This path is not currently unit tested. Change-Id: If38c6352f5e1f0a50e4a0d29fbdd5263ccba3b29 --- cinderclient/tests/unit/v3/test_shell.py | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) (limited to 'cinderclient') diff --git a/cinderclient/tests/unit/v3/test_shell.py b/cinderclient/tests/unit/v3/test_shell.py index 7c5f110..841cab9 100644 --- a/cinderclient/tests/unit/v3/test_shell.py +++ b/cinderclient/tests/unit/v3/test_shell.py @@ -970,6 +970,15 @@ class ShellTest(utils.TestCase): } } + SNAP_BODY_3_66_W_METADATA = { + 'snapshot': { + 'volume_id': '123456', + 'name': None, + 'description': None, + 'metadata': {'a': 'b'} + } + } + @ddt.data(True, 'true', 'on', '1') @mock.patch('cinderclient.utils.find_resource') def test_snapshot_create_3_66_with_force_true(self, f_val, mock_find_vol): @@ -1037,6 +1046,15 @@ class ShellTest(utils.TestCase): self.assert_called_anytime('POST', '/snapshots', body=pre_3_66_request_body) + @mock.patch('cinderclient.utils.find_resource') + def test_snapshot_create_w_metadata(self, mock_find_vol): + mock_find_vol.return_value = volumes.Volume( + self, {'id': '123456'}, loaded=True) + self.run_command('--os-volume-api-version 3.66 ' + 'snapshot-create 123456 --metadata a=b') + self.assert_called_anytime('POST', '/snapshots', + body=self.SNAP_BODY_3_66_W_METADATA) + def test_snapshot_manageable_list(self): self.run_command('--os-volume-api-version 3.8 ' 'snapshot-manageable-list fakehost') -- cgit v1.2.1