summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTony Breeds <tony@bakeyournoodle.com>2016-12-21 12:52:21 +1100
committerTony Breeds <tony@bakeyournoodle.com>2016-12-21 12:53:41 +1100
commit08c5a645ede8b4161da9fee5db013fc401b592c5 (patch)
tree51fe888f2b81bb2e5be2f9d0db29abdc22071869
parent2912647d00f6ad4f1f2dc1f62357516cd18068c2 (diff)
downloadpython-designateclient-08c5a645ede8b4161da9fee5db013fc401b592c5.tar.gz
Add Constraints support
Adding constraints support to libraries is slightly more complex than services as the libraries themselves are listed in upper-constraints.txt which leads to errors that you can't install a specific version and a constrained version. This change adds constraints support by also adding a helper script to edit the constraints to remove python-designateclient. Change-Id: I2976e5615bd46449690072b09aeaad59c1674d44
-rwxr-xr-xtools/tox_install.sh30
-rw-r--r--tox.ini8
2 files changed, 35 insertions, 3 deletions
diff --git a/tools/tox_install.sh b/tools/tox_install.sh
new file mode 100755
index 0000000..e61b63a
--- /dev/null
+++ b/tools/tox_install.sh
@@ -0,0 +1,30 @@
+#!/usr/bin/env bash
+
+# Client constraint file contains this client version pin that is in conflict
+# with installing the client from source. We should remove the version pin in
+# the constraints file before applying it for from-source installation.
+
+CONSTRAINTS_FILE="$1"
+shift 1
+
+set -e
+
+# NOTE(tonyb): Place this in the tox enviroment's log dir so it will get
+# published to logs.openstack.org for easy debugging.
+localfile="$VIRTUAL_ENV/log/upper-constraints.txt"
+
+if [[ "$CONSTRAINTS_FILE" != http* ]]; then
+ CONSTRAINTS_FILE="file://$CONSTRAINTS_FILE"
+fi
+# NOTE(tonyb): need to add curl to bindep.txt if the project supports bindep
+curl "$CONSTRAINTS_FILE" --insecure --progress-bar --output "$localfile"
+
+pip install -c"$localfile" openstack-requirements
+
+# This is the main purpose of the script: Allow local installation of
+# the current repo. It is listed in constraints file and thus any
+# install will be constrained and we need to unconstrain it.
+edit-constraints "$localfile" -- "$CLIENT_NAME"
+
+pip install -c"$localfile" -U "$@"
+exit $?
diff --git a/tox.ini b/tox.ini
index c1f7049..0ac049e 100644
--- a/tox.ini
+++ b/tox.ini
@@ -1,12 +1,14 @@
[tox]
envlist = py34,py27,flake8
-minversion = 1.6
+minversion = 2.0
skipsdist = True
[testenv]
usedevelop = True
-install_command = pip install {opts} {packages}
+install_command = {toxinidir}/tools/tox_install.sh {env:UPPER_CONSTRAINTS_FILE:https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt} {opts} {packages}
setenv = VIRTUAL_ENV={envdir}
+ BRANCH_NAME=master
+ CLIENT_NAME=python-designateclient
LANG=en_US.UTF-8
LANGUAGE=en_US:en
LC_ALL=C
@@ -42,7 +44,7 @@ commands = {posargs}
[testenv:functional]
usedevelop = False
-setenv = VIRTUAL_ENV={envdir}
+setenv = {[testenv]setenv}
OS_TEST_PATH=designateclient/functionaltests/
passenv = OS_STDOUT_CAPTURE
OS_STDERR_CAPTURE