diff options
author | Mridula Joshi <mrjoshi@redhat.com> | 2021-07-29 12:25:37 +0000 |
---|---|---|
committer | Mridula Joshi <mrjoshi@redhat.com> | 2021-08-02 09:08:50 +0000 |
commit | cb084f5289c5c23bdb9fabb413a81b32acb5a498 (patch) | |
tree | 54f509ae8050ce711eb8290b0446ef0df64f8363 /glanceclient/tests | |
parent | 158d5f42486b3d5d7aaa65d86a23012298350a4c (diff) | |
download | python-glanceclient-cb084f5289c5c23bdb9fabb413a81b32acb5a498.tar.gz |
Add member-get command
It is observed that python-glanceclient was missing support for GET /v2/image/{image_id}/member/{member_id} API.
This patch adds new command `member-get` to support this missing operation.
Closes-Bug: #1938154
Change-Id: I3709f6a39535aa45bee70f468f015ac60a1375a8
Diffstat (limited to 'glanceclient/tests')
3 files changed, 31 insertions, 0 deletions
diff --git a/glanceclient/tests/unit/v2/releasenotes/notes/add-member-get-command-11c15e0a94ecd39a.yaml b/glanceclient/tests/unit/v2/releasenotes/notes/add-member-get-command-11c15e0a94ecd39a.yaml new file mode 100644 index 0000000..d5fce03 --- /dev/null +++ b/glanceclient/tests/unit/v2/releasenotes/notes/add-member-get-command-11c15e0a94ecd39a.yaml @@ -0,0 +1,5 @@ +--- +fixes: + - | + Bug 1938154_: Added member-get command + .. _1938154: https://bugs.launchpad.net/glance/+bug/1938154 diff --git a/glanceclient/tests/unit/v2/test_members.py b/glanceclient/tests/unit/v2/test_members.py index 7048a97..240f2b2 100644 --- a/glanceclient/tests/unit/v2/test_members.py +++ b/glanceclient/tests/unit/v2/test_members.py @@ -45,6 +45,17 @@ data_fixtures = { ) }, '/v2/images/{image}/members/{mem}'.format(image=IMAGE, mem=MEMBER): { + 'GET': ( + {}, + { + 'image_id': IMAGE, + 'member_id': MEMBER, + 'status': 'pending', + 'created_at': '2013-11-26T07:21:21Z', + 'updated_at': '2013-11-26T07:21:21Z', + 'schema': "/v2/schemas/member" + }, + ), 'DELETE': ( {}, None, @@ -90,6 +101,11 @@ class TestController(testtools.TestCase): self.assertEqual(IMAGE, image_members[0].image_id) self.assertEqual(MEMBER, image_members[0].member_id) + def test_get_image_members(self): + image_member = self.controller.get(IMAGE, MEMBER) + self.assertEqual(IMAGE, image_member.image_id) + self.assertEqual(MEMBER, image_member.member_id) + def test_delete_image_member(self): image_id = IMAGE member_id = MEMBER diff --git a/glanceclient/tests/unit/v2/test_shell_v2.py b/glanceclient/tests/unit/v2/test_shell_v2.py index c2aa58a..83c4727 100644 --- a/glanceclient/tests/unit/v2/test_shell_v2.py +++ b/glanceclient/tests/unit/v2/test_shell_v2.py @@ -2378,6 +2378,16 @@ class ShellV2Test(testtools.TestCase): columns = ['Image ID', 'Member ID', 'Status'] utils.print_list.assert_called_once_with({}, columns) + def test_do_member_get(self): + args = self._make_args({'image_id': 'IMG-01', 'member_id': 'MEM-01'}) + with mock.patch.object(self.gc.image_members, 'get') as mock_get: + mock_get.return_value = {} + + test_shell.do_member_get(self.gc, args) + + mock_get.assert_called_once_with('IMG-01', 'MEM-01') + utils.print_dict.assert_called_once_with({}) + def test_do_member_create(self): args = self._make_args({'image_id': 'IMG-01', 'member_id': 'MEM-01'}) with mock.patch.object(self.gc.image_members, 'create') as mock_create: |