From 6dfc054cd0a6ba8b1bfc8c2402365769d445c4bb Mon Sep 17 00:00:00 2001
From: Jay Dobies <jason.dobies@redhat.com>
Date: Tue, 29 Mar 2016 14:44:57 -0400
Subject: Moved -t parameter for visibility

When called without the required arguments, the allowed arguments are
output to the screen. The order of those arguments is dictated by when
they are added to the parser.

Before this change, -t (a required parameter) was at the start of the
list. This obfuscated the required parameter list when the help output
was displayed:

usage: openstack stack create [-h]
                              [-f
{html,json,json,shell,table,value,yaml,yaml}]
                              [-c COLUMN] [--max-width <integer>]
[--noindent]
                              [--prefix PREFIX] -t <template>
                              [-e <environment>] [--timeout <timeout>]
                              [--pre-create <resource>]
[--enable-rollback]
                              [--parameter <key=value>]
                              [--parameter-file <key=file>] [--wait]
                              [--tags <tag1,tag2...>] [--dry-run]
                              <stack-name>

Notice how the -t appears in the middle of the optional arguments. This
change moves it to the end so that it is more easily visible to the user
what is required:

usage: openstack stack create [-h]
                              [-f
{html,json,json,shell,table,value,yaml,yaml}]
                              [-c COLUMN] [--max-width <integer>]
[--noindent]
                              [--prefix PREFIX] [-e <environment>]
                              [--timeout <timeout>] [--pre-create
<resource>]
                              [--enable-rollback] [--parameter
<key=value>]
                              [--parameter-file <key=file>] [--wait]
                              [--tags <tag1,tag2...>] [--dry-run]
                              -t <template>
                              <stack-name>

Change-Id: I4e17650622dc8e206dc1aa39e4102f16429ac353
---
 heatclient/osc/v1/stack.py | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/heatclient/osc/v1/stack.py b/heatclient/osc/v1/stack.py
index bcd3231..ead9c6f 100644
--- a/heatclient/osc/v1/stack.py
+++ b/heatclient/osc/v1/stack.py
@@ -44,12 +44,6 @@ class CreateStack(show.ShowOne):
 
     def get_parser(self, prog_name):
         parser = super(CreateStack, self).get_parser(prog_name)
-        parser.add_argument(
-            '-t', '--template',
-            metavar='<template>',
-            required=True,
-            help=_('Path to the template')
-        )
         parser.add_argument(
             '-e', '--environment',
             metavar='<environment>',
@@ -115,6 +109,12 @@ class CreateStack(show.ShowOne):
             metavar='<stack-name>',
             help=_('Name of the stack to create')
         )
+        parser.add_argument(
+            '-t', '--template',
+            metavar='<template>',
+            required=True,
+            help=_('Path to the template')
+        )
 
         return parser
 
-- 
cgit v1.2.1