From 85d665e51185cd0c6fe2985fa4c657b929a4019b Mon Sep 17 00:00:00 2001 From: Andreas Jaeger Date: Wed, 3 Sep 2014 22:23:20 +0200 Subject: warn against sorting requirements And do not check for sorted requirements. Change-Id: I64ae9191863564e278a35d42ec9cd743a233028e Closes-Bug: 1365061 --- tools/requirements_style_check.sh | 32 -------------------------------- 1 file changed, 32 deletions(-) delete mode 100755 tools/requirements_style_check.sh (limited to 'tools') diff --git a/tools/requirements_style_check.sh b/tools/requirements_style_check.sh deleted file mode 100755 index ccbff3b..0000000 --- a/tools/requirements_style_check.sh +++ /dev/null @@ -1,32 +0,0 @@ -#!/bin/bash -# -# Enforce the requirement that dependencies are listed in the input -# files in alphabetical order. - -# FIXME(dhellmann): This doesn't deal with URL requirements very -# well. We should probably sort those on the egg-name, rather than the -# full line. - -function check_file() { - typeset f=$1 - - # We don't care about comment lines. - grep -v '^#' $f > ${f}.unsorted - sort -i -f ${f}.unsorted > ${f}.sorted - diff -c ${f}.unsorted ${f}.sorted - rc=$? - rm -f ${f}.sorted ${f}.unsorted - return $rc -} - -exit_code=0 -for filename in $@ -do - check_file $filename - if [ $? -ne 0 ] - then - echo "Please list requirements in $filename in alphabetical order" 1>&2 - exit_code=1 - fi -done -exit $exit_code -- cgit v1.2.1