diff options
| author | M V P Nitesh <m.nitesh@nectechnologies.in> | 2017-02-09 19:22:23 +0530 |
|---|---|---|
| committer | Dmitry Tantsur <divius.inside@gmail.com> | 2017-08-28 12:34:27 +0200 |
| commit | 43ba5c0bd1e0a024b67449796dbb24e9a752499e (patch) | |
| tree | de416a357852aa5719f8de2bf58cc8312bac1e4f | |
| parent | 1e5b34dc0f402fcfd775311f07794cd8c529624b (diff) | |
| download | python-ironicclient-stable/newton.tar.gz | |
OSC 'node list' recognizes all provision statesnewton-eolstable/newton
Now OSC 'node list' command with --provision-state argument for
'available' will list all nodes whose provision state is 'available'.
It will also accept all the provision-states for OSC 'node list'
command.
Conflicts:
ironicclient/osc/v1/baremetal_node.py
Change-Id: If0032f652bcb3f6638b59dba32b97cb19176df46
Closes-Bug: #1663202
(cherry picked from commit d55e36390461c98c961d64f483c7d011af74a3ed)
| -rw-r--r-- | ironicclient/osc/v1/baremetal_node.py | 4 | ||||
| -rw-r--r-- | ironicclient/tests/unit/osc/v1/test_baremetal_node.py | 12 | ||||
| -rw-r--r-- | releasenotes/notes/osc-node-list-provisionstate-cd98dbddaad93e96.yaml | 4 |
3 files changed, 5 insertions, 15 deletions
diff --git a/ironicclient/osc/v1/baremetal_node.py b/ironicclient/osc/v1/baremetal_node.py index 13ab2e0..0df0e29 100644 --- a/ironicclient/osc/v1/baremetal_node.py +++ b/ironicclient/osc/v1/baremetal_node.py @@ -463,9 +463,7 @@ class ListBaremetalNode(command.Lister): '--provision-state', dest='provision_state', metavar='<provision state>', - choices=self.PROVISION_STATES, - help="Limit list to nodes in <provision state>. One of %s." % ( - ", ".join(self.PROVISION_STATES))) + help="List nodes in specified provision state.") parser.add_argument( '--resource-class', dest='resource_class', diff --git a/ironicclient/tests/unit/osc/v1/test_baremetal_node.py b/ironicclient/tests/unit/osc/v1/test_baremetal_node.py index ab7b738..bb2b01a 100644 --- a/ironicclient/tests/unit/osc/v1/test_baremetal_node.py +++ b/ironicclient/tests/unit/osc/v1/test_baremetal_node.py @@ -603,18 +603,6 @@ class TestBaremetalList(TestBaremetal): **kwargs ) - def test_baremetal_list_invalid_provision_state(self): - arglist = [ - '--provision-state', 'invalid', - ] - verifylist = [ - ('provision_state', 'invalid'), - ] - - self.assertRaises(oscutils.ParserException, - self.check_parser, - self.cmd, arglist, verifylist) - def test_baremetal_list_resource_class(self): arglist = [ '--resource-class', 'foo', diff --git a/releasenotes/notes/osc-node-list-provisionstate-cd98dbddaad93e96.yaml b/releasenotes/notes/osc-node-list-provisionstate-cd98dbddaad93e96.yaml new file mode 100644 index 0000000..e56fa90 --- /dev/null +++ b/releasenotes/notes/osc-node-list-provisionstate-cd98dbddaad93e96.yaml @@ -0,0 +1,4 @@ +--- +fixes: + - Allows all provision states for OSC node list + command with --provision-state argument |