summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorZuul <zuul@review.openstack.org>2017-11-08 13:54:59 +0000
committerGerrit Code Review <review@openstack.org>2017-11-08 13:54:59 +0000
commitbd62cf0609ea43d6129bfa03490d629d17cf3994 (patch)
treee48455fce7411cad4bc047e6abb46b22b99ae0de
parentb1cf332822db105cf45a99335fdf28daf2f3e726 (diff)
parent534810fd038e99ecf295d67860e87b79f195547e (diff)
downloadpython-ironicclient-bd62cf0609ea43d6129bfa03490d629d17cf3994.tar.gz
Merge "Pass missing arguments to session in SessionClient._make_session_request"
-rw-r--r--ironicclient/common/http.py10
-rw-r--r--ironicclient/tests/unit/common/test_http.py17
2 files changed, 26 insertions, 1 deletions
diff --git a/ironicclient/common/http.py b/ironicclient/common/http.py
index 3a425f8..2a62a46 100644
--- a/ironicclient/common/http.py
+++ b/ironicclient/common/http.py
@@ -504,8 +504,16 @@ class SessionClient(VersionNegotiationMixin, adapter.LegacyJsonAdapter):
return self._generic_parse_version_headers(resp.headers.get)
def _make_simple_request(self, conn, method, url):
+ endpoint_filter = {
+ 'interface': self.interface,
+ 'service_type': self.service_type,
+ 'region_name': self.region_name
+ }
+
# NOTE: conn is self.session for this class
- return conn.request(url, method, raise_exc=False)
+ return conn.request(url, method, raise_exc=False,
+ user_agent=USER_AGENT,
+ endpoint_filter=endpoint_filter)
@with_retries
def _http_request(self, url, method, **kwargs):
diff --git a/ironicclient/tests/unit/common/test_http.py b/ironicclient/tests/unit/common/test_http.py
index 7d45759..0da706a 100644
--- a/ironicclient/tests/unit/common/test_http.py
+++ b/ironicclient/tests/unit/common/test_http.py
@@ -539,6 +539,23 @@ class SessionClientTest(utils.BaseTestCase):
def test_endpoint_override_not_valid(self):
self._test_endpoint_override(True)
+ def test_make_simple_request(self):
+ session = mock.Mock(spec=['request'])
+
+ client = _session_client(session=session,
+ endpoint_override='http://127.0.0.1')
+ res = client._make_simple_request(session, 'GET', 'url')
+
+ session.request.assert_called_once_with(
+ 'url', 'GET', raise_exc=False,
+ endpoint_filter={
+ 'interface': 'publicURL',
+ 'service_type': 'baremetal',
+ 'region_name': ''
+ },
+ user_agent=http.USER_AGENT)
+ self.assertEqual(res, session.request.return_value)
+
@mock.patch.object(time, 'sleep', lambda *_: None)
class RetriesTestCase(utils.BaseTestCase):