summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorghanshyam <gmann@ghanshyammann.com>2018-05-09 02:47:31 +0000
committerJulia Kreger <juliaashleykreger@gmail.com>2018-05-10 11:49:25 +0000
commite944146e86aa4a796a4fe7caf6e5a702906b6268 (patch)
tree9836d6819c96f4154eee7cca9a30994421764cb7
parent2cf2d0e4503db5fa02c70673ee66d357692bf40c (diff)
downloadpython-ironicclient-e944146e86aa4a796a4fe7caf6e5a702906b6268.tar.gz
Gate fix: Cap hacking to avoid gate failure
hacking is not capped in g-r and it is in blacklist for requirement as hacking new version can break the gate jobs. Hacking can break gate jobs because of various reasons: - There might be new rule addition in hacking - Some rules becomes default from non-default - Updates in pycodestyle etc That was the main reason it was not added in g-r auto sync also. Most of the project maintained the compatible and cap the hacking version in test-requirements.txt and update to new version when project is ready. Bumping new version might need code fix also on project side depends on what new in that version. If project does not have cap the hacking version then, there is possibility of gate failure whenever new hacking version is released by QA team. Example of such failure in recent release of hacking 1.1.0 - http://lists.openstack.org/pipermail/openstack-dev/2018-May/130282.html Change-Id: I904a85633198436acbb0d4a7bba89bbe006736a2 (cherry picked from commit c6596e9f41ad3de1b3283679e41f9662eeb02864)
-rw-r--r--test-requirements.txt2
1 files changed, 1 insertions, 1 deletions
diff --git a/test-requirements.txt b/test-requirements.txt
index a0317c3..14fa7e5 100644
--- a/test-requirements.txt
+++ b/test-requirements.txt
@@ -1,7 +1,7 @@
# The order of packages is significant, because pip processes them in the order
# of appearance. Changing the order has an impact on the overall integration
# process, which may cause wedges in the gate later.
-hacking>=1.0.0 # Apache-2.0
+hacking>=1.0.0,<1.1.0 # Apache-2.0
coverage!=4.4,>=4.0 # Apache-2.0
doc8>=0.6.0 # Apache-2.0
fixtures>=3.0.0 # Apache-2.0/BSD