| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| |
| |
| |
| |
| |
| |
| |
| | |
oslo_utils moved out of the oslo namespace.
bp drop-namespace-packages
Change-Id: I72e67dc1f649ba137dd06f5ab7133858c6abd67d
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
E122: continuation line missing indentation or outdented
H304: no relative imports
E122 and H304 havealready been fixed but not removed from exception
list, this patch enables them.
Change-Id: I1375bed51e9670fc4d174e7afce0ef3b3be83822
|
|/
|
|
|
|
|
| |
The new H238 "old style class declaration, use new style (inherit
from `object`)" rule was failing and ignored.
Change-Id: I9f616d74e4777640cc9441e96f2bd8c1873aaaca
|
|
|
|
|
|
|
|
|
|
|
|
| |
F821: undefined name
Currently, we define global variables at runtime in
keystoneclient/tests/test_shell.py, which cannot detected by hacking
rule check, then it fails for rule F821.
This patch changes the global lambda shell to a helper function.
Change-Id: Iaf5c4e40a6b17fbf4ba0c254b75d347f08b52364
|
|
|
|
|
|
|
| |
The new W292 "no newline at end of file" rule was failing and
ignored. Now it's enforced.
Change-Id: I71ba57a056b5b0c772482f5bd80f3e05dffa54d2
|
|
|
|
|
|
|
|
|
|
|
| |
Release notes:
http://git.openstack.org/cgit/openstack-dev/hacking/tag/?id=0.10.0
H803 is no longer checked by hacking per the release notes.
H904 is no longer checked by hacking.
Change-Id: Ifaf62839a4b6da62a3b380396158b463c1381026
|
|
|
|
|
|
|
|
|
|
|
| |
Keystoneclient didn't provide translated messages. With this
change, the messages are marked for translation.
DocImpact
Implements: blueprint keystoneclient-i18n
Change-Id: I85263a71671a1dffed524185266e6bb7ae559630
|
|
|
|
|
|
|
|
|
| |
With the latest version of oslotest, we can now take advantage
of a common oslo_debug_helper script.
We can now remove our own homebrewed version, minor changes to
tox.ini were needed.
Change-Id: I907f7203aefedc9b33c3dfbfecc9793e273a4a8f
|
|
|
|
|
|
|
|
|
| |
Address some issues that came up because of hacking upgrade.
But ignoring H904 since the slashes are valid, as they are in
comments, not code.
Change-Id: Ie8a94fc71632e4130c2ec663a5c6d3f2042f8263
Closes-Bug: #1328469
|
|
|
|
| |
Change-Id: I4cdd32676de74c2628754a5df6d251605a25e1fb
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixed most of the errors reported back from hacking 0.9.2.
Specifically:
- E128 continuation line under-indented for visual indent
- E251 unexpected spaces around keyword / parameter equals
- E265 block comment should start with '# '
- H305 imports not grouped correctly
- H307 like imports should be grouped together
- H402 one line docstring needs punctuation
- H904 Wrap long lines in parentheses instead of a backslash
But opted to ignore the following for now:
- E122: continuation line missing indentation or outdented
- H405: multi line docstring summary not separated with an empty line
Change-Id: Ib8e698d85fd598fa91435538657361a1f695ce89
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Sync with oslo-incubator commit
2640847e3df7720457103d2111846c27fc8fdcd5 .
First, remove the existing code to cleanup:
$ rm -r keyestoneclient/openstack/*
Then, sync from oslo-incubator:
$ python update.py ../python-keystoneclient
Change-Id: Ic94906002e0257ffc56245e49890e7ee2f3b4a2a
|
|
|
|
|
|
|
|
|
| |
The module docs were not being generated.
Co-Authored-By: David Stanek <dstanek@dstanek.com>
Change-Id: I26e1d9a3d407474eb6b016f3ada4c495b5043460
Closes-Bug: #1278662
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* tox.ini: The LANG, LANGUAGE and LC_ALL environment overrides were
introduced originally during the testr migration in an attempt to be
conservative about the possibility that locale settings in the
calling environment could cause consistency problems for test runs.
In actuality, this should be unnecessary and any place where it does
cause issues ought to be considered an actual bug. Also, having
these in the configuration actively causes older pip to have
problems with non-ASCII content in some package metadata files under
Python 3, so drop it now.
Change-Id: I96581dced7eac202d6715837037bb1c002550a14
Closes-Bug: #1277495
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Running a test with pdb was difficult because testr captures
output and causes pdb prompt to quit.
Tips for how to run testr with debug are provided here:
https://wiki.openstack.org/wiki/Testr#Debugging_.28pdb.29_Tests
This change puts these commands into a debug env in tox.ini so
you can do a command like
tox -e debug test_auth_token_middleware
or, for more granularity:
tox -e debug keystone.tests.test_sql_migrate_extensions.EndpointFilterExtension
tox -e debug keystone.tests.test_sql_migrate_extensions.EndpointFilterExtension.test_downgrade
and when it hits your breakpoint you'll get the debug prompt.
This same change was made to keystone in commit c8302509 .
Change-Id: I2b5dc81f4652dc89ecbcc7c785245a81cf77a1ca
|
|/
|
|
|
|
|
|
|
|
| |
This reverts commit 01dc81aa148adaa127281f197047636cf2d2c898.
The netaddr package is now hosted on PyPI, so this workaround is
not needed anymore.
Change-Id: I76957aa5e276036921696f27e18efb5494b33120
Closes-Bug: #1266513
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* tox.ini(testenv.install_command): Use the --allow-external and
--allow-insecure options so that pip 1.5 and later will assent to
retrieve the netaddr package even though it's not hosted on PyPI.
The --allow-insecure option is aliased to a clearer
--allow-unverified wording in 1.5, but the old form is being used to
avoid breaking users of 1.4.x and will be valid at least through
1.6.x according to comments in the pip source.
Change-Id: I7c29467ebdddee7a6c68ec3fd13579e4f0c40d30
Closes-Bug: #1266513
Co-Authored-By: Jeremy Stanley
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Override the tox pip install command to avoid using the
"--pre" option which is the default in tox. "--pre" means "Include
pre-release and development versions." By default, pip will only
install stable versions of software, and that is the behavior we want.
Change-Id: Ida5e440d1bdb9f8e9031277ea53a02d2ef171438
Co-Authored-By: Monty Taylor <mordred@inaugust.com>
|
|/
|
|
|
|
|
| |
Match what we have in keystone (http://git.io/BNnRcw)
Closes-Bug: 1259488
Change-Id: I6baa0504b9df1f5094df1249d7d902f2188fd95a
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| | |
The 0.8 hacking tests were failing because it fails to open the
sample files during import. Setting usedevelop=True in the tox.ini
makes the tests run in the right directory.
Change-Id: I7b8f531f669e38e1b009a50d2ed9e9c98cf82e53
|
|/
|
|
|
|
|
|
|
|
|
| |
Currently running tox.ini with py33 installation
fails because of a failure to read a unicode file
while installing httpretty.
Closes-Bug: #1241560
Change-Id: I6012c4fcca0d0354f0c1bdf4797f6e7409f7bf1c
Signed-off-by: Chuck Short <chuck.short@canonical.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Align the hacking version between test-requirement and global requirement.
The change of H202 detection from 0.6 to 0.7 in hacking is:
- if logical_line.startswith("self.assertRaises(Exception)"):
+ if logical_line.startswith("self.assertRaises(Exception,"):
then more cases are detected by this change. Fix the exposed H202 error.
There is a special test case:
tests/v3/test_endpoints.py:test_update_invalid_interface
ref = self.new_ref(interface=uuid.uuid4().hex)
this line can not generate proper parameter for self.manager.update,
add a parameter "endpoint" for it, according to the
definition in keystoneclient/v3/endpoints.py:EndpointManager.update.
Otherwise, there will be following error after changing the Exception
to exceptions.ValidationError:
TypeError: update() takes at least 2 arguments (6 given)
Fixes Bug #1220008
Change-Id: I8f7ed7a6eebf8576a6db5fecd86b9d19a15c8d60
|
|
|
|
|
|
|
|
| |
Allow newer versions of Hacking as well,
which permits further checks to be used for gating.
Suppress H202 for now to pass tests.
Change-Id: I75ab26df94b5dd8b8b05f4ada2ca6831d8584a75
|
|
|
|
|
|
| |
Fixes duplicate method definitions and enables gating on F811
Change-Id: Ic360e70d13da864b8b5c10fc5e731b3952b2d2e8
|
|
|
|
|
|
| |
F841 local variable is assigned to but never used
Change-Id: I4b54489386deb655821192b4ec1e9c0ea596a9b7
|
|
|
|
|
|
| |
Fixes non-module imports and enables gating on H302 in flake8
Change-Id: I366b0ca622d5185732c6c755f8724efb8bbc80f7
|
|
|
|
|
|
|
|
| |
Add ASLv2 headers to files that were missing it.
fixes bug #1211587
Change-Id: Iede918e1ce84993cee4ecbb2d9c2606627fa412e
|
|
|
|
|
|
|
| |
Enable gating on the Hacking H404 check - docstring
should start with a summary.
Change-Id: I80612a15bd11f689e9e9f4dc2ff812138630ddbd
|
|
|
|
| |
Change-Id: I845720fd642c14fc021bd59809327eee97d43156
|
|
|
|
| |
Change-Id: If137689e5b9008c51cea16d41e648f0df490a247
|
|
|
|
| |
Change-Id: I0f4fcc9796e8529e7217dc24abe95660633cad33
|
|
|
|
|
|
|
| |
Only a few occurrences of "multiline docstrings
should end on a new line."
Change-Id: I3fb4591259b1e7c8202365cbadc8967a1639254f
|
|
|
|
|
|
| |
Docstring summaries need punctuation.
Change-Id: I1b740c13d5fedf9a625ca0807c908f651ee08406
|
|
|
|
|
|
|
|
| |
This adds 'build' to the exclude list for flake8
Fixes bug 1198329
Change-Id: Ia3688a2fc0334d32d89f04d114242d39bdc25f0e
|
|
|
|
|
|
| |
Remove leading spaces from doc comments.
Change-Id: I75b055c0d64dda478c63839d44158e301900107f
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| | |
Introduce py33 to tox.ini to make testing with
python3 easier.
Change-Id: I86a790c6f03ee43b0dcbf05122e4e279426003c9
Signed-off-by: Chuck Short <chuck.short@canonical.com>
|
|\ \ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
- F401: imported but unused
- F999: syntax error in doctest
Fixing a couple of the F401's simply required fixing the doctests syntax
where the imports were actually in use.
Change-Id: If78abbb143daf8d005a71c5ab52836df29c5e0cd
|
|\ \ \
| |/ /
| | /
| |/
|/| |
|
| |
| |
| |
| |
| |
| |
| |
| | |
- E125: continuation line does not distinguish itself from next logical
line
- E126: continuation line over-indented for hanging indent
Change-Id: I626a6d5d57db927e8b239f90569b5601c772f28b
|
|\ \
| |/ |
|
| |
| |
| |
| |
| |
| |
| |
| | |
We were previously ignoring all F* and H* rules; this patch specifically
identifies them so that we can eliminate them one by one, without
introducing regressions along the way.
Change-Id: Iaf9ee17acf44aba1c93c1af50c84bd8216544b89
|
|/
|
|
|
|
|
|
|
| |
Rename tools/pip-requires to requirements.txt and tools/test-requires
to test-requirements.txt. These are standard files, and tools in the
general world are growing intelligence about them.
Change-Id: If5c7080fea7c5ca5935b3c064e368cb837a9c16b
Fixes: bug #1179008
|
|
|
|
|
|
| |
Fixes bug 1172444.
Change-Id: Icd51f5d925d84dcec7df7c83ca43cd87bc1b090f
|
|
|
|
|
|
| |
Fixes bug 1179007
Change-Id: Iceb63c223faab49be01baa36c035f703ddf59fc0
|
|
|
|
|
|
| |
Part of blueprint grizzly-testtools
Change-Id: I76dee19781eaac21901b5c0258e83a42180c1702
|