diff options
| author | Brianna Poulos <Brianna.Poulos@jhuapl.edu> | 2018-06-19 11:16:57 -0400 |
|---|---|---|
| committer | Brianna Poulos <Brianna.Poulos@jhuapl.edu> | 2018-06-21 16:16:41 -0400 |
| commit | d422fb061f9077b35188fde3a6d1ac4df1b9d83b (patch) | |
| tree | 90e62e053079fdfdf7dd857b4da119d13da3dc58 | |
| parent | cf57bed266097c75371376e63acec90b37dfa337 (diff) | |
| download | python-novaclient-d422fb061f9077b35188fde3a6d1ac4df1b9d83b.tar.gz | |
Fix trusted-image-certificate-id help text
Fix the help text for nova boot to include that a parameter
is expected for trusted-image-certificate-id. Also update the
UnsupportedAttribute error to mention the env variable to
reduce confusion.
Change-Id: Ic5980b610e5fd97d3a858a2a513e2863657f36c2
| -rw-r--r-- | doc/source/cli/nova.rst | 2 | ||||
| -rw-r--r-- | novaclient/v2/shell.py | 14 |
2 files changed, 11 insertions, 5 deletions
diff --git a/doc/source/cli/nova.rst b/doc/source/cli/nova.rst index ea11e8b6..7c3b6cb6 100644 --- a/doc/source/cli/nova.rst +++ b/doc/source/cli/nova.rst @@ -1011,7 +1011,7 @@ nova boot [--config-drive <value>] [--poll] [--admin-pass <value>] [--access-ip-v4 <value>] [--access-ip-v6 <value>] [--description <description>] - [--trusted-image-certificate-id] + [--trusted-image-certificate-id <trusted-image-certificate-id>] <name> Boot a new server. diff --git a/novaclient/v2/shell.py b/novaclient/v2/shell.py index c1c04435..99cc2f5a 100644 --- a/novaclient/v2/shell.py +++ b/novaclient/v2/shell.py @@ -515,8 +515,13 @@ def _boot(cs, args): boot_kwargs['trusted_image_certificates'] = ( args.trusted_image_certificates) elif utils.env('OS_TRUSTED_IMAGE_CERTIFICATE_IDS'): - boot_kwargs["trusted_image_certificates"] = utils.env( - 'OS_TRUSTED_IMAGE_CERTIFICATE_IDS').split(',') + if cs.api_version >= api_versions.APIVersion('2.63'): + boot_kwargs["trusted_image_certificates"] = utils.env( + 'OS_TRUSTED_IMAGE_CERTIFICATE_IDS').split(',') + else: + raise exceptions.UnsupportedAttribute( + "OS_TRUSTED_IMAGE_CERTIFICATE_IDS", + "2.63") return boot_args, boot_kwargs @@ -1924,8 +1929,9 @@ def do_rebuild(cs, args): # confusion with unsetting the value. kwargs['trusted_image_certificates'] = trusted_image_certificates elif utils.env('OS_TRUSTED_IMAGE_CERTIFICATE_IDS'): - raise exceptions.UnsupportedAttribute("trusted_image_certificates", - "2.63") + raise exceptions.UnsupportedAttribute( + "OS_TRUSTED_IMAGE_CERTIFICATE_IDS", + "2.63") server = server.rebuild(image, _password, **kwargs) _print_server(cs, args, server) |