Stop silently ignoring invalid 'nova boot --hint' optionsrocky-eolrocky-em11.0.1stable/rocky

The '--hint' option for 'nova boot' expects a key-value pair like so:

  nova boot --hint group=245e1dfe-2d0e-4139-80a9-fce124948896 ...

However, the command doesn't complain if this isn't the case, meaning
typos like the below aren't indicated to the user:

  nova boot --hint 245e1dfe-2d0e-4139-80a9-fce124948896

Due to how we'd implemented this here, this ultimately results in us
POSTing the following as part of the body to 'os-servers':

  {
    ...
    "OS-SCH-HNT:scheduler_hints": {
      "245e1dfe-2d0e-4139-80a9-fce124948896": null
    }
    ...
  }

Which is unfortunately allowed and ignored by nova due to the use of
'additionalProperties' in the schema [1]

Do what we do for loads of other options and explicitly fail on invalid
values.

NOTE(stephenfin): This includes the release note first added separately
in change I753e9a0cda1e118578373c519cf2fb2dd605a623.

[1] https://github.com/openstack/nova/blob/19.0.0/nova/api/openstack/compute/schemas/servers.py#L142-L146

Change-Id: I0f9f75cba68e7582d32d4aab2f8f077b4360d386
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
Closes-Bug: #1845322
(cherry picked from commit 6954aacd54e85859fecde22ac04db1ce7601dd35)
(cherry picked from commit 33627242e8f845934bcc5affb616108a79d28cbe)
(cherry picked from commit c7e793c22e72d4d426a6d10e9c2cfa426fedd365)

1 files changed, 6 insertions, 0 deletions

diff --git a/releasenotes/notes/bug-1845322-463ee407b60131c9.yaml b/releasenotes/notes/bug-1845322-463ee407b60131c9.yaml
new file mode 100644
index 00000000..9c60e72f
--- /dev/null
+++ b/releasenotes/notes/bug-1845322-463ee407b60131c9.yaml
@@ -0,0 +1,6 @@
+---
+upgrade:
+  - |
+    The ``--hint`` option for the ``boot`` command expects a key-value
+    argument. Previously, if this was not the case, the argument would be
+    silently ignored. It will now raise an error.