summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Stop silently ignoring invalid 'nova boot --hint' optionsrocky-eolrocky-em11.0.1stable/rockyStephen Finucane2019-10-013-10/+44
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The '--hint' option for 'nova boot' expects a key-value pair like so: nova boot --hint group=245e1dfe-2d0e-4139-80a9-fce124948896 ... However, the command doesn't complain if this isn't the case, meaning typos like the below aren't indicated to the user: nova boot --hint 245e1dfe-2d0e-4139-80a9-fce124948896 Due to how we'd implemented this here, this ultimately results in us POSTing the following as part of the body to 'os-servers': { ... "OS-SCH-HNT:scheduler_hints": { "245e1dfe-2d0e-4139-80a9-fce124948896": null } ... } Which is unfortunately allowed and ignored by nova due to the use of 'additionalProperties' in the schema [1] Do what we do for loads of other options and explicitly fail on invalid values. NOTE(stephenfin): This includes the release note first added separately in change I753e9a0cda1e118578373c519cf2fb2dd605a623. [1] https://github.com/openstack/nova/blob/19.0.0/nova/api/openstack/compute/schemas/servers.py#L142-L146 Change-Id: I0f9f75cba68e7582d32d4aab2f8f077b4360d386 Signed-off-by: Stephen Finucane <sfinucan@redhat.com> Closes-Bug: #1845322 (cherry picked from commit 6954aacd54e85859fecde22ac04db1ce7601dd35) (cherry picked from commit 33627242e8f845934bcc5affb616108a79d28cbe) (cherry picked from commit c7e793c22e72d4d426a6d10e9c2cfa426fedd365)
* Use SHA256 instead of MD5 in completion cacheArtom Lifshitz2019-06-271-2/+2
| | | | | | | | | | | | | | | | FIPS 140 are U.S. government computer security standards that specify requirements for cryptography modules. MD5 is not FIPS compliant [1]. Previously, MD5 was used as the hash algorithm for the bash completion cache. Hosts running in FIPS mode [2] block execution of the MD5 hash. This makes python-novaclient unusable on FIPS-enabled machines. This patch replaces MD5 with SHA256, which is FIPS compliant. [1] https://csrc.nist.gov/projects/hash-functions [2] https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/7/html/security_guide/chap-federal_standards_and_regulations Change-Id: Ia8750bc27aa9a2cfafb6f4f49252f5bd81bc1a40 (cherry picked from commit 2595bac2294ce05e389eaab6636977963d5fc66c) (cherry picked from commit e15cc789d9428cd03c2c5fbd6f5023522f2290cc)
* OpenDev Migration PatchOpenDev Sysadmins2019-04-193-5/+5
| | | | | | | | | | | | | | | This commit was bulk generated and pushed by the OpenDev sysadmins as a part of the Git hosting and code review systems migration detailed in these mailing list posts: http://lists.openstack.org/pipermail/openstack-discuss/2019-March/003603.html http://lists.openstack.org/pipermail/openstack-discuss/2019-April/004920.html Attempts have been made to correct repository namespaces and hostnames based on simple pattern matching, but it's possible some were updated incorrectly or missed entirely. Please reach out to us via the contact information listed at https://opendev.org/ with any questions you may have.
* Add test for console-log and docs for bug 1746534Matt Riedemann2019-04-122-0/+33
| | | | | | | | | | | | | | | | | | | | | | | We had no unit test coverage for the console-log command so this adds a simple test. It unfortunately does not recreate the original UnicodeEncodeError bug though, but it gives us some test coverage anyway. This change also adds docs on how to resolve bug 1746534 by configuring the environment for UTF-8 as noted in the revert change Iaeec1e74262a35f3de3c81f7013835a6aa6f9029. The documentation added here is shamelessly copied from Click [1] which was found via the PEP 538 docs [2]. [1] https://click.palletsprojects.com/en/5.x/python3/#python-3-surrogate-handling [2] https://www.python.org/dev/peps/pep-0538/ Change-Id: Ic7059260dfc031ea1b08d2b8a7cec684bbe7dfa5 Related-Bug: #1823287 Related-Bug: #1746534 (cherry picked from commit e8f7aaf9091330bbb046f2bd42dc9c92f1dcebaa) (cherry picked from commit 60bf9a236dfbaa98e7d93b4baf0997e645b02bb0)
* Revert "Fix crashing console-log"Stephen Finucane2019-04-081-5/+1
| | | | | | | | | | | | | | | | | This reverts commit d272d6f3df2610a62f81e2ca26798ea8a6674b06. This worked around a misconfigured environment by forcing stdout to use UTF-8. This is kind of a hack and it only works in Python 2, breaking Python 3 [1]. The correct solution to this issue and all Python 2 unicode print issues is to correctly configuring LC_ALL to use a UTF-8 locale. [1] https://stackoverflow.com/q/4374455 Change-Id: Iaeec1e74262a35f3de3c81f7013835a6aa6f9029 Closes-Bug: #1823287 (cherry picked from commit a9b1125f7ba209887cac36b3c0900cffe2516fa8) (cherry picked from commit 2ca1814a2b4d1e887974a71951b7e744273a43b4)
* Replace openstack.org git:// URLs with https://Ian Wienand2019-03-241-1/+1
| | | | | | | | | | | | | | | | | This is a mechanically generated change to replace openstack.org git:// URLs with https:// equivalents. This is in aid of a planned future move of the git hosting infrastructure to a self-hosted instance of gitea (https://gitea.io), which does not support the git wire protocol at this stage. This update should result in no functional change. For more information see the thread at http://lists.openstack.org/pipermail/openstack-discuss/2019-March/003825.html Change-Id: Id73551fd737f70c4865b84406bb788590c3b5246
* Merge "Follow up "Fix up userdata argument to rebuild"" into stable/rockyZuul2019-01-083-7/+14
|\
| * Follow up "Fix up userdata argument to rebuild"Takashi NATSUME2018-10-243-7/+14
| | | | | | | | | | | | | | | | | | | | | | | | This patch is a follow-up patch for I9752d849aa0e6cf608db0def3ca89565cff4debc. * Add checking a message of an exception in the unit test * Add 'with' statement when opening a file * Fix descriptions in the release note Change-Id: I2c399490f320a202b41a8f8d36710a36621c4853 (cherry picked from commit 47dc339ab9bb2985d750dae11d0b3b8b2c85d2b2)
* | Merge "Fix up userdata argument to rebuild." into stable/rockyZuul2019-01-083-6/+29
|\ \ | |/
| * Fix up userdata argument to rebuild.Sam Morrison2018-10-243-6/+29
| | | | | | | | | | | | | | | | | | This was using the name of the file as user data as opposed to the content of the file. Change-Id: I9752d849aa0e6cf608db0def3ca89565cff4debc Closes-bug: #1794419 (cherry picked from commit cac7351b0ee9716f1be01e8711d6ed3a237362ca)
* | Improve the description of optional argumentsTakashi NATSUME2018-09-122-9/+9
|/ | | | | | | | | | | This patch is a follow-up patch for Ib4ce831a5031459d350fa73601e878e7b319640f. Improve the description of optional arguments in the CLI reference and help text. Change-Id: I6313b8a584385daa7e9fbd558d431faa43015449 (cherry picked from commit 72b4441fe1413396db2e0e11113033d9e562e934)
* Merge "import zuul job settings from project-config" into stable/rockyZuul2018-09-121-0/+10
|\
| * import zuul job settings from project-configDoug Hellmann2018-09-091-0/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a mechanically generated patch to complete step 1 of moving the zuul job settings out of project-config and into each project repository. Because there will be a separate patch on each branch, the branch specifiers for branch-specific jobs have been removed. Because this patch is generated by a script, there may be some cosmetic changes to the layout of the YAML file(s) as the contents are normalized. See the python3-first goal document for details: https://governance.openstack.org/tc/goals/stein/python3-first.html Change-Id: I9867b8e2d03f992cbf417b3a51a4413b5901b1ca Story: #2002586 Task: #24315
* | Add missing options in CLI referenceTakashi NATSUME2018-09-111-2/+38
|/ | | | | | | | | | | | | | | | | | Add the following missing options in the CLI reference. * nova instance-action-list - marker - limit - changes-since * nova migration-list - marker - limit - changes-since Change-Id: Ib4ce831a5031459d350fa73601e878e7b319640f Closes-Bug: #1791125 (cherry picked from commit b5a4a47977700cb9780c94629b48645612acadb1)
* Update UPPER_CONSTRAINTS_FILE for stable/rockyOpenStack Release Bot2018-07-261-4/+4
| | | | | | | | | | | | | | | | | | The new stable upper-constraints file is only available after the openstack/requirements repository is branched. This will happen around the RC1 timeframe. Recheck and merge this change once the requirements repository has been branched. The CI system will work with this patch before the requirements repository is branched because zuul configues the job to run with a local copy of the file and defaults to the master branch. However, accepting the patch will break the test configuration on developers' local systems, so please wait until after the requirements repository is branched to merge the patch. Change-Id: I47f45d8e43021eecbd643a9d7dc0c149f39d1724
* Update .gitreview for stable/rockyOpenStack Release Bot2018-07-261-0/+1
| | | | Change-Id: I6c362f65130efd009803292ed44785d4a6014e17
* Fix the help text for server-group-create11.0.0Takashi NATSUME2018-07-231-2/+2
| | | | | | | | Replace `` with " in the help text of the server-group-create command for consistency with other help text. TrivialFix Change-Id: Iaeb00b11a723e16a295c6692f6f38e91bc9490f7
* Merge "Add support for microversion 2.65"Zuul2018-07-214-1/+15
|\
| * Add support for microversion 2.65Matt Riedemann2018-07-184-1/+15
| | | | | | | | | | | | | | | | | | | | | | There are no functional changes for this, just bumping the supported client-side version and updating docs. Depends-On: https://review.openstack.org/573136/ Part of blueprint abort-live-migration-in-queued-status Change-Id: Ie0777dbe4d82892ec75b353f6b13ee2d2c5db72c
* | Merge "Fix inconsistency"Zuul2018-07-192-3/+3
|\ \
| * | Fix inconsistencyChen2018-07-192-3/+3
| | | | | | | | | | | | | | | | | | Replace "of"s with "off"s to be consistent with the rest. Change-Id: I4a99e733f9ecdbc080f1158b8c90af888d619cdc
* | | Merge "Microversion 2.64 - Use new format policy in server group"Zuul2018-07-199-15/+243
|\ \ \ | | |/ | |/|
| * | Microversion 2.64 - Use new format policy in server groupYikun Jiang2018-07-189-15/+243
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Added support for microversion 2.64, which includes the following changes: - The ``--rule`` option is added to the ``nova server-group-create`` CLI that enables user to create server group with specific policy rules. - Remove ``metadata`` column in the output of ``nova server-group-create``, ``nova server-group-get``, ``nova server-group-list``. - Remove ``policies`` column, , add ``policy`` and ``rules`` columns in the output of ``nova server-group-create``, ``nova server-group-get``, ``nova server-group-list``. Depends-On: 3cd26f1e68b09ba7925e794ac8912566c239b6df blueprint: complex-anti-affinity-policies Change-Id: I903f4b5544806b9d3c8bac529448abbc9dd3cee9
* | | Switch to stestrVu Cong Tuan2018-07-167-41/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | According to Openstack summit session [1], stestr is maintained project to which all Openstack projects should migrate. Let's switch to stestr as other projects have already moved to it. [1] https://etherpad.openstack.org/p/YVR-python-pti Change-Id: I55060b1d99b9a00b20c98fbb429d072568265695
* | | Rename --endpoint-override to --os-endpoint-overrideTakashi NATSUME2018-07-094-10/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The ``--endpoint-override`` command line argument has been deprecated. It is renamed to ``--os-endpoint-override`` to avoid misinterpreting command line arguments. It defaults to the ``OS_ENDPOINT_OVERRIDE`` environment variable. The deprecated ``--bypass-url`` command line argument has been removed. Change-Id: Ic8a6559cd62d46b837fa9c04b482a46ceba829db Closes-Bug: #1778536
* | | Add release note link in READMEwu.chunyang2018-06-281-0/+2
|/ / | | | | | | Change-Id: Ife1471e7a3139f3997fff10b7a6f472509b8ee52
* | Merge "Fix trusted-image-certificate-id help text"Zuul2018-06-222-5/+11
|\ \
| * | Fix trusted-image-certificate-id help textBrianna Poulos2018-06-212-5/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | Fix the help text for nova boot to include that a parameter is expected for trusted-image-certificate-id. Also update the UnsupportedAttribute error to mention the env variable to reduce confusion. Change-Id: Ic5980b610e5fd97d3a858a2a513e2863657f36c2
* | | Fix help text in server-group-createChen2018-06-221-1/+1
|/ / | | | | | | | | | | | | Only one policy is allowed in server-group-create. Change-Id: Id9cb6f96a5f8bcece1bcda88a97c6fb5f8a58bba Related-Bug: #1767287
* | Merge "Modify novaclient to support basic attributes"Zuul2018-06-186-3/+71
|\ \
| * | Modify novaclient to support basic attributesshilpa.devharakar2018-06-156-3/+71
| | | | | | | | | | | | | | | | | | | | | | | | Added support for parsing OS_PROJECT_DOMAIN_ID, OS_PROJECT_DOMAIN_NAME, OS_USER_DOMAIN_ID, and OS_USER_DOMAIN_NAME options. Change-Id: I9e1a3426f174c2e6d9f4f6bf10e9aecb62bad8d0 Closes-Bug: #1744118
* | | Merge "Microversion 2.63 - Add trusted_image_certificates"Zuul2018-06-188-4/+465
|\ \ \
| * | | Microversion 2.63 - Add trusted_image_certificatesJackie Truong2018-06-158-4/+465
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change adds a `--trusted-image-certificate-id` option to the `nova boot` and `nova rebuild` commands. This option takes in a a single trusted certificate ID. The option may be used multiple times to specify multiple trusted certificate IDs, which will be used to validate certificates in the image signature verification process. If ID values are not specified using this option, the value of the newly added OS_TRUSTED_IMAGE_CERTIFICATE_IDS environment variable will be used instead. This value will be converted into a list before being passed on. The ``nova rebuild`` command also gets a new ``--trusted-image-certificates-unset`` option to unset/reset the trusted image certificates in a server during rebuild. This is similar to unsetting key_name and user_data during rebuild. Corresponding `trusted_image_certificates` kwarg has been added to the server create and rebuild Python API bindings. Co-Authored-By: Brianna Poulos <Brianna.Poulos@jhuapl.edu> Co-Authored-By: Matt Riedemann <mriedem.os@gmail.com> Change-Id: I235541a689732826950c7b2a510d5835211120c3 Implements: blueprint nova-validate-certificates
* | | Add CLI docs reference for flavor-updateMatt Riedemann2018-06-151-0/+23
| | | | | | | | | | | | | | | | | | | | | When the flavor-update command was added, we didn't have the CLI docs in-tree so this was missed. Change-Id: I3d5da9ac206d82b3fb3c51fa0872a3bae69d0a7e
* | | Remove doc/build when building docsMatt Riedemann2018-06-151-2/+5
|/ / | | | | | | | | | | Wipe out the existing doc/build when rebuilding the docs. Change-Id: Idd7f6dc171425402b8d7ff7962dc09e7c576986b
* | Merge "fix tox python3 overrides"Zuul2018-06-081-0/+7
|\ \
| * | fix tox python3 overridesDoug Hellmann2018-06-061-0/+7
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | We want to default to running all tox environments under python 3, so set the basepython value in each environment. We do not want to specify a minor version number, because we do not want to have to update the file every time we upgrade python. We do not want to set the override once in testenv, because that breaks the more specific versions used in default environments like py35 and py36. Change-Id: I2cb16250241781abe7c5a7d7de37612f07ff2b0b Signed-off-by: Doug Hellmann <doug@doughellmann.com>
* | Remove PyPI downloadsChen2018-06-071-4/+0
|/ | | | | | | | | According to official site, https://packaging.python.org/guides/analyzing-pypi-package-downloads/ PyPI package download statistics is no longer maintained and thus should be removed. Change-Id: I98fb84b6724a43afc91686e939ea26c94a4e8176
* Merge "Revert "Fix listing of instances above API max_limit""10.3.0Zuul2018-06-067-280/+100
|\
| * Revert "Fix listing of instances above API max_limit"Matt Riedemann2018-06-057-280/+100
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit eff607ccef91d09052d58f6798f68d67404f51ce. There was no apparent need for the change being reverted since user can list all servers by specifying --limit=1 when running the nova list command. The change introduced a problem whereby the first pass to list instances from the server would get up to [api]/max_limit (default 1000) results and then call again with a marker. If the last instance in the list (the marker) is corrupted in the instance_mappings table in the API DB by not having an associated cell mapping, listing instances will always fail with a MarkerNotFound error even though the CLI user is not passing a marker nor specifying --limit=-1. The corrupted instance mapping record resulting in the MarkerNotFound error is something else that should be fixed on the server side (and likely result in a 500) but the change in behavior of the CLI makes it always fail if you hit this even if you're not passing a marker. Change-Id: Ibb43f500a74733b85bd3242592d36985bfb45856 Closes-Bug: #1773945
* | Add a note in the nova CLI reference about using OSCMatt Riedemann2018-06-051-0/+8
| | | | | | | | | | | | | | | | We want to eventually ween people off the nova CLI and get them to use the unified openstack CLI, so this adds a note about that. Change-Id: Ia854d2b83b489f67e514a6c066fe1bdc9549f9d3
* | Import nova CLI reference from openstack-manualsMatt Riedemann2018-06-051-42/+3596
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This replaces the old CLI reference main page for the various nova commands with the more complete CLI reference that was in the openstack-manuals report based on the "before-migration" tag in that repo, which was the tag before the centralized docs were dropped in Pike and should have been moved into per-project repos, in this case python-novaclient. The command reference in here is a bit old and should be cleaned up, but this is better than what we have today, which is nothing. Change-Id: If19cfcafc90fddb930c124a5b9845d4eae1f6093 Closes-Bug: #1775281
* | Fix the incorrect cirros default passwordzhang.lei2018-05-091-1/+1
| | | | | | | | | | | | Following by https://docs.openstack.org/image-guide/obtain-images.html#cirros-test Change-Id: Iee3b90900e238b717020c4b7f32e5a5f346bef95
* | Fix the policy argument in server-group-createTakashi NATSUME2018-05-083-2/+11
| | | | | | | | | | | | | | | | | | In the "server-group-create" command, multiple policies can be specified currently. But only one item is allowed in the nova side. So make the command allow only one policy. Change-Id: Ifd2d084faa2b849d6ee466d9accbad21b6a4e11b Closes-Bug: #1767287
* | Make sure microversion < 2.62 does not show host(Id) for instance actionsMatt Riedemann2018-04-271-0/+10
| | | | | | | | | | | | | | | | | | This adds a simple assertion that when microversion < 2.62, the "nova instance-action" CLI does not show host or hostId output. Related to blueprint add-host-to-instance-action-events Change-Id: I6e0866d9daff75046a5e82f57ff745d494b4b5ed
* | Microversion 2.62 - Add host/hostId to instance action eventYikun Jiang2018-04-274-1/+41
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adds support for microversion 2.62 which adds ``host`` (hostname) and ``hostId`` (an obfuscated hashed host id string) fields to the instance action ``GET /servers/{server_id}/os-instance-actions/{req_id}`` API. The event column is already included in the result of "nova instance-action <server> <request-id>" command, therefore does not have any CLI or python API binding impacts in the client. Related nova API change: I2f8b4a12a088b9ed96b428eafde2e0c478fb1db5 Part of blueprint: add-host-to-instance-action-events Change-Id: Iee7e1a3a22249c98873aa96694fd4885916cd097
* | Trivial: Update pypi url to new urlTovin Seven2018-04-201-3/+3
| | | | | | | | | | | | | | | | | | Pypi url changed from [1] to [2] [1] https://pypi.python.org/pypi/<package> [2] https://pypi.org/project/<package> Change-Id: I2b4af1f3d89b775657e03b801ec84ef498ca24c8
* | [CLI] Fix token auth type10.2.0Andrey Kurilin2018-04-193-35/+31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There are 2 known issues which breaks token auth method in CLI: * The wrong check of flag (the check should be for --os-token since arguments are not parsed at that moment) is performed in CLI inner method `_append_global_identity_args`. It led to usage of "password" auth type by default[1] even if `--os-token` cli argument is specified. If `--os-auth-type` is specified to token, keystoneauth1 library makes the right decision[2]. * Based on an auth type, keystoneauth library registers different CLI arguments[3]. It means that `--os-username` argument is available only in password auth type, `--os-token` is available only in token auth type, etc. It also affects the way in which the python code should access such arguments. The arguments which are unrelated to the selected auth type are omitted from the parsed arguments object. That sounds reasonable, but unfortunately the code assumes the unrelated arguments are always present which leads to an AttributeError. Combination of these 2 issues made token auth type broken in CLI layer. [1] https://github.com/openstack/python-novaclient/blob/ee2221f0526c4a6bed431229e363c740d07b8ee9/novaclient/shell.py#L255-L257 [2] https://github.com/openstack/keystoneauth/blob/14dd37b34c4821abf145ea24e593eddaa9f607c8/keystoneauth1/loading/cli.py#L51-L52 [3] https://github.com/openstack/keystoneauth/blob/14dd37b34c4821abf145ea24e593eddaa9f607c8/keystoneauth1/loading/cli.py#L65-L73 Closes-Bug: #1659015 Change-Id: Ibc861d396b71fe105288d8336623cc22cf92523e
* | Merge "Microversion 2.61 - support extra_specs in flavor API"Zuul2018-04-176-6/+66
|\ \
| * | Microversion 2.61 - support extra_specs in flavor APITakashi NATSUME2018-04-176-6/+66
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Starting from microversion 2.61, the responses of the 'Flavor' APIs include the 'extra_specs' parameter. Therefore 'Flavors extra-specs' (os-extra_specs) API calls have been removed in the following commands since microversion 2.61. * nova flavor-list * nova flavor-show Change-Id: I10d621d9b62764114d55cb368e720d182eaffd11 Implements: blueprint add-extra-specs-to-flavor-list
View Lorry Controller Status