delta/openstack/python-openstackclient.git/openstackclient/compute/v2/security_group.py, branch 1.7.2 opendev.org: openstack/python-openstackclient Merge "Use a common decorator to log 'take_action' activation" 2015-09-11T02:43:54+00:00 Jenkins jenkins@review.openstack.org 2015-09-11T02:43:53+00:00 0daa0969392dce50266d8dcac31a68d2ba02602f 






Properly handle port arguments for ICMP
2015-09-03T18:06:45+00:00

Dean Troyer
dtroyer@gmail.com

2015-07-23T20:08:52+00:00

e6706f252642e52dd9de556b92edb769afa57868

The Compute API requires 'from_port' and 'to_port' to be -1 for
ICMP security group rules.  It happily accepts them empty or None
but the resulting rules do not work.  So we force the values for
ICMP rules.

Closes-bug: #1477629
Change-Id: Iba57211014caca16be7c9a28d15d4db2a6c51b8d





The Compute API requires 'from_port' and 'to_port' to be -1 for
ICMP security group rules.  It happily accepts them empty or None
but the resulting rules do not work.  So we force the values for
ICMP rules.

Closes-bug: #1477629
Change-Id: Iba57211014caca16be7c9a28d15d4db2a6c51b8d







Use a common decorator to log 'take_action' activation
2015-09-01T23:49:54+00:00

Joshua Harlow
harlowja@yahoo-inc.com

2015-09-01T23:43:07+00:00

e3c46ece4a496584a54b9d39b55921990db4a7b3

Instead of duplicating the same log statement throughout
the code, the same logic can be provided by a shared decorator
that abstracts away the logging capability and unifies it behind
a common function instead.

Change-Id: Icc63bced7347c8bbf0299a4c5821425a10892a79





Instead of duplicating the same log statement throughout
the code, the same logic can be provided by a shared decorator
that abstracts away the logging capability and unifies it behind
a common function instead.

Change-Id: Icc63bced7347c8bbf0299a4c5821425a10892a79







Fix security group list command
2015-06-02T14:55:54+00:00

TerryHowe
terrylhowe@gmail.com

2015-05-28T13:27:24+00:00

b2cf651100b2a6dc1b934b86390eff94ef9f8fdc

Security group list command tries to get a project list and
this may fail with a multitude of exceptions including but
not limited to 401, 404, ConnectionRefused and EndpointNotFound.
Rather than try to capture every possibility, this patch just
catches the base class.  Converting project ids to names is
less important than having a working security group list command.

Change-Id: I68214d2680bad907f9d04ad3ca2f62cf3feee028
Closes-Bug: #1459629





Security group list command tries to get a project list and
this may fail with a multitude of exceptions including but
not limited to 401, 404, ConnectionRefused and EndpointNotFound.
Rather than try to capture every possibility, this patch just
catches the base class.  Converting project ids to names is
less important than having a working security group list command.

Change-Id: I68214d2680bad907f9d04ad3ca2f62cf3feee028
Closes-Bug: #1459629







Security group rule delete broken
2015-05-07T19:10:06+00:00

TerryHowe
terrylhowe@gmail.com

2015-05-01T18:21:08+00:00

62bb88f621140670c1c2f26397f97cd87fd66b18

Nova client was changed to take a rule id for security group
rule delete.

https://github.com/openstack/python-novaclient/blob/master/novaclient/v2/security_group_rules.py#L72

Change-Id: I0a69f3f196a36f267ee85a651b09aa8d3c328121
Closes-Bug: #1450872





Nova client was changed to take a rule id for security group
rule delete.

https://github.com/openstack/python-novaclient/blob/master/novaclient/v2/security_group_rules.py#L72

Change-Id: I0a69f3f196a36f267ee85a651b09aa8d3c328121
Closes-Bug: #1450872







Merge "Fix security group create description bug"
2015-04-23T20:05:43+00:00

Jenkins
jenkins@review.openstack.org

2015-04-23T20:05:43+00:00

00be0dfc0faaf25f585247af828aa522927f9305












Security group rule create fails
2015-04-22T23:45:33+00:00

Ramaraja Ramachandran
ramaraja.r@hcl.com

2015-04-21T11:10:40+00:00

9b6dada8e371d9e77db129b15acb03a35115591a

By default the --dst-port value is set to None when no --dst-port
argument is provided. By making the default value (0, 0), this allows
novaclient to proceed without any error.

Change-Id: Ibb58f5df5ed1890a8f499dd2467b12b0e79d547b
Closes-Bug: #1443963





By default the --dst-port value is set to None when no --dst-port
argument is provided. By making the default value (0, 0), this allows
novaclient to proceed without any error.

Change-Id: Ibb58f5df5ed1890a8f499dd2467b12b0e79d547b
Closes-Bug: #1443963







Fix security group create description bug
2015-04-22T23:37:31+00:00

Dean Troyer
dtroyer@gmail.com

2015-03-19T16:46:05+00:00

11c39530f5f97a14d534c8d5b7160a1e74f6cdf8

--description is optional in our CLI but the server requires it to be
non-empty.  Set a default value of the given name.

Closes-Bug: #1434172
Change-Id: I81507a77ad8d815000ff411784ae71e229c77f78





--description is optional in our CLI but the server requires it to be
non-empty.  Set a default value of the given name.

Closes-Bug: #1434172
Change-Id: I81507a77ad8d815000ff411784ae71e229c77f78







Merge "Fix help messages"
2015-03-06T13:37:55+00:00

Jenkins
jenkins@review.openstack.org

2015-03-06T13:37:55+00:00

707b5b022f616c597dbce02879aee2eb66eb26c2












Fix help messages
2015-03-04T04:18:40+00:00

Ramaraja
ramaraja.r@hcl.com

2015-03-03T19:25:41+00:00

8e512017c4fb5f032b7dd17335c586a20171d52c

Update help message for openstack security group rule delete
Update help message for openstack security group rule list

Change-Id: I017ffd424ca25b6c62193b91068eb1ba7de6c919
Closes-Bug: #1417854





Update help message for openstack security group rule delete
Update help message for openstack security group rule list

Change-Id: I017ffd424ca25b6c62193b91068eb1ba7de6c919
Closes-Bug: #1417854