From 258c1102cc6b93a860bcd7cc083d4e14ae0025ce Mon Sep 17 00:00:00 2001
From: Akihiro Motoki <motoki@da.jp.nec.com>
Date: Sun, 10 Jan 2016 21:54:53 +0900
Subject: log take_action parameters in a single place

Previously each command logs take_action parameters explicitly
by using @utils.log_method decorator or log.debug().
Some commands have no logging.

This commit calls a logger in the base class and
drops all logging definition from individual commands.

Closes-Bug: #1532294
Change-Id: I43cd0290a4353c68c075bade9571c940733da1be
---
 openstackclient/compute/v2/agent.py | 24 ++++--------------------
 1 file changed, 4 insertions(+), 20 deletions(-)

(limited to 'openstackclient/compute/v2/agent.py')

diff --git a/openstackclient/compute/v2/agent.py b/openstackclient/compute/v2/agent.py
index 75c67f31..59d7dc66 100644
--- a/openstackclient/compute/v2/agent.py
+++ b/openstackclient/compute/v2/agent.py
@@ -15,21 +15,15 @@
 
 """Agent action implementations"""
 
-import logging
 import six
 
-from cliff import command
-from cliff import lister
-from cliff import show
-
+from openstackclient.common import command
 from openstackclient.common import utils
 
 
-class CreateAgent(show.ShowOne):
+class CreateAgent(command.ShowOne):
     """Create compute agent command"""
 
-    log = logging.getLogger(__name__ + ".CreateAgent")
-
     def get_parser(self, prog_name):
         parser = super(CreateAgent, self).get_parser(prog_name)
         parser.add_argument(
@@ -60,7 +54,6 @@ class CreateAgent(show.ShowOne):
         return parser
 
     def take_action(self, parsed_args):
-        self.log.debug("take_action(%s)", parsed_args)
         compute_client = self.app.client_manager.compute
         args = (
             parsed_args.os,
@@ -77,8 +70,6 @@ class CreateAgent(show.ShowOne):
 class DeleteAgent(command.Command):
     """Delete compute agent command"""
 
-    log = logging.getLogger(__name__ + ".DeleteAgent")
-
     def get_parser(self, prog_name):
         parser = super(DeleteAgent, self).get_parser(prog_name)
         parser.add_argument(
@@ -88,16 +79,13 @@ class DeleteAgent(command.Command):
         return parser
 
     def take_action(self, parsed_args):
-        self.log.debug("take_action(%s)", parsed_args)
         compute_client = self.app.client_manager.compute
         compute_client.agents.delete(parsed_args.id)
 
 
-class ListAgent(lister.Lister):
+class ListAgent(command.Lister):
     """List compute agent command"""
 
-    log = logging.getLogger(__name__ + ".ListAgent")
-
     def get_parser(self, prog_name):
         parser = super(ListAgent, self).get_parser(prog_name)
         parser.add_argument(
@@ -107,7 +95,6 @@ class ListAgent(lister.Lister):
         return parser
 
     def take_action(self, parsed_args):
-        self.log.debug("take_action(%s)", parsed_args)
         compute_client = self.app.client_manager.compute
         columns = (
             "Agent ID",
@@ -125,11 +112,9 @@ class ListAgent(lister.Lister):
                 ) for s in data))
 
 
-class SetAgent(show.ShowOne):
+class SetAgent(command.ShowOne):
     """Set compute agent command"""
 
-    log = logging.getLogger(__name__ + ".SetAgent")
-
     def get_parser(self, prog_name):
         parser = super(SetAgent, self).get_parser(prog_name)
         parser.add_argument(
@@ -151,7 +136,6 @@ class SetAgent(show.ShowOne):
         return parser
 
     def take_action(self, parsed_args):
-        self.log.debug("take_action(%s)", parsed_args)
         compute_client = self.app.client_manager.compute
         args = (
             parsed_args.id,
-- 
cgit v1.2.1