From fd876e4cc699d7e6da7c5439a8452c4a8b395139 Mon Sep 17 00:00:00 2001 From: Huanxuan Ao Date: Fri, 23 Sep 2016 13:02:13 +0800 Subject: Fix unset commands to pass normally when nothing specified After I found this problem appear in "volume unset", I checked all the volume command and also found some same problems. This patch fix them all. The main reason of we ignored this problem before is there was not any tests for it. So I add tests for "nothing unset" for them all to test and aviod this problem. Also, I add unit tests for all snapshot commands in volume v1 by the way in this patch. We will need more tests to avoid some ignored problem. Change-Id: I46775f24643d715e168b30785b8b531c0431a55b Partial-bug: #1588588 --- openstackclient/volume/v1/volume_type.py | 2 -- 1 file changed, 2 deletions(-) (limited to 'openstackclient/volume/v1/volume_type.py') diff --git a/openstackclient/volume/v1/volume_type.py b/openstackclient/volume/v1/volume_type.py index 625b34dc..61e9f7fc 100644 --- a/openstackclient/volume/v1/volume_type.py +++ b/openstackclient/volume/v1/volume_type.py @@ -188,10 +188,8 @@ class UnsetVolumeType(command.Command): '--property', metavar='', action='append', - default=[], help=_('Remove a property from this volume type ' '(repeat option to remove multiple properties)'), - required=True, ) return parser -- cgit v1.2.1