summaryrefslogtreecommitdiff
path: root/README.rst
diff options
context:
space:
mode:
authorClay Gerrard <clay.gerrard@gmail.com>2017-03-07 16:52:51 -0800
committerClay Gerrard <clay.gerrard@gmail.com>2017-03-08 10:51:43 -0800
commitdd34af42f8ac8311d857ee1bf509269dfcfcfb24 (patch)
tree67a0303bf16cb3d3e2ddfb66938f720b99fdba50 /README.rst
parent028c4824d0190e0b605ae9c90756167083e46cd3 (diff)
downloadpython-swiftclient-dd34af42f8ac8311d857ee1bf509269dfcfcfb24.tar.gz
Fix MockHttpResponse to be more like the Real
This change pulls out that relatively new [1] little string to pull at in the MockHttpResponse that I think is sorta ugly. And replaces it with the correct behavior that's representative of the Real for which it's standing in (which is sadly our wrapper to make a requests response feel like a httplib.HTTPResponse). It's not clear (to me) the history which allowed this difference in the behavior of the Real and Fake to persist - it seems to have always been this way [2]. I also reworded a relatively new test [1] to cover more code, and make assertions on the desired behavior of the client instead of "just" the http_log method. FWIW, I don't think there was necessarily anything wrong with the scope of the new test [1] - and it certainly makes sense to see new tests copy nearby existing tests. But I subjectively think this smaller test is more demonstrative of the desired behavior. 1. Related-Change-Id: I6d7ccbf4ef9b46e890ecec58842c5cdd2804c7a9 2. Related-Change-Id: If07af46cb377f3f3d70f6c4284037241d360a8b7 Change-Id: Ib99a029c1bd1ea1efa8060fe8a11cb01deea41c6
Diffstat (limited to 'README.rst')
0 files changed, 0 insertions, 0 deletions