From a7115e22f7fbf7705dfa1f62295aaadc2eb3e115 Mon Sep 17 00:00:00 2001 From: Amrith Kumar Date: Fri, 9 Dec 2016 10:09:46 -0500 Subject: secure oslo_messaging.rpc This is an interim commit of the changes for secure oslo-messaging.rpc. In this commit we introduce the code for serializers that will encrypt all traffic being sent on oslo_messaging.rpc. Each guest communicates with the control plane with traffic encrypted using a per-instance key. This includes both traffic from the taskmanager to the guest as well as the guest and the conductor. Per-instance keys are stored in the infrastructure database. These keys are further encrypted in the database. Tests that got annoyed have been placated. Upgrade related changes have been proposed. If an instance has no key, no encryption is performed. If the guest gets no key, it won't encrypt, just pass through. When an instance is upgraded, keys are added. The output of the trove show command (and the show API) have been augmented to show which instances are using secure RPC communication ** if the requestor is an administrator **. A simple caching mechanism for encryption keys has been proposed; this will avoid the frequent database access to get the encryption keys. For Ocata, to handle the upgrade case, None as an encryption_key is a valid one, and is therefore not cached. This is why we can't use something like lrucache. A brief writeup has been included in dev docs (dev/secure_oslo_messaging.rst) which shows how the feature can be used and would help the documentation team write up the documentation for this capability. Change-Id: Iad03f190c99039fd34cbfb0e6aade23de8654b28 DocImpact: see dev/secure_oslo_messaging.rst Blueprint: secure-oslo-messaging-messages Related: If0146f08b3c5ad49a277963fcc685f5192d92edb Related: I04cb76793cbb8b7e404841e9bb864fda93d06504 --- tools/trove-pylint.config | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) (limited to 'tools') diff --git a/tools/trove-pylint.config b/tools/trove-pylint.config index b67f5fa1..fad15049 100644 --- a/tools/trove-pylint.config +++ b/tools/trove-pylint.config @@ -729,6 +729,18 @@ "Instance of 'Table' has no 'create_column' member", "upgrade" ], + [ + "trove/db/sqlalchemy/migrate_repo/versions/041_instance_keys.py", + "E1101", + "Instance of 'Table' has no 'create_column' member", + "upgrade" + ], + [ + "trove/db/sqlalchemy/migrate_repo/versions/041_instance_keys.py", + "no-member", + "Instance of 'Table' has no 'create_column' member", + "upgrade" + ], [ "trove/db/sqlalchemy/migration.py", "E0611", @@ -1107,12 +1119,24 @@ "Class 'InstanceStatus' has no 'LOGGING' member", "SimpleInstance.status" ], + [ + "trove/instance/models.py", + "E1101", + "Instance of 'DBInstance' has no 'encrypted_key' member", + "DBInstance.key" + ], [ "trove/instance/models.py", "no-member", "Class 'InstanceStatus' has no 'LOGGING' member", "SimpleInstance.status" ], + [ + "trove/instance/models.py", + "no-member", + "Instance of 'DBInstance' has no 'encrypted_key' member", + "DBInstance.key" + ], [ "trove/instance/service.py", "E1101", -- cgit v1.2.1