diff options
| author | Clark Boylan <clark.boylan@gmail.com> | 2019-10-01 14:46:50 -0700 |
|---|---|---|
| committer | Clark Boylan <clark.boylan@gmail.com> | 2019-10-01 16:02:41 -0700 |
| commit | 8f59afeaa7cb0c3cbb67dbec7836d5d3b63f0f73 (patch) | |
| tree | 4dd1331b8be99112ed0ffb55fe70ef586940504e | |
| parent | 27579ce4563d11bbf9b7af338118c2109c739dbc (diff) | |
| download | zuul-8f59afeaa7cb0c3cbb67dbec7836d5d3b63f0f73.tar.gz | |
Set url scheme on HTTP Gerrit events
When getting additional change data from the Gerrit HTTP api we weren't
setting the scheme on the resulting change.url value. This resulted in
urls without a scheme which browsers would treat as relative path
components. Fix this by setting a scheme based on the connection
baseurl.
Change-Id: I9e907c79fa531d15c80e593ca7f7cebc5c516165
| -rw-r--r-- | zuul/driver/gerrit/gerritmodel.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/zuul/driver/gerrit/gerritmodel.py b/zuul/driver/gerrit/gerritmodel.py index 1a715c392..9f9bc28ab 100644 --- a/zuul/driver/gerrit/gerritmodel.py +++ b/zuul/driver/gerrit/gerritmodel.py @@ -99,7 +99,7 @@ class GerritChange(Change): self.project = connection.source.getProject(data['project']) self.id = data['change_id'] self.branch = data['branch'] - self.url = '%s/%s' % (baseurl, self.number) + self.url = '%s://%s/%s' % (urlparse.scheme, baseurl, self.number) self.uris = [ '%s/%s' % (baseurl, self.number), '%s/#/c/%s' % (baseurl, self.number), |