summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSimon Westphahl <simon.westphahl@bmw.de>2022-09-26 09:59:40 +0200
committerSimon Westphahl <simon.westphahl@bmw.de>2022-09-26 09:59:40 +0200
commit48ffeb30b31778c04f3b8934d273a6caa422018b (patch)
treef724b474de4dd298e0470b7bbaef933e5b01ccbc
parent2f1e7f2cf58e075ffde49e9d9396b3883de69a38 (diff)
downloadzuul-48ffeb30b31778c04f3b8934d273a6caa422018b.tar.gz
Fix instance check when refreshing dependencies
2022-09-23 10:01:32,395 ERROR zuul.Scheduler: Exception processing pipeline post in tenant foobar Traceback (most recent call last): File "/opt/zuul/lib/python3.10/site-packages/zuul/scheduler.py", line 2089, in process_pipelines refreshed = self._process_pipeline( File "/opt/zuul/lib/python3.10/site-packages/zuul/scheduler.py", line 2157, in _process_pipeline self.process_pipeline_trigger_queue(tenant, pipeline) File "/opt/zuul/lib/python3.10/site-packages/zuul/scheduler.py", line 2350, in process_pipeline_trigger_queue self._process_trigger_event(tenant, pipeline, event) File "/opt/zuul/lib/python3.10/site-packages/zuul/scheduler.py", line 2380, in _process_trigger_event pipeline.manager.refreshDeps(change, event) File "/opt/zuul/lib/python3.10/site-packages/zuul/manager/__init__.py", line 296, in refreshDeps for dep_change_ref in item.change.commit_needs_changes: AttributeError: 'Branch' object has no attribute 'commit_needs_changes' Change-Id: I740d277c59764acfe982a24e3c5e972e8d3179d6
-rw-r--r--zuul/manager/__init__.py2
1 files changed, 1 insertions, 1 deletions
diff --git a/zuul/manager/__init__.py b/zuul/manager/__init__.py
index cd9b2381d..e5e1ee69e 100644
--- a/zuul/manager/__init__.py
+++ b/zuul/manager/__init__.py
@@ -287,7 +287,7 @@ class PipelineManager(metaclass=ABCMeta):
change_in_pipeline = False
for item in self.pipeline.getAllItems():
- if not isinstance(change, model.Change):
+ if not isinstance(item.change, model.Change):
continue
for dep_change_ref in item.change.commit_needs_changes:
if item.change.equals(change):