diff options
| author | Guillaume Chauvel <guillaume.chauvel@gmail.com> | 2021-04-09 13:54:42 +0200 |
|---|---|---|
| committer | Guillaume Chauvel <guillaume.chauvel@gmail.com> | 2021-04-16 21:47:06 +0200 |
| commit | 954986c53862fd6f8c71099b534809ef64ad5255 (patch) | |
| tree | c16f0b76368f12a301e4f5f49e680511c6e708d8 /playbooks | |
| parent | c2403f39916425bb3f0abbd111f0598e4186c950 (diff) | |
| download | zuul-954986c53862fd6f8c71099b534809ef64ad5255.tar.gz | |
Fix FakeGerritRefWatcher and FakeGerritPoller events
Ib9e095430fa82be2327dcf7fd01ee4275b17415f introduced loops in "_run"
methods which have the side effect of events no longer being set.
Some tests are running until timeout expiration.
Test id Runtime
-------------------------------------------------------------- --------
tests.unit.test_gerrit.TestPolling.test_config_update 123.778
tests.unit.test_gerrit.TestPolling.test_post 123.729
tests.unit.test_gerrit.TestChecksApi.test_new_patchset 123.635
tests.unit.test_gerrit.TestPolling.test_tag 123.628
By changing the subclass method used to set event to one inside the
loop, notifications are restored.
Test id Runtime
-------------------------------------------------------------- --------
tests.unit.test_gerrit.TestPolling.test_config_update 5.246
tests.unit.test_gerrit.TestPolling.test_post 5.252
tests.unit.test_gerrit.TestChecksApi.test_new_patchset 5.276
tests.unit.test_gerrit.TestPolling.test_tag 5.247
Change-Id: I8c9ad6577d43b9b4866f83e4f8727615abf239c4
Diffstat (limited to 'playbooks')
0 files changed, 0 insertions, 0 deletions