diff options
author | Ian Wienand <iwienand@redhat.com> | 2020-11-13 11:14:46 +1100 |
---|---|---|
committer | Ian Wienand <iwienand@redhat.com> | 2020-11-13 11:15:52 +1100 |
commit | a58b29c6bf38ff47b12b5583dfc61c50ce083f2a (patch) | |
tree | f37de8cc2f878a2779598d2a37234a373a45cb6d /requirements.txt | |
parent | 01c151a7aef1918bb22e0b372b96efa1a5c5ec29 (diff) | |
download | zuul-a58b29c6bf38ff47b12b5583dfc61c50ce083f2a.tar.gz |
requirements: temporarily pin urblib3 for zuul-client
The reasoning is explained inline. We can remove this when
zuul-client is fixed.
Change-Id: I431d9202cabcc9bf7b60fd643c55b557f6505185
Diffstat (limited to 'requirements.txt')
-rw-r--r-- | requirements.txt | 11 |
1 files changed, 10 insertions, 1 deletions
diff --git a/requirements.txt b/requirements.txt index 313790c18..268c77b19 100644 --- a/requirements.txt +++ b/requirements.txt @@ -33,5 +33,14 @@ cherrypy ws4py routes jsonpath-rw -urllib3!=1.25.4,!=1.25.5 # https://github.com/urllib3/urllib3/pull/1684 +# zuul-client pins to requests==1.24.0 which is incompatible +# with urllib >= 1.26.0. We can not simply remove that pin +# in zuul-client because it runs the zuul-client-zuul-functional +# job, which runs a tox environment. Our tox role first installs +# everything without tests, before installing siblings. This means +# it tries to install the released zuul-client first; ignoring any +# changes to the requirements that might be in the change. +# By pinning urllib3 here we can get that test working, which +# allows us to merge the removal to zuul-client. +urllib3!=1.25.4,!=1.25.5,<1.26.0 # https://github.com/urllib3/urllib3/pull/1684 cheroot!=8.1.*,!=8.2.*,!=8.3.0 # https://github.com/cherrypy/cheroot/issues/263 |