summaryrefslogtreecommitdiff
path: root/tests
diff options
context:
space:
mode:
authorZuul <zuul@review.opendev.org>2019-09-20 19:48:20 +0000
committerGerrit Code Review <review@openstack.org>2019-09-20 19:48:20 +0000
commit84f5e22385d5bf634512ed9d5ed6259e94331cde (patch)
treea7e2ceb799c96a5d5f26177fcae7b5daebe24587 /tests
parentb865ec81bd5ebb243d1ee26258eafb12fc7ebb34 (diff)
parent2c1c9ae662d0bd08a5c35e0e796a7de3e1c0967a (diff)
downloadzuul-84f5e22385d5bf634512ed9d5ed6259e94331cde.tar.gz
Merge "Record held node IDs with autohold request"
Diffstat (limited to 'tests')
-rw-r--r--tests/unit/test_scheduler.py3
1 files changed, 3 insertions, 0 deletions
diff --git a/tests/unit/test_scheduler.py b/tests/unit/test_scheduler.py
index dd73dd8b1..15bef5621 100644
--- a/tests/unit/test_scheduler.py
+++ b/tests/unit/test_scheduler.py
@@ -1643,6 +1643,7 @@ class TestScheduler(ZuulTestCase):
self.assertEqual('reason text', request.reason)
self.assertEqual(1, request.max_count)
self.assertEqual(0, request.current_count)
+ self.assertEqual([], request.nodes)
# First check that successful jobs do not autohold
A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
@@ -1693,8 +1694,10 @@ class TestScheduler(ZuulTestCase):
self.assertEqual(held_node['comment'], "reason text")
# The hold request current_count should have incremented
+ # and we should have recorded the held node ID.
request2 = self.zk.getHoldRequest(request.id)
self.assertEqual(request.current_count + 1, request2.current_count)
+ self.assertEqual(1, len(request2.nodes))
# Another failed change should not hold any more nodes
C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')