diff options
author | Ian Wienand <iwienand@redhat.com> | 2022-09-15 09:42:52 +1000 |
---|---|---|
committer | Ian Wienand <iwienand@redhat.com> | 2022-09-15 12:03:46 +1000 |
commit | 203c438a472350061c5401683b96d4de7c14d9f6 (patch) | |
tree | 4728c30c810d13c3d673b89cb0d9202f29660d43 /web/src | |
parent | 8e9c97f3a38fd8be644f3e2209fea026e558ebfe (diff) | |
download | zuul-203c438a472350061c5401683b96d4de7c14d9f6.tar.gz |
web: better non-expandable console padding
Inspried by comments in [1]; put a disabled and non-visible button
styled in the same way as the expandable content button here as
padding for items that don't expand.
[1] https://github.com/patternfly/patternfly-react/issues/7950#issuecomment-1239895122
Change-Id: I33fdafb4e5b98e546c8615a3d65f52c944521cf7
Diffstat (limited to 'web/src')
-rw-r--r-- | web/src/containers/build/Console.jsx | 17 |
1 files changed, 11 insertions, 6 deletions
diff --git a/web/src/containers/build/Console.jsx b/web/src/containers/build/Console.jsx index 50cce2020..f677dfbd2 100644 --- a/web/src/containers/build/Console.jsx +++ b/web/src/containers/build/Console.jsx @@ -20,6 +20,7 @@ import PropTypes from 'prop-types' import ReactJson from 'react-json-view' import { + Button, Chip, DataList, DataListItem, @@ -36,6 +37,7 @@ import { } from '@patternfly/react-core' import { + AngleRightIcon, ContainerNodeIcon, InfoCircleIcon, SearchPlusIcon, @@ -227,17 +229,20 @@ class HostTask extends React.Component { // NOTE(ianw) 2022-08-26 since we have some rows that expand and // others that don't, the expansion button pushes things out of - // alignment. This is based on me finding the > icon has a - // min-width of 40px, and then trying to find the right variable - // to extend the cell padding/margins the same as the toggle - // control. + // alignment. This tries to emulate the button and then + // hide it. See also: // https://github.com/patternfly/patternfly/issues/5055 // We might want to think about other ways to present this? if (!interestingKeys) { dataListCells.push( <DataListCell key='padding-icon' isIcon={true} - style={{marginRight: 'var(--pf-c-data-list__item-control--MarginRight)'}}> - <span style={{display: 'inline-block', minWidth: '40px'}}></span> + class='pf-c-data-list__item-control'> + <div className='pf-c-data-list__toggle' + style={{visibility: 'hidden'}}> + <Button disabled> + <AngleRightIcon /> + </Button> + </div> </DataListCell> ) } |