Update to create-react-app 3.4.1

While trying to figure out why the ansi patch wouldn't
build it emerged that we're now 2 major releases behind
on create-react-app.

Update create-react-app to the latest 3.4.1. This also updates
react to 16.13, and updates eslint globals processing so that
we don't have to declare globals in headers when we've
declared them already in the eslint file.

Finally, although this doesn't do it, create-react-app 3
has support for typescript, so if we want we can start migrating
files to .ts or .tsx extensions and start doing typing in
them.

Pin nanoid to v2 until such a time as create-react-app can be
updated to 3.4.2 which is needed ot handle .cjs extensions
being used by nanoid.

Change-Id: Ibc69bef605a62e4fdd2ebba33d9d1b822e7dfeba

16 files changed, 5 insertions, 14 deletions

diff --git a/web/src/App.test.jsx b/web/src/App.test.jsx
index ea981dea2..ced7ac0e1 100644
--- a/web/src/App.test.jsx
+++ b/web/src/App.test.jsx
@@ -1,4 +1,3 @@
-/* global Promise, expect, jest, it, location */
 // Copyright 2018 Red Hat, Inc
 //
 // Licensed under the Apache License, Version 2.0 (the "License"); you may
diff --git a/web/src/actions/build.test.js b/web/src/actions/build.test.js
index 436d96dcc..c3c82d03d 100644
--- a/web/src/actions/build.test.js
+++ b/web/src/actions/build.test.js
@@ -1,4 +1,3 @@
-/* global expect, it */
 // Copyright 2019 Red Hat, Inc
 //
 // Licensed under the Apache License, Version 2.0 (the "License"); you may
diff --git a/web/src/actions/change.js b/web/src/actions/change.js
index 9029828e5..88305aed0 100644
--- a/web/src/actions/change.js
+++ b/web/src/actions/change.js
@@ -1,4 +1,3 @@
-/* global Promise */
 // Copyright 2018 Red Hat, Inc
 //
 // Licensed under the Apache License, Version 2.0 (the "License"); you may
diff --git a/web/src/actions/job.js b/web/src/actions/job.js
index 06d384c1e..039582637 100644
--- a/web/src/actions/job.js
+++ b/web/src/actions/job.js
@@ -1,4 +1,3 @@
-/* global Promise */
 // Copyright 2018 Red Hat, Inc
 //
 // Licensed under the Apache License, Version 2.0 (the "License"); you may
diff --git a/web/src/actions/jobs.js b/web/src/actions/jobs.js
index 42f9d1c58..6581a35fd 100644
--- a/web/src/actions/jobs.js
+++ b/web/src/actions/jobs.js
@@ -1,4 +1,3 @@
-/* global Promise */
 // Copyright 2018 Red Hat, Inc
 //
 // Licensed under the Apache License, Version 2.0 (the "License"); you may
diff --git a/web/src/actions/project.js b/web/src/actions/project.js
index f2c64adb6..a780ac8f3 100644
--- a/web/src/actions/project.js
+++ b/web/src/actions/project.js
@@ -1,4 +1,3 @@
-/* global Promise */
 // Copyright 2018 Red Hat, Inc
 //
 // Licensed under the Apache License, Version 2.0 (the "License"); you may
diff --git a/web/src/actions/projects.js b/web/src/actions/projects.js
index 18c91ea29..3e711c1ca 100644
--- a/web/src/actions/projects.js
+++ b/web/src/actions/projects.js
@@ -1,4 +1,3 @@
-/* global Promise */
 // Copyright 2018 Red Hat, Inc
 //
 // Licensed under the Apache License, Version 2.0 (the "License"); you may
diff --git a/web/src/actions/status.js b/web/src/actions/status.js
index 528c7dc11..e5bd57ebc 100644
--- a/web/src/actions/status.js
+++ b/web/src/actions/status.js
@@ -1,4 +1,3 @@
-/* global Promise */
 // Copyright 2018 Red Hat, Inc
 //
 // Licensed under the Apache License, Version 2.0 (the "License"); you may
diff --git a/web/src/api.js b/web/src/api.js
index 776a04e05..619da3358 100644
--- a/web/src/api.js
+++ b/web/src/api.js
@@ -1,4 +1,4 @@
-/* global process, window */
+/* global process */
 // Copyright 2018 Red Hat, Inc
 //
 // Licensed under the Apache License, Version 2.0 (the "License"); you may
diff --git a/web/src/containers/Refreshable.jsx b/web/src/containers/Refreshable.jsx
index e815602d1..c52f77b70 100644
--- a/web/src/containers/Refreshable.jsx
+++ b/web/src/containers/Refreshable.jsx
@@ -44,6 +44,8 @@ class Refreshable extends React.Component {
     const { remoteData } = this.props
     return (
       <Spinner loading={ remoteData.isFetching }>
+        {/* Lint warning jsx-a11y/anchor-is-valid */}
+        {/* eslint-disable-next-line */}
         <a className="refresh" onClick={() => {this.updateData(true)}}>
           <Icon type="fa" name="refresh" /> refresh&nbsp;&nbsp;
         </a>
diff --git a/web/src/containers/TableFilters.jsx b/web/src/containers/TableFilters.jsx
index 9529911ec..cf97a561c 100644
--- a/web/src/containers/TableFilters.jsx
+++ b/web/src/containers/TableFilters.jsx
@@ -1,4 +1,3 @@
-/* global URLSearchParams */
 // Copyright 2018 Red Hat, Inc
 //
 // Licensed under the Apache License, Version 2.0 (the "License"); you may
diff --git a/web/src/containers/status/ChangePanel.test.jsx b/web/src/containers/status/ChangePanel.test.jsx
index a44c9c8b4..d432c0105 100644
--- a/web/src/containers/status/ChangePanel.test.jsx
+++ b/web/src/containers/status/ChangePanel.test.jsx
@@ -1,4 +1,3 @@
-/* global expect, it */
 // Copyright 2018 Red Hat, Inc
 //
 // Licensed under the Apache License, Version 2.0 (the "License"); you may
diff --git a/web/src/pages/ChangeStatus.jsx b/web/src/pages/ChangeStatus.jsx
index 0abbf6d7c..df607aabe 100644
--- a/web/src/pages/ChangeStatus.jsx
+++ b/web/src/pages/ChangeStatus.jsx
@@ -1,4 +1,3 @@
-/* global setTimeout, clearTimeout */
 // Copyright 2018 Red Hat, Inc
 //
 // Licensed under the Apache License, Version 2.0 (the "License"); you may
diff --git a/web/src/pages/ConfigErrors.jsx b/web/src/pages/ConfigErrors.jsx
index aa0f00b46..c42ab1e06 100644
--- a/web/src/pages/ConfigErrors.jsx
+++ b/web/src/pages/ConfigErrors.jsx
@@ -37,6 +37,8 @@ class ConfigErrorsPage extends React.Component {
     return (
       <React.Fragment>
         <div className="pull-right">
+          {/* Lint warning jsx-a11y/anchor-is-valid */}
+          {/* eslint-disable-next-line */}
           <a className="refresh" onClick={() => {this.updateData()}}>
             <Icon type="fa" name="refresh" /> refresh&nbsp;&nbsp;
           </a>
diff --git a/web/src/pages/Status.jsx b/web/src/pages/Status.jsx
index 84555b5d2..cc555889a 100644
--- a/web/src/pages/Status.jsx
+++ b/web/src/pages/Status.jsx
@@ -1,4 +1,3 @@
-/* global setTimeout, clearTimeout */
 // Copyright 2018 Red Hat, Inc
 //
 // Licensed under the Apache License, Version 2.0 (the "License"); you may
diff --git a/web/src/pages/Stream.jsx b/web/src/pages/Stream.jsx
index 1d34a345b..45285dc7d 100644
--- a/web/src/pages/Stream.jsx
+++ b/web/src/pages/Stream.jsx
@@ -1,4 +1,3 @@
-/* global JSON, URLSearchParams */
 // Copyright 2018 Red Hat, Inc
 //
 // Licensed under the Apache License, Version 2.0 (the "License"); you may