summaryrefslogtreecommitdiff
path: root/web
diff options
context:
space:
mode:
authorJames E. Blair <jim@acmegating.com>2022-02-24 18:32:20 -0800
committerJames E. Blair <jim@acmegating.com>2022-02-24 18:32:20 -0800
commit370d36c0257b5849c0b08308073b690b16b2a180 (patch)
treeaaf5f1bc5873644ca40f3aae920589d083342d95 /web
parente03d8c887c092367b9ff2b00b48f244d4f6584f9 (diff)
downloadzuul-370d36c0257b5849c0b08308073b690b16b2a180.tar.gz
Add MERGE_FAILURE buildset result
We now report a distinct buildset result to the database if the upstream code review system is unable to merge a change. Previously it was reported as MERGE_CONFLICT which makes it difficult to distinguish from merge conflicts. Essentially, the two states we're interested in are when Zuul's merger is unable to prepare a git checkout of the change (99% of the time, this is a merge conflict). This is the MERGE_CONFLICT result. The second state is when Zuul asks Gerrit/Github/etc to submit/merge a change and the remote system is unable (or refuses) to do so. This is MERGE_FAILURE. Change-Id: I47af242aeb19ae4b4aedde353fcc76ff82d90fbe
Diffstat (limited to 'web')
-rw-r--r--web/src/containers/build/Misc.jsx5
-rw-r--r--web/src/containers/charts/Misc.jsx5
-rw-r--r--web/src/pages/Builds.jsx1
-rw-r--r--web/src/pages/Buildsets.jsx1
4 files changed, 12 insertions, 0 deletions
diff --git a/web/src/containers/build/Misc.jsx b/web/src/containers/build/Misc.jsx
index f52fbcd96..51ce1c07a 100644
--- a/web/src/containers/build/Misc.jsx
+++ b/web/src/containers/build/Misc.jsx
@@ -63,6 +63,11 @@ const RESULT_ICON_CONFIGS = {
color: 'var(--pf-global--warning-color--100)',
badgeColor: 'orange',
},
+ MERGE_FAILURE: {
+ icon: ExclamationIcon,
+ color: 'var(--pf-global--warning-color--100)',
+ badgeColor: 'orange',
+ },
NODE_FAILURE: {
icon: ExclamationIcon,
color: 'var(--pf-global--warning-color--100)',
diff --git a/web/src/containers/charts/Misc.jsx b/web/src/containers/charts/Misc.jsx
index d55c459b5..e4e891766 100644
--- a/web/src/containers/charts/Misc.jsx
+++ b/web/src/containers/charts/Misc.jsx
@@ -46,6 +46,11 @@ const buildResultLegendData = [
symbol: { fill: '#EF9234' },
},
{
+ name: 'MERGE_FAILURE',
+ // PF orange-200
+ symbol: { fill: '#EF9234' },
+ },
+ {
name: 'NODE_FAILURE',
// PF orange-300
symbol: { fill: '#EC7A08' },
diff --git a/web/src/pages/Builds.jsx b/web/src/pages/Builds.jsx
index 0e76a73be..7165e143b 100644
--- a/web/src/pages/Builds.jsx
+++ b/web/src/pages/Builds.jsx
@@ -83,6 +83,7 @@ class BuildsPage extends React.Component {
'SKIPPED',
'NODE_FAILURE',
'MERGE_CONFLICT',
+ 'MERGE_FAILURE',
'CONFIG_ERROR',
'TIMED_OUT',
'CANCELED',
diff --git a/web/src/pages/Buildsets.jsx b/web/src/pages/Buildsets.jsx
index 382df5eb2..98d86d640 100644
--- a/web/src/pages/Buildsets.jsx
+++ b/web/src/pages/Buildsets.jsx
@@ -71,6 +71,7 @@ class BuildsetsPage extends React.Component {
'SUCCESS',
'FAILURE',
'MERGE_CONFLICT',
+ 'MERGE_FAILURE',
'DEQUEUED',
]
},