diff options
author | James E. Blair <jim@acmegating.com> | 2022-02-24 15:38:45 -0800 |
---|---|---|
committer | James E. Blair <jim@acmegating.com> | 2022-02-24 17:06:03 -0800 |
commit | e03d8c887c092367b9ff2b00b48f244d4f6584f9 (patch) | |
tree | 043c71903b544ccc36505f89c2836a2daa72efa7 /web | |
parent | 99b0eade8c42fab800d344555682c9e14c8b20aa (diff) | |
download | zuul-e03d8c887c092367b9ff2b00b48f244d4f6584f9.tar.gz |
Rename MERGER_FAILURE to MERGE_CONFLICT
This is a prelude to a change which will report a distinct buildset result
to the database if the upstream code review system is unable to merge a change.
Currently it is reported as MERGER_FAILURE which makes it difficult to
distinguish from merge conflicts.
Essentially, the two states we're interested in are when Zuul's merger is
unable to prepare a git checkout of the change (99% of the time, this is
a merge conflict). This will be known as MERGE_CONFLICT now.
The second state is when Zuul asks Gerrit/Github/etc to submit/merge a change
and the remote system is unable (or refuses) to do so. In a future change,
that will be reported as MERGE_FAILURE.
To avoid confusion and use names which better reflect the situation, this change
performs the rename to MERGE_CONFLICT.
Because there are pipeline configuration options tied to the MERGER_FAILURE
status (which start with 'merge-failure') they are also renamed to 'merge-conflict'.
The old names are supported for backwards compatibility.
A SQL migration takes care of updating values in the database.
The upgrade procedure is noted as being special because of the db value updates.
If an operator doesn't follow the recommended procedure, however, the consequences
are minimal (builds which won't be easily queried in the web ui; that can be
manually corrected if desired).
A model API change is not needed since the only place where we receive this value
from ZK can be updated to accept both values.
Change-Id: I3050409ed68805c748efe7a176b9755fa281536f
Diffstat (limited to 'web')
-rw-r--r-- | web/src/containers/build/Misc.jsx | 2 | ||||
-rw-r--r-- | web/src/containers/charts/Misc.jsx | 4 | ||||
-rw-r--r-- | web/src/pages/Builds.jsx | 2 | ||||
-rw-r--r-- | web/src/pages/Buildsets.jsx | 2 |
4 files changed, 5 insertions, 5 deletions
diff --git a/web/src/containers/build/Misc.jsx b/web/src/containers/build/Misc.jsx index 53270d83b..f52fbcd96 100644 --- a/web/src/containers/build/Misc.jsx +++ b/web/src/containers/build/Misc.jsx @@ -58,7 +58,7 @@ const RESULT_ICON_CONFIGS = { color: 'var(--pf-global--info-color--100)', badgeColor: 'yellow', }, - MERGER_FAILURE: { + MERGE_CONFLICT: { icon: ExclamationIcon, color: 'var(--pf-global--warning-color--100)', badgeColor: 'orange', diff --git a/web/src/containers/charts/Misc.jsx b/web/src/containers/charts/Misc.jsx index 9ee90e5e6..d55c459b5 100644 --- a/web/src/containers/charts/Misc.jsx +++ b/web/src/containers/charts/Misc.jsx @@ -41,7 +41,7 @@ const buildResultLegendData = [ symbol: { fill: '#F6D173' }, }, { - name: 'MERGER_FAILURE', + name: 'MERGE_CONFLICT', // PF orange-200 symbol: { fill: '#EF9234' }, }, @@ -81,4 +81,4 @@ const buildsBarStyle = { } } -export { buildResultLegendData, buildsBarStyleMap, buildsBarStyle }
\ No newline at end of file +export { buildResultLegendData, buildsBarStyleMap, buildsBarStyle } diff --git a/web/src/pages/Builds.jsx b/web/src/pages/Builds.jsx index 3517e14a7..0e76a73be 100644 --- a/web/src/pages/Builds.jsx +++ b/web/src/pages/Builds.jsx @@ -82,7 +82,7 @@ class BuildsPage extends React.Component { 'POST_FAILURE', 'SKIPPED', 'NODE_FAILURE', - 'MERGER_FAILURE', + 'MERGE_CONFLICT', 'CONFIG_ERROR', 'TIMED_OUT', 'CANCELED', diff --git a/web/src/pages/Buildsets.jsx b/web/src/pages/Buildsets.jsx index f0d0e5277..382df5eb2 100644 --- a/web/src/pages/Buildsets.jsx +++ b/web/src/pages/Buildsets.jsx @@ -70,7 +70,7 @@ class BuildsetsPage extends React.Component { options: [ 'SUCCESS', 'FAILURE', - 'MERGER_FAILURE', + 'MERGE_CONFLICT', 'DEQUEUED', ] }, |