diff options
author | Jesse Keating <omgjlk@us.ibm.com> | 2017-06-13 15:54:11 -0700 |
---|---|---|
committer | Jesse Keating <omgjlk@us.ibm.com> | 2017-06-14 09:54:18 -0700 |
commit | fd2a0ad378fbcf1f76753f0d5bd17b1a0281f9a0 (patch) | |
tree | b9b98be643139ce75229c030c1959aeeb8c060f6 /zuul/driver/github/githubsource.py | |
parent | d570c1c0bc341d9afee6b49755acad05ed0ba359 (diff) | |
download | zuul-fd2a0ad378fbcf1f76753f0d5bd17b1a0281f9a0.tar.gz |
Implement pipeline reject filter for github
Parts of this were already added, the schema and even a test layout that
used the option. However it was never fully plumbed into the github
model. This change completes that work and adjusts a test to exercise
the reject filter.
Story: 2000774
Task: 4633
Change-Id: I632b71a0ea3d8c6ba0e92f22595d38684705dbe8
Diffstat (limited to 'zuul/driver/github/githubsource.py')
-rw-r--r-- | zuul/driver/github/githubsource.py | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/zuul/driver/github/githubsource.py b/zuul/driver/github/githubsource.py index 1c2f72718..519ebf16a 100644 --- a/zuul/driver/github/githubsource.py +++ b/zuul/driver/github/githubsource.py @@ -101,7 +101,11 @@ class GithubSource(BaseSource): return [f] def getRejectFilters(self, config): - return [] + f = GithubRefFilter( + connection_name=self.connection.connection_name, + reject_reviews=to_list(config.get('review')) + ) + return [f] review = v.Schema({'username': str, |