summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--bindep.txt3
-rw-r--r--zuul/driver/gerrit/gerritsource.py4
-rw-r--r--zuul/driver/github/githubsource.py2
-rw-r--r--zuul/driver/gitlab/gitlabsource.py2
-rw-r--r--zuul/driver/pagure/paguresource.py2
5 files changed, 6 insertions, 7 deletions
diff --git a/bindep.txt b/bindep.txt
index 3248cbaab..313d22754 100644
--- a/bindep.txt
+++ b/bindep.txt
@@ -50,8 +50,7 @@ git
rsync
curl
gettext [platform:apk]
-unzip [platform:apk]
-unzip [platform:rpm]
+unzip
bzip2
openssh-client [platform:debian platform:apk]
openssh [platform:rpm]
diff --git a/zuul/driver/gerrit/gerritsource.py b/zuul/driver/gerrit/gerritsource.py
index 2da5076cc..a59781d09 100644
--- a/zuul/driver/gerrit/gerritsource.py
+++ b/zuul/driver/gerrit/gerritsource.py
@@ -107,8 +107,8 @@ class GerritSource(BaseSource):
return changes
def getCachedChanges(self):
- for x in self.connection._change_cache.values():
- for y in x.values():
+ for x in list(self.connection._change_cache.values()):
+ for y in list(x.values()):
yield y
def getProject(self, name):
diff --git a/zuul/driver/github/githubsource.py b/zuul/driver/github/githubsource.py
index 50f85b075..2b647b683 100644
--- a/zuul/driver/github/githubsource.py
+++ b/zuul/driver/github/githubsource.py
@@ -95,7 +95,7 @@ class GithubSource(BaseSource):
return self.connection.getChangesDependingOn(change, projects, tenant)
def getCachedChanges(self):
- return self.connection._change_cache.values()
+ return list(self.connection._change_cache.values())
def getProject(self, name):
p = self.connection.getProject(name)
diff --git a/zuul/driver/gitlab/gitlabsource.py b/zuul/driver/gitlab/gitlabsource.py
index d477adeb7..65033c305 100644
--- a/zuul/driver/gitlab/gitlabsource.py
+++ b/zuul/driver/gitlab/gitlabsource.py
@@ -59,7 +59,7 @@ class GitlabSource(BaseSource):
raise NotImplementedError()
def getCachedChanges(self):
- return self.connection._change_cache.values()
+ return list(self.connection._change_cache.values())
def getProject(self, name):
p = self.connection.getProject(name)
diff --git a/zuul/driver/pagure/paguresource.py b/zuul/driver/pagure/paguresource.py
index 40862d307..8fbb50bac 100644
--- a/zuul/driver/pagure/paguresource.py
+++ b/zuul/driver/pagure/paguresource.py
@@ -90,7 +90,7 @@ class PagureSource(BaseSource):
change, projects, tenant)
def getCachedChanges(self):
- return self.connection._change_cache.values()
+ return list(self.connection._change_cache.values())
def getProject(self, name):
p = self.connection.getProject(name)