From 2af7139e3fafc9f6d023400465e9d30eb2fde4a2 Mon Sep 17 00:00:00 2001 From: David Shrewsbury Date: Thu, 4 Jan 2018 11:50:12 -0500 Subject: Don't remove builds that don't exist We saw test_reconfigure_window_fixed test fail in the change to switch to Ansible 2.4. This may have been a timing bug where we try to remove a build that we've already removed. Change-Id: Ic55eeb35589b6469b0dcce8267f49eda852a49f7 --- zuul/model.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/zuul/model.py b/zuul/model.py index cc2fea7e2..16a701ddc 100644 --- a/zuul/model.py +++ b/zuul/model.py @@ -1386,6 +1386,8 @@ class BuildSet(object): build.build_set = self def removeBuild(self, build): + if build.job.name not in self.builds: + return self.tries[build.job.name] += 1 del self.builds[build.job.name] -- cgit v1.2.1