From bfe3bdc8f530eb8267b18ffecea21845a11ee550 Mon Sep 17 00:00:00 2001 From: Fabien Boucher Date: Tue, 21 Dec 2021 11:11:40 +0000 Subject: gerrit driver - skip ignored events before they hit zookeeper Change-Id: Idc3d0c2a1c4ceb752065d961ac84e480e3bf8415 --- zuul/driver/gerrit/gerritconnection.py | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) (limited to 'zuul/driver/gerrit') diff --git a/zuul/driver/gerrit/gerritconnection.py b/zuul/driver/gerrit/gerritconnection.py index 69e651b6e..0e242a8e6 100644 --- a/zuul/driver/gerrit/gerritconnection.py +++ b/zuul/driver/gerrit/gerritconnection.py @@ -230,13 +230,6 @@ class GerritEventConnector(threading.Thread): event.type = data.get('type') event.uuid = data.get('uuid') - # NOTE(mnaser): Certain plugins fire events which end up causing - # an unrecognized event log *and* a traceback if they - # do not contain full project information, we skip them - # here to keep logs clean. - if event.type in GerritEventConnector.IGNORED_EVENTS: - return - # This catches when a change is merged, as it could potentially # have merged layout info which will need to be read in. # Ideally this would be done with a refupdate event so as to catch @@ -1122,6 +1115,13 @@ class GerritConnection(ZKChangeCacheMixin, ZKBranchCacheMixin, BaseConnection): return True def addEvent(self, data): + # NOTE(mnaser): Certain plugins fire events which end up causing + # an unrecognized event log *and* a traceback if they + # do not contain full project information, we skip them + # here to keep logs clean. + if data.get('type') in GerritEventConnector.IGNORED_EVENTS: + return + event = { "timestamp": time.time(), "payload": data -- cgit v1.2.1