delta/openvswitch.git/datapath/actions.c, branch master

make: Remove the Linux datapath.

2022-07-15T11:45:55+00:00

Update the necessary make and configure files to remove the Linux
datapath and then remove the datapath.

Move datapath/linux/compat/include/linux/openvswitch.h to
include/linux/openvswitch.h because it is needed to generate header
files used by the userspace switch.

Also remove references to the Linux datapath from auxiliary files
and utilities since it is no longer supported.

Signed-off-by: Greg Rose 
Reviewed-by: David Marchand 
Signed-off-by: Ilya Maximets

Datapath: Change in openvswitch kernel module to support MPLS label depth of 3 in ingress direction.

2019-11-22T17:26:47+00:00

Upstream commit:
    commit fbdcdd78da7c95f1b970d371e1b23cbd3aa990f3
    Author: Martin Varghese 
    Date:   Mon Nov 4 07:27:44 2019 +0530

    Change in Openvswitch to support MPLS label depth of 3 in ingress
    direction

    The openvswitch was supporting a MPLS label depth of 1 in the
    ingress direction though the userspace OVS supports a max depth
    of 3 labels.This change enables openvswitch module to support a
    max depth of 3 labels in the ingress.

    Signed-off-by: Martin Varghese 
    Acked-by: Pravin B Shelar 
    Signed-off-by: David S. Miller 

Tested-by: Greg Rose 
Reviewed-by: Greg Rose 
Signed-off-by: Martin Varghese 
Signed-off-by: Ben Pfaff

datapath: fix csum updates for MPLS actions

2019-07-10T20:04:27+00:00

Upstream commit:
    commit 0e3183cd2a64843a95b62f8bd4a83605a4cf0615
    Author: John Hurley 
    Date:   Thu Jun 27 14:37:30 2019 +0100

    net: openvswitch: fix csum updates for MPLS actions

    Skbs may have their checksum value populated by HW. If this is a checksum
    calculated over the entire packet then the CHECKSUM_COMPLETE field is
    marked. Changes to the data pointer on the skb throughout the network
    stack still try to maintain this complete csum value if it is required
    through functions such as skb_postpush_rcsum.

    The MPLS actions in Open vSwitch modify a CHECKSUM_COMPLETE value when
    changes are made to packet data without a push or a pull. This occurs when
    the ethertype of the MAC header is changed or when MPLS lse fields are
    modified.

    The modification is carried out using the csum_partial function to get the
    csum of a buffer and add it into the larger checksum. The buffer is an
    inversion of the data to be removed followed by the new data. Because the
    csum is calculated over 16 bits and these values align with 16 bits, the
    effect is the removal of the old value from the CHECKSUM_COMPLETE and
    addition of the new value.

    However, the csum fed into the function and the outcome of the
    calculation are also inverted. This would only make sense if it was the
    new value rather than the old that was inverted in the input buffer.

    Fix the issue by removing the bit inverts in the csum_partial calculation.

    The bug was verified and the fix tested by comparing the folded value of
    the updated CHECKSUM_COMPLETE value with the folded value of a full
    software checksum calculation (reset skb->csum to 0 and run
    skb_checksum_complete(skb)). Prior to the fix the outcomes differed but
    after they produce the same result.

    Fixes: 25cd9ba0abc0 ("openvswitch: Add basic MPLS support to kernel")
    Fixes: bc7cc5999fd3 ("openvswitch: update checksum in {push,pop}_mpls")
    Signed-off-by: John Hurley 
    Reviewed-by: Jakub Kicinski 
    Reviewed-by: Simon Horman 
    Acked-by: Pravin B Shelar 
    Signed-off-by: David S. Miller 

Fixes: ccf4378615e9 ("datapath: Add basic MPLS support to kernel")
Fixes: b51367aad315 ("datapath: update checksum in {push,pop}_mpls")
Cc: John Hurley 
Acked-by: William Tu 
Signed-off-by: Greg Rose 
Signed-off-by: Ben Pfaff

OVS: remove use of VLAN_TAG_PRESENT

2019-06-13T17:03:11+00:00

Upstream commits:
    (1) commit 9df46aefafa6dee81a27c2a9d8ba360abd8c5fe3
    Author: Michał Mirosław 
    Date:   Thu Nov 8 18:44:50 2018 +0100

    OVS: remove use of VLAN_TAG_PRESENT

    This is a minimal change to allow removing of VLAN_TAG_PRESENT.
    It leaves OVS unable to use CFI bit, as fixing this would need
    a deeper surgery involving userspace interface.

    Signed-off-by: Michał Mirosław 
    Signed-off-by: David S. Miller 

    (2) commit 6083e28aa02d7c9e6b87f8b944e92793094ae047
    Author: Michał Mirosław 
    Date:   Sat Nov 10 19:55:34 2018 +0100

    OVS: remove VLAN_TAG_PRESENT - fixup

    It turns out I missed one VLAN_TAG_PRESENT in OVS code while rebasing.
    This fixes it.

    Fixes: 9df46aefafa6 ("OVS: remove use of VLAN_TAG_PRESENT")
    Signed-off-by: Michał Mirosław 
    Signed-off-by: David S. Miller 

This patch backports the above upstream patch to OVS and adds
extra checking in kernel module's compat code.

Cc: Michał Mirosław 
Acked-by: Yi-Hung Wei 
Signed-off-by: Yifeng Sun 
Signed-off-by: Ben Pfaff

datapath: Add a new action check_pkt_len

2019-04-22T19:56:51+00:00

Upstream commit:
    commit 4d5ec89fc8d14dcdab7214a0c13a1c7321dc6ea9
    Author: Numan Siddique 
    Date:   Tue Mar 26 06:13:46 2019 +0530

    net: openvswitch: Add a new action check_pkt_len

    This patch adds a new action - 'check_pkt_len' which checks the
    packet length and executes a set of actions if the packet
    length is greater than the specified length or executes
    another set of actions if the packet length is lesser or equal to.

    This action takes below nlattrs
      * OVS_CHECK_PKT_LEN_ATTR_PKT_LEN - 'pkt_len' to check for

      * OVS_CHECK_PKT_LEN_ATTR_ACTIONS_IF_GREATER - Nested actions
        to apply if the packet length is greater than the specified 'pkt_len'

      * OVS_CHECK_PKT_LEN_ATTR_ACTIONS_IF_LESS_EQUAL - Nested
        actions to apply if the packet length is lesser or equal to the
        specified 'pkt_len'.

    The main use case for adding this action is to solve the packet
    drops because of MTU mismatch in OVN virtual networking solution.
    When a VM (which belongs to a logical switch of OVN) sends a packet
    destined to go via the gateway router and if the nic which provides
    external connectivity, has a lesser MTU, OVS drops the packet
    if the packet length is greater than this MTU.

    With the help of this action, OVN will check the packet length
    and if it is greater than the MTU size, it will generate an
    ICMP packet (type 3, code 4) and includes the next hop mtu in it
    so that the sender can fragment the packets.

    Reported-at:
    https://mail.openvswitch.org/pipermail/ovs-discuss/2018-July/047039.html
    Suggested-by: Ben Pfaff 
    Signed-off-by: Numan Siddique 
    CC: Gregory Rose 
    CC: Pravin B Shelar 
    Acked-by: Pravin B Shelar 
    Tested-by: Greg Rose 
    Reviewed-by: Greg Rose 
    Signed-off-by: David S. Miller 

Use of 'nla_parse_strict()' (in validate_and_copy_check_len()) is available
only in recent kernels. So changed it to 'nla_parse_nested()'.

Signed-off-by: Numan Siddique 
Tested-by: Greg Rose 
Reviewed-by: Greg Rose 
Signed-off-by: Ben Pfaff

openvswitch: kernel datapath clone action

2018-12-18T00:12:14+00:00

Upstream commit:
    commit b233504033dbd65740e59681820ccfd0a2a8ec53
    Author: Yifeng Sun 
    Date:   Mon Jul 2 08:18:03 2018 -0700

    openvswitch: kernel datapath clone action

    Add 'clone' action to kernel datapath by using existing functions.
    When actions within clone don't modify the current flow, the flow
    key is not cloned before executing clone actions.

    This is a follow up patch for this incomplete work:
    https://patchwork.ozlabs.org/patch/722096/

    v1 -> v2:
    Refactor as advised by reviewer.

    Signed-off-by: Yifeng Sun 
    Signed-off-by: Andy Zhou 
    Acked-by: Pravin B Shelar 
    Signed-off-by: David S. Miller 

Tested-by: Greg Rose 
Reviewed-by: Greg Rose 
Co-authored-by: Andy Zhou 
Signed-off-by: Yifeng Sun 
Signed-off-by: Andy Zhou 
Signed-off-by: Ben Pfaff

datapath: Add meter action support.

2018-06-20T17:16:51+00:00

Upstream commit:
    commit cd8a6c33693c1b89d2737ffdbf9611564e9ac907
    Author: Andy Zhou 
    Date:   Fri Nov 10 12:09:43 2017 -0800

    openvswitch: Add meter action support

    Implements OVS kernel meter action support.

    Signed-off-by: Andy Zhou 
    Signed-off-by: David S. Miller 

Signed-off-by: Justin Pettit 
Reviewed-by: Greg Rose 
Tested-by: Greg Rose

datapath: enable NSH support

2018-02-07T18:45:58+00:00

Upstream commit:
  commit b2d0f5d5dc53532e6f07bc546a476a55ebdfe0f3
  Author: Yi Yang 
  Date:   Tue Nov 7 21:07:02 2017 +0800

    openvswitch: enable NSH support

    OVS master and 2.8 branch has merged NSH userspace
    patch series, this patch is to enable NSH support
    in kernel data path in order that OVS can support
    NSH in compat mode by porting this.

    Signed-off-by: Yi Yang 
    Acked-by: Jiri Benc 
    Acked-by: Eric Garver 
    Acked-by: Pravin Shelar 
    Signed-off-by: David S. Miller 

Signed-off-by: Yi Yang 
Signed-off-by: Ben Pfaff 
Reviewed-by: Greg Rose

datapath: add ct_clear action

2018-01-23T03:24:22+00:00

Upstream commit:
    commit b8226962b1c49c784aeddb9d2fafbf53dfdc2190
    Author: Eric Garver 
    Date:   Tue Oct 10 16:54:44 2017 -0400

    openvswitch: add ct_clear action

    This adds a ct_clear action for clearing conntrack state. ct_clear is
    currently implemented in OVS userspace, but is not backed by an action
    in the kernel datapath. This is useful for flows that may modify a
    packet tuple after a ct lookup has already occurred.

    Signed-off-by: Eric Garver 
    Acked-by: Pravin B Shelar 
    Signed-off-by: David S. Miller 

Notes:
   - hunk from include/uapi/linux/openvswitch.h is missing because it
     was added with userspace support in 1fe178d251c8 ("dpif: Add support
     for OVS_ACTION_ATTR_CT_CLEAR")
   - if IP_CT_UNTRACKED is not available use 0 as other nf_ct_set()
     calls do. Since we're setting ct to NULL this is okay.

Signed-off-by: Eric Garver 
Acked-by: Pravin B Shelar

datapath: fix skb_panic due to the incorrect actions attrlen

2017-09-22T19:32:54+00:00

Upstream commit:
    commit 494bea39f3201776cdfddc232705f54a0bd210c4
    Author: Liping Zhang 
    Date:   Wed Aug 16 13:30:07 2017 +0800

    openvswitch: fix skb_panic due to the incorrect actions attrlen

    For sw_flow_actions, the actions_len only represents the kernel part's
    size, and when we dump the actions to the userspace, we will do the
    convertions, so it's true size may become bigger than the actions_len.

    But unfortunately, for OVS_PACKET_ATTR_ACTIONS, we use the actions_len
    to alloc the skbuff, so the user_skb's size may become insufficient and
    oops will happen like this:
      skbuff: skb_over_panic: text:ffffffff8148fabf len:1749 put:157 head:
      ffff881300f39000 data:ffff881300f39000 tail:0x6d5 end:0x6c0 dev:
      ------------[ cut here ]------------
      kernel BUG at net/core/skbuff.c:129!
      [...]
      Call Trace:
       
       [] skb_put+0x43/0x44
       [] skb_zerocopy+0x6c/0x1f4
       [] queue_userspace_packet+0x3a3/0x448 [openvswitch]
       [] ovs_dp_upcall+0x30/0x5c [openvswitch]
       [] output_userspace+0x132/0x158 [openvswitch]
       [] ? ip6_rcv_finish+0x74/0x77 [ipv6]
       [] do_execute_actions+0xcc1/0xdc8 [openvswitch]
       [] ovs_execute_actions+0x74/0x106 [openvswitch]
       [] ovs_dp_process_packet+0xe1/0xfd [openvswitch]
       [] ? key_extract+0x63c/0x8d5 [openvswitch]
       [] ovs_vport_receive+0xa1/0xc3 [openvswitch]
      [...]

    Also we can find that the actions_len is much little than the orig_len:
      crash> struct sw_flow_actions 0xffff8812f539d000
      struct sw_flow_actions {
        rcu = {
          next = 0xffff8812f5398800,
          func = 0xffffe3b00035db32
        },
        orig_len = 1384,
        actions_len = 592,
        actions = 0xffff8812f539d01c
      }

    So as a quick fix, use the orig_len instead of the actions_len to alloc
    the user_skb.

    Last, this oops happened on our system running a relative old kernel, but
    the same risk still exists on the mainline, since we use the wrong
    actions_len from the beginning.

    Fixes: ccea74457bbd ("openvswitch: include datapath actions with sampled-pac
    Cc: Neil McKee 
    Signed-off-by: Liping Zhang 
    Acked-by: Pravin B Shelar 
    Signed-off-by: David S. Miller 

Fixes: 0e469d3b380c ("datapath: Include datapath actions with sampled-packet upcall to userspace.")
Signed-off-by: Greg Rose 
Signed-off-by: Andy Zhou