delta/openvswitch.git/datapath/vport-internal_dev.c, branch master

make: Remove the Linux datapath.

2022-07-15T11:45:55+00:00

Update the necessary make and configure files to remove the Linux
datapath and then remove the datapath.

Move datapath/linux/compat/include/linux/openvswitch.h to
include/linux/openvswitch.h because it is needed to generate header
files used by the userspace switch.

Also remove references to the Linux datapath from auxiliary files
and utilities since it is no longer supported.

Signed-off-by: Greg Rose 
Reviewed-by: David Marchand 
Signed-off-by: Ilya Maximets

datapath: compat: drop bridge nf reset from nf_reset

2019-10-18T14:22:12+00:00

Upstream commmit:
    commit 895b5c9f206eb7d25dc1360a8ccfc5958895eb89
    Author: Florian Westphal 
    Date:   Sun Sep 29 20:54:03 2019 +0200

    netfilter: drop bridge nf reset from nf_reset

    commit 174e23810cd31
    ("sk_buff: drop all skb extensions on free and skb scrubbing") made napi
    recycle always drop skb extensions.  The additional skb_ext_del() that is
    performed via nf_reset on napi skb recycle is not needed anymore.

    Most nf_reset() calls in the stack are there so queued skb won't block
    'rmmod nf_conntrack' indefinitely.

    This removes the skb_ext_del from nf_reset, and renames it to a more
    fitting nf_reset_ct().

    In a few selected places, add a call to skb_ext_reset to make sure that
    no active extensions remain.

    I am submitting this for "net", because we're still early in the release
    cycle.  The patch applies to net-next too, but I think the rename causes
    needless divergence between those trees.

    Suggested-by: Eric Dumazet 
    Signed-off-by: Florian Westphal 
    Signed-off-by: Pablo Neira Ayuso 

Added some compat layer fixups for nf_reset_ct.  This is just a portion
of the upstream commit that applies to openvswitch.

Cc: Florian Westphal 
Signed-off-by: Greg Rose 
Acked-by: Yi-Hung Wei 
Signed-off-by: Simon Horman

datapath: fix return type of ndo_start_xmit function

2018-12-15T16:13:23+00:00

Upstream commit:
    commit eddf11e18dff0e8671e06ce54e64cfc843303ab9
    Author: YueHaibing 
    Date:   Wed Sep 26 17:15:38 2018 +0800

    net: ovs: fix return type of ndo_start_xmit function

    The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
    which is a typedef for an enum type, so make sure the implementation in
    this driver has returns 'netdev_tx_t' value, and change the function
    return type to netdev_tx_t.

    Found by coccinelle.

    Signed-off-by: YueHaibing 
    Signed-off-by: David S. Miller 

CC: YueHaibing 
Acked-by: William Tu 
Signed-off-by: Greg Rose 
Signed-off-by: Ben Pfaff

datapath: Fix compiler warning for HAVE_RHEL7_MAX_MTU.

2018-06-20T17:00:57+00:00

Fixes: 1e40b541bc ("datapath: Fix max MTU size on RHEL 7.5 kernel")
Signed-off-by: Justin Pettit 
Reviewed-by: Greg Rose

datapath: Fix max MTU size on RHEL 7.5 kernel

2018-06-14T19:56:04+00:00

Without the patch, in RHEL 7.5, the maximum configurable MTU of vport
internal device is 1500, which shall be 65535.  This patch fixes this
issue.

Fixes: 39ca338374ab ("datapath: compat: Fix build on RHEL 7.5")
Reported-by: Lucas Alvares Gomes 
Signed-off-by: Yi-Hung Wei 
Signed-off-by: Ben Pfaff 
Reviewed-by: Greg Rose 
Tested-by: Greg Rose

datapath: compat: Fix build on RHEL 7.5

2018-05-15T01:36:18+00:00

1) OVS datapath compat modules breaks on RHEL 7.5, because it moves
ndo_change_mtu function pointer from 'struct net_device_ops' to
'struct net_device_ops_extended'.

2) RHEL 7.5 introduces the MTU range checking as mentioned in
6c0bf091 ("datapath: use core MTU range checking in core net infra").
However, the max_mtu field is defined in 'struct net_device_extended'
but not in 'struct net_device' as upstream kernel.

This patch defines a new symbol HAVE_RHEL7_MAX_MTU that determines
the previous 2 conditions, and fixes the backport issue.

Signed-off-by: Yi-Hung Wei 
Acked-by: Lucas Alvares Gomes 
Signed-off-by: Pravin B Shelar

datapath: remove unused hardirq.h

2018-02-16T08:41:22+00:00

Upstream commit:
    commit 419091f1cc8afce943fd12af0df26201ee20c1c0
    Author: Yang Shi 
    Date:   Tue Jan 9 03:52:53 2018 +0800

    net: ovs: remove unused hardirq.h

    Preempt counter APIs have been split out, currently, hardirq.h just
    includes irq_enter/exit APIs which are not used by openvswitch at all.

    So, remove the unused hardirq.h.

    Signed-off-by: Yang Shi 
    Acked-by: Pravin B Shelar 
    Cc: "David S. Miller" 
    Cc: dev@openvswitch.org
    Signed-off-by: David S. Miller 

Cc: Yang Shi 
Signed-off-by: Greg Rose 

Acked-by: Pravin B Shelar 
Acked-by： Yang Shi

datapath: do not propagate headroom updates to internal port

2018-02-16T08:41:22+00:00

Upstream commit:
    commit 183dea5818315c0a172d21ecbcd2554894bf01e3
    Author: Paolo Abeni 
    Date:   Thu Nov 30 15:35:33 2017 +0100

    openvswitch: do not propagate headroom updates to internal port

    After commit 3a927bc7cf9d ("ovs: propagate per dp max headroom to
    all vports") the need_headroom for the internal vport is updated
    accordingly to the max needed headroom in its datapath.

    That avoids the pskb_expand_head() costs when sending/forwarding
    packets towards tunnel devices, at least for some scenarios.

    We still require such copy when using the ovs-preferred configuration
    for vxlan tunnels:

        br_int
      /       \
    tap      vxlan
               (remote_ip:X)

    br_phy
         \
        NIC

    where the route towards the IP 'X' is via 'br_phy'.

    When forwarding traffic from the tap towards the vxlan device, we
    will call pskb_expand_head() in vxlan_build_skb() because
    br-phy->needed_headroom is equal to tun->needed_headroom.

    With this change we avoid updating the internal vport needed_headroom,
    so that in the above scenario no head copy is needed, giving 5%
    performance improvement in UDP throughput test.

    As a trade-off, packets sent from the internal port towards a tunnel
    device will now experience the head copy overhead. The rationale is
    that the latter use-case is less relevant performance-wise.

    Signed-off-by: paolo abeni 
    Acked-by: Pravin B Shelar 
    Signed-off-by: David S. Miller 

Cc: paolo abeni 
Signed-off-by: Greg Rose 
Acked-by: Pravin B Shelar

datapath: Fix inconsistent teardown and release of private netdev state.

2017-07-24T18:24:32+00:00

Upstream commit:
    commit cf124db566e6b036b8bcbe8decbed740bdfac8c6
    Author: David S. Miller 
    Date:   Mon May 8 12:52:56 2017 -0400

    net: Fix inconsistent teardown and release of private netdev state.

    Network devices can allocate reasources and private memory using
    netdev_ops->ndo_init().  However, the release of these resources
    can occur in one of two different places.

    Either netdev_ops->ndo_uninit() or netdev->destructor().

    The decision of which operation frees the resources depends upon
    whether it is necessary for all netdev refs to be released before it
    is safe to perform the freeing.

    netdev_ops->ndo_uninit() presumably can occur right after the
    NETDEV_UNREGISTER notifier completes and the unicast and multicast
    address lists are flushed.

    netdev->destructor(), on the other hand, does not run until the
    netdev references all go away.

    Further complicating the situation is that netdev->destructor()
    almost universally does also a free_netdev().

    This creates a problem for the logic in register_netdevice().
    Because all callers of register_netdevice() manage the freeing
    of the netdev, and invoke free_netdev(dev) if register_netdevice()
    fails.

    If netdev_ops->ndo_init() succeeds, but something else fails inside
    of register_netdevice(), it does call ndo_ops->ndo_uninit().  But
    it is not able to invoke netdev->destructor().

    This is because netdev->destructor() will do a free_netdev() and
    then the caller of register_netdevice() will do the same.

    However, this means that the resources that would normally be released
    by netdev->destructor() will not be.

    Over the years drivers have added local hacks to deal with this, by
    invoking their destructor parts by hand when register_netdevice()
    fails.

    Many drivers do not try to deal with this, and instead we have leaks.

    Let's close this hole by formalizing the distinction between what
    private things need to be freed up by netdev->destructor() and whether
    the driver needs unregister_netdevice() to perform the free_netdev().

    netdev->priv_destructor() performs all actions to free up the private
    resources that used to be freed by netdev->destructor(), except for
    free_netdev().

    netdev->needs_free_netdev is a boolean that indicates whether
    free_netdev() should be done at the end of unregister_netdevice().

    Now, register_netdevice() can sanely release all resources after
    ndo_ops->ndo_init() succeeds, by invoking both ndo_ops->ndo_uninit()
    and netdev->priv_destructor().

    And at the end of unregister_netdevice(), we invoke
    netdev->priv_destructor() and optionally call free_netdev().

    Signed-off-by: David S. Miller 

Applied the portion of the commit applicable to openvswitch.

Signed-off-by: Greg Rose 
Signed-off-by: Joe Stringer

datapath: make ndo_get_stats64 a void function

2017-03-03T22:40:17+00:00

Upstream commit:
    commit bc1f44709cf27fb2a5766cadafe7e2ad5e9cb221
    Author: stephen hemminger 
    Date:   Fri Jan 6 19:12:52 2017 -0800

    net: make ndo_get_stats64 a void function

    The network device operation for reading statistics is only called
    in one place, and it ignores the return value. Having a structure
    return value is potentially confusing because some future driver could
    incorrectly assume that the return value was used.

    Fix all drivers with ndo_get_stats64 to have a void function.

    Signed-off-by: Stephen Hemminger 
    Signed-off-by: David S. Miller 

This seems to be fine for all prior Linux versions as well.

Signed-off-by: Jarno Rajahalme 
Signed-off-by: Joe Stringer