<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/openvswitch.git/tests/testsuite.at, branch master</title>
<subtitle>github.com: openvswitch/ovs.git
</subtitle>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/openvswitch.git/'/>
<entry>
<title>learning-switch: Fix coredump of OpenFlow15 learning-switch.</title>
<updated>2023-04-25T16:20:32+00:00</updated>
<author>
<name>Faicker Mo</name>
<email>faicker.mo@ucloud.cn</email>
</author>
<published>2023-04-07T06:30:22+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/openvswitch.git/commit/?id=70ba6e97dbd75d5c255a339568e6ff56ed8f67fc'/>
<id>70ba6e97dbd75d5c255a339568e6ff56ed8f67fc</id>
<content type='text'>
The OpenFlow15 Packet-Out message contains the match instead of the
in_port.  The flow.tunnel.metadata.tab is not inited but used in the
loop of tun_metadata_to_nx_match.

The coredump gdb backtrace is:
 0  memcpy_from_metadata (dst=0x2f060, src=0x30880, loc=0x10) at lib/tun-metadata.c:467
 1  metadata_loc_from_match_read (match=0x30598, is_masked=&lt;..&gt;,
                                  mask=0x30838, idx=0, map=0x0)
        at lib/tun-metadata.c:865
 2  metadata_loc_from_match_read (is_masked=&lt;...&gt;, mask=0x30838, idx=0,
                                  match=0x30598, map=0x0)
        at lib/tun-metadata.c:854
 3  tun_metadata_to_nx_match (b=0x892260, oxm=OFP15_VERSION, match=0x30598)
        at lib/tun-metadata.c:888
 4  nx_put_raw (b=0x892260, oxm=OFP15_VERSION, match=0x30598,
                cookie=&lt;...&gt;, cookie=0, cookie_mask=&lt;...&gt;, cookie_mask=0)
        at lib/nx-match.c:1186
 5  oxm_put_match (b=0x892260, match=0x30598, version=OFP15_VERSION)
        at lib/nx-match.c:1343
 6  ofputil_encode_packet_out (po=0x30580, protocol=&lt;...&gt;) at lib/ofp-packet.c:1226
 7  process_packet_in (sw=0x891d70, oh=&lt;...&gt;) at lib/learning-switch.c:619
 8  lswitch_process_packet (msg=0x892210, sw=0x891d70) at lib/learning-switch.c:374
 9  lswitch_run (sw=0x891d70) at lib/learning-switch.c:324
 10 main (argc=&lt;...&gt;, argv=&lt;...&gt;) at utilities/ovs-testcontroller.c:180

Fix that by initing the flow metadata.

Fixes: 35eb6326d5d0 ("ofp-util: Add flow metadata to ofputil_packet_out")
Signed-off-by: Faicker Mo &lt;faicker.mo@ucloud.cn&gt;
Reviewed-by: Simon Horman &lt;simon.horman@corigine.com&gt;
Signed-off-by: Ilya Maximets &lt;i.maximets@ovn.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The OpenFlow15 Packet-Out message contains the match instead of the
in_port.  The flow.tunnel.metadata.tab is not inited but used in the
loop of tun_metadata_to_nx_match.

The coredump gdb backtrace is:
 0  memcpy_from_metadata (dst=0x2f060, src=0x30880, loc=0x10) at lib/tun-metadata.c:467
 1  metadata_loc_from_match_read (match=0x30598, is_masked=&lt;..&gt;,
                                  mask=0x30838, idx=0, map=0x0)
        at lib/tun-metadata.c:865
 2  metadata_loc_from_match_read (is_masked=&lt;...&gt;, mask=0x30838, idx=0,
                                  match=0x30598, map=0x0)
        at lib/tun-metadata.c:854
 3  tun_metadata_to_nx_match (b=0x892260, oxm=OFP15_VERSION, match=0x30598)
        at lib/tun-metadata.c:888
 4  nx_put_raw (b=0x892260, oxm=OFP15_VERSION, match=0x30598,
                cookie=&lt;...&gt;, cookie=0, cookie_mask=&lt;...&gt;, cookie_mask=0)
        at lib/nx-match.c:1186
 5  oxm_put_match (b=0x892260, match=0x30598, version=OFP15_VERSION)
        at lib/nx-match.c:1343
 6  ofputil_encode_packet_out (po=0x30580, protocol=&lt;...&gt;) at lib/ofp-packet.c:1226
 7  process_packet_in (sw=0x891d70, oh=&lt;...&gt;) at lib/learning-switch.c:619
 8  lswitch_process_packet (msg=0x892210, sw=0x891d70) at lib/learning-switch.c:374
 9  lswitch_run (sw=0x891d70) at lib/learning-switch.c:324
 10 main (argc=&lt;...&gt;, argv=&lt;...&gt;) at utilities/ovs-testcontroller.c:180

Fix that by initing the flow metadata.

Fixes: 35eb6326d5d0 ("ofp-util: Add flow metadata to ofputil_packet_out")
Signed-off-by: Faicker Mo &lt;faicker.mo@ucloud.cn&gt;
Reviewed-by: Simon Horman &lt;simon.horman@corigine.com&gt;
Signed-off-by: Ilya Maximets &lt;i.maximets@ovn.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>xenserver: Remove xenserver.</title>
<updated>2022-08-15T11:07:13+00:00</updated>
<author>
<name>Greg Rose</name>
<email>gvrose8192@gmail.com</email>
</author>
<published>2022-08-08T20:36:02+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/openvswitch.git/commit/?id=83c9518e7c67fb73ab17f6db50f398dc78403814'/>
<id>83c9518e7c67fb73ab17f6db50f398dc78403814</id>
<content type='text'>
Remove the current xenserver implementation - it is obsolete and
since 3.0 we do not support kernel module builds [1].

1. https://mail.openvswitch.org/pipermail/ovs-dev/2022-July/395789.html

[i.maximets]
Can be added back if people willing to maintain it will be found.

Signed-off-by: Greg Rose &lt;gvrose8192@gmail.com&gt;
Signed-off-by: Ilya Maximets &lt;i.maximets@ovn.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Remove the current xenserver implementation - it is obsolete and
since 3.0 we do not support kernel module builds [1].

1. https://mail.openvswitch.org/pipermail/ovs-dev/2022-July/395789.html

[i.maximets]
Can be added back if people willing to maintain it will be found.

Signed-off-by: Greg Rose &lt;gvrose8192@gmail.com&gt;
Signed-off-by: Ilya Maximets &lt;i.maximets@ovn.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>python: Introduce unit tests.</title>
<updated>2022-07-15T18:14:24+00:00</updated>
<author>
<name>Adrian Moreno</name>
<email>amorenoz@redhat.com</email>
</author>
<published>2022-07-08T18:03:12+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/openvswitch.git/commit/?id=445dceb88461161bc230417fdf78c71e4d6683c1'/>
<id>445dceb88461161bc230417fdf78c71e4d6683c1</id>
<content type='text'>
Use pytest to run unit tests as part of the standard testsuite.

Acked-by: Eelco Chaudron &lt;echaudro@redhat.com&gt;
Signed-off-by: Adrian Moreno &lt;amorenoz@redhat.com&gt;
Signed-off-by: Ilya Maximets &lt;i.maximets@ovn.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Use pytest to run unit tests as part of the standard testsuite.

Acked-by: Eelco Chaudron &lt;echaudro@redhat.com&gt;
Signed-off-by: Adrian Moreno &lt;amorenoz@redhat.com&gt;
Signed-off-by: Ilya Maximets &lt;i.maximets@ovn.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>tests: Add PMD auto load balance unit tests.</title>
<updated>2021-06-24T20:11:10+00:00</updated>
<author>
<name>Kevin Traynor</name>
<email>ktraynor@redhat.com</email>
</author>
<published>2021-06-24T13:20:41+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/openvswitch.git/commit/?id=f0e4a7338c622bf4824aa2cf978bd24478951ddf'/>
<id>f0e4a7338c622bf4824aa2cf978bd24478951ddf</id>
<content type='text'>
These tests focus on enabling/disabling and user parameters.

Co-Authored-by: David Marchand &lt;david.marchand@redhat.com&gt;
Signed-off-by: David Marchand &lt;david.marchand@redhat.com&gt;
Signed-off-by: Kevin Traynor &lt;ktraynor@redhat.com&gt;
Acked-by: Sunil Pai G &lt;sunil.pai.g@intel.com&gt;
Signed-off-by: Ilya Maximets &lt;i.maximets@ovn.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
These tests focus on enabling/disabling and user parameters.

Co-Authored-by: David Marchand &lt;david.marchand@redhat.com&gt;
Signed-off-by: David Marchand &lt;david.marchand@redhat.com&gt;
Signed-off-by: Kevin Traynor &lt;ktraynor@redhat.com&gt;
Acked-by: Sunil Pai G &lt;sunil.pai.g@intel.com&gt;
Signed-off-by: Ilya Maximets &lt;i.maximets@ovn.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>userspace: Improved packet drop statistics.</title>
<updated>2020-01-07T16:01:42+00:00</updated>
<author>
<name>Anju Thomas</name>
<email>anju.thomas@ericsson.com</email>
</author>
<published>2019-12-18T04:48:12+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/openvswitch.git/commit/?id=a13a0209750c424556189796061c40d08c689467'/>
<id>a13a0209750c424556189796061c40d08c689467</id>
<content type='text'>
Currently OVS maintains explicit packet drop/error counters only on port
level.  Packets that are dropped as part of normal OpenFlow processing
are counted in flow stats of “drop” flows or as table misses in table
stats. These can only be interpreted by controllers that know the
semantics of the configured OpenFlow pipeline.  Without that knowledge,
it is impossible for an OVS user to obtain e.g. the total number of
packets dropped due to OpenFlow rules.

Furthermore, there are numerous other reasons for which packets can be
dropped by OVS slow path that are not related to the OpenFlow pipeline.
The generated datapath flow entries include a drop action to avoid
further expensive upcalls to the slow path, but subsequent packets
dropped by the datapath are not accounted anywhere.

Finally, the datapath itself drops packets in certain error situations.
Also, these drops are today not accounted for.This makes it difficult
for OVS users to monitor packet drop in an OVS instance and to alert a
management system in case of a unexpected increase of such drops.
Also OVS trouble-shooters face difficulties in analysing packet drops.

With this patch we implement following changes to address the issues
mentioned above.

1. Identify and account all the silent packet drop scenarios
2. Display these drops in ovs-appctl coverage/show

Co-authored-by: Rohith Basavaraja &lt;rohith.basavaraja@gmail.com&gt;
Co-authored-by: Keshav Gupta &lt;keshugupta1@gmail.com&gt;
Signed-off-by: Anju Thomas &lt;anju.thomas@ericsson.com&gt;
Signed-off-by: Rohith Basavaraja &lt;rohith.basavaraja@gmail.com&gt;
Signed-off-by: Keshav Gupta &lt;keshugupta1@gmail.com&gt;
Acked-by: Eelco Chaudron &lt;echaudro@redhat.com
Acked-by: Ben Pfaff &lt;blp@ovn.org&gt;
Signed-off-by: Ilya Maximets &lt;i.maximets@ovn.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Currently OVS maintains explicit packet drop/error counters only on port
level.  Packets that are dropped as part of normal OpenFlow processing
are counted in flow stats of “drop” flows or as table misses in table
stats. These can only be interpreted by controllers that know the
semantics of the configured OpenFlow pipeline.  Without that knowledge,
it is impossible for an OVS user to obtain e.g. the total number of
packets dropped due to OpenFlow rules.

Furthermore, there are numerous other reasons for which packets can be
dropped by OVS slow path that are not related to the OpenFlow pipeline.
The generated datapath flow entries include a drop action to avoid
further expensive upcalls to the slow path, but subsequent packets
dropped by the datapath are not accounted anywhere.

Finally, the datapath itself drops packets in certain error situations.
Also, these drops are today not accounted for.This makes it difficult
for OVS users to monitor packet drop in an OVS instance and to alert a
management system in case of a unexpected increase of such drops.
Also OVS trouble-shooters face difficulties in analysing packet drops.

With this patch we implement following changes to address the issues
mentioned above.

1. Identify and account all the silent packet drop scenarios
2. Display these drops in ovs-appctl coverage/show

Co-authored-by: Rohith Basavaraja &lt;rohith.basavaraja@gmail.com&gt;
Co-authored-by: Keshav Gupta &lt;keshugupta1@gmail.com&gt;
Signed-off-by: Anju Thomas &lt;anju.thomas@ericsson.com&gt;
Signed-off-by: Rohith Basavaraja &lt;rohith.basavaraja@gmail.com&gt;
Signed-off-by: Keshav Gupta &lt;keshugupta1@gmail.com&gt;
Acked-by: Eelco Chaudron &lt;echaudro@redhat.com
Acked-by: Ben Pfaff &lt;blp@ovn.org&gt;
Signed-off-by: Ilya Maximets &lt;i.maximets@ovn.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove OVN.</title>
<updated>2019-09-06T21:54:58+00:00</updated>
<author>
<name>Mark Michelson</name>
<email>mmichels@redhat.com</email>
</author>
<published>2019-09-06T14:33:03+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/openvswitch.git/commit/?id=f3e24610ea18eb873dc860f1710432e9aacd27fd'/>
<id>f3e24610ea18eb873dc860f1710432e9aacd27fd</id>
<content type='text'>
OVN is separated into its own repo. This commit removes the OVN source,
OVN tests, and OVN documentation. It also removes mentions of OVN from
most documentation. The only place where OVN has been left is in
changelogs/NEWS, since we shouldn't mess with the history of the
project.

There is an exception here. The ovsdb-cluster tests rely on ovn-nbctl
and ovn-sbctl to run. Therefore those ovn utilities, as well as their
dependencies remain in the repo with this commit.

Acked-by: Numan Siddique &lt;nusiddiq@redhat.com&gt;
Signed-off-by: Mark Michelson &lt;mmichels@redhat.com&gt;
Signed-off-by: Ben Pfaff &lt;blp@ovn.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
OVN is separated into its own repo. This commit removes the OVN source,
OVN tests, and OVN documentation. It also removes mentions of OVN from
most documentation. The only place where OVN has been left is in
changelogs/NEWS, since we shouldn't mess with the history of the
project.

There is an exception here. The ovsdb-cluster tests rely on ovn-nbctl
and ovn-sbctl to run. Therefore those ovn utilities, as well as their
dependencies remain in the repo with this commit.

Acked-by: Numan Siddique &lt;nusiddiq@redhat.com&gt;
Signed-off-by: Mark Michelson &lt;mmichels@redhat.com&gt;
Signed-off-by: Ben Pfaff &lt;blp@ovn.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>ovn: Test for full logical flow processing in ovn-controller.</title>
<updated>2019-05-24T18:37:29+00:00</updated>
<author>
<name>Jakub Sitnicki</name>
<email>jkbs@redhat.com</email>
</author>
<published>2019-05-17T19:56:40+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/openvswitch.git/commit/?id=a13373e40ff28e2ff337f3f34dabfb7802ed82a7'/>
<id>a13373e40ff28e2ff337f3f34dabfb7802ed82a7</id>
<content type='text'>
From: Jakub Sitnicki &lt;jkbs@redhat.com&gt;

Add a test that performs typical operations of creating &amp; destroying
logical routers, switches, ports, address sets and ACLs while checking
if they trigger full logical flow processing in the ovn-controller.
This way confirm that incremental processing is taking effect when we
expect it to.

Place the new test in a separate module - tests/ovn-performance.at,
instead of the usual tests/ovn.at as it doesn't test OVN's functionality
but rather a performance aspect of ovn-controller.

Signed-off-by: Jakub Sitnicki &lt;jkbs@redhat.com&gt;
Acked-by: Han Zhou &lt;hzhou8@ebay.com&gt;
Signed-off-by: Han Zhou &lt;hzhou8@ebay.com&gt;
Signed-off-by: Ben Pfaff &lt;blp@ovn.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
From: Jakub Sitnicki &lt;jkbs@redhat.com&gt;

Add a test that performs typical operations of creating &amp; destroying
logical routers, switches, ports, address sets and ACLs while checking
if they trigger full logical flow processing in the ovn-controller.
This way confirm that incremental processing is taking effect when we
expect it to.

Place the new test in a separate module - tests/ovn-performance.at,
instead of the usual tests/ovn.at as it doesn't test OVN's functionality
but rather a performance aspect of ovn-controller.

Signed-off-by: Jakub Sitnicki &lt;jkbs@redhat.com&gt;
Acked-by: Han Zhou &lt;hzhou8@ebay.com&gt;
Signed-off-by: Han Zhou &lt;hzhou8@ebay.com&gt;
Signed-off-by: Ben Pfaff &lt;blp@ovn.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>ovn-macros: Break the OVN macros into their own file.</title>
<updated>2019-05-23T20:42:04+00:00</updated>
<author>
<name>Justin Pettit</name>
<email>jpettit@ovn.org</email>
</author>
<published>2019-04-06T16:02:05+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/openvswitch.git/commit/?id=70df182f03eb64983bd07056aacac6a06190a7ad'/>
<id>70df182f03eb64983bd07056aacac6a06190a7ad</id>
<content type='text'>
Signed-off-by: Justin Pettit &lt;jpettit@ovn.org&gt;
Acked-by: Ben Pfaff &lt;blp@ovn.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Justin Pettit &lt;jpettit@ovn.org&gt;
Acked-by: Ben Pfaff &lt;blp@ovn.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>tests: Add regression tests for all the bugs found by oss-fuzz so far.</title>
<updated>2018-09-10T19:33:57+00:00</updated>
<author>
<name>Ben Pfaff</name>
<email>blp@ovn.org</email>
</author>
<published>2018-08-30T20:58:50+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/openvswitch.git/commit/?id=2bdeb9a70e3c882ab97e9d2e16e7a7989b07f024'/>
<id>2bdeb9a70e3c882ab97e9d2e16e7a7989b07f024</id>
<content type='text'>
This will make it harder for bugs found by oss-fuzz to reappear.

Signed-off-by: Ben Pfaff &lt;blp@ovn.org&gt;
Tested-by: Yifeng Sun &lt;pkusunyifeng@gmail.com&gt;
Reviewed-by: Yifeng Sun &lt;pkusunyifeng@gmail.com&gt;
Signed-off-by: Ben Pfaff &lt;blp@ovn.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This will make it harder for bugs found by oss-fuzz to reappear.

Signed-off-by: Ben Pfaff &lt;blp@ovn.org&gt;
Tested-by: Yifeng Sun &lt;pkusunyifeng@gmail.com&gt;
Reviewed-by: Yifeng Sun &lt;pkusunyifeng@gmail.com&gt;
Signed-off-by: Ben Pfaff &lt;blp@ovn.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>checkpatch: Improve accuracy and specificity of sign-off checking.</title>
<updated>2018-08-13T21:52:42+00:00</updated>
<author>
<name>Ben Pfaff</name>
<email>blp@ovn.org</email>
</author>
<published>2018-08-10T20:15:41+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/openvswitch.git/commit/?id=3267343a84872dca7731a76d91357044f51fae35'/>
<id>3267343a84872dca7731a76d91357044f51fae35</id>
<content type='text'>
This also makes a start at a testsuite for checkpatch.

CC: Aaron Conole &lt;aconole@redhat.com&gt;
Signed-off-by: Ben Pfaff &lt;blp@ovn.org&gt;
Acked-by: Aaron Conole &lt;aconole@bytheb.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This also makes a start at a testsuite for checkpatch.

CC: Aaron Conole &lt;aconole@redhat.com&gt;
Signed-off-by: Ben Pfaff &lt;blp@ovn.org&gt;
Acked-by: Aaron Conole &lt;aconole@bytheb.org&gt;
</pre>
</div>
</content>
</entry>
</feed>
