summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorIlya Maximets <i.maximets@ovn.org>2020-10-23 20:20:04 +0200
committerIlya Maximets <i.maximets@ovn.org>2020-10-26 02:52:54 +0100
commit604cbb45b970ec10dee83d97482f3d57b5c240f5 (patch)
treec8db70ce89f8a005ea4a7466fc20bd22fc2276e1
parent6eae20e88fdd8dc786ead8fc03d8fd3cc0511724 (diff)
downloadopenvswitch-604cbb45b970ec10dee83d97482f3d57b5c240f5.tar.gz
raft: Fix error leak on failure while saving snapshot.
Error should be destroyed before return. Fixes: 1b1d2e6daa56 ("ovsdb: Introduce experimental support for clustered databases.") Acked-by: Han Zhou <hzhou@ovn.org> Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
-rw-r--r--ovsdb/raft.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/ovsdb/raft.c b/ovsdb/raft.c
index 00bf3687f..7ba75f6a3 100644
--- a/ovsdb/raft.c
+++ b/ovsdb/raft.c
@@ -3738,7 +3738,7 @@ raft_handle_install_snapshot_request__(
struct ovsdb_error *error = raft_save_snapshot(raft, new_log_start,
&new_snapshot);
if (error) {
- char *error_s = ovsdb_error_to_string(error);
+ char *error_s = ovsdb_error_to_string_free(error);
VLOG_WARN("could not save snapshot: %s", error_s);
free(error_s);
return false;