summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorEelco Chaudron <echaudro@redhat.com>2023-02-07 15:04:42 +0100
committerIlya Maximets <i.maximets@ovn.org>2023-02-09 00:26:30 +0100
commit235ab5ec00e71d7392b91cf2cfddd60c6c983330 (patch)
tree39c2d98631118a360c743ace966b8dbf81a37cad
parentc10b7000757f7652e7814002877f2b35bf710d20 (diff)
downloadopenvswitch-235ab5ec00e71d7392b91cf2cfddd60c6c983330.tar.gz
netdev-offload-tc: Fix tc conntrack force commit support.
tc was not setting the OVS_CT_ATTR_FORCE_COMMIT flag when a forced commit was requested. This patch will fix this. Fixes: 576126a931cd ("netdev-offload-tc: Add conntrack support") Signed-off-by: Eelco Chaudron <echaudro@redhat.com> Acked-by: Roi Dayan <roid@nvidia.com> Reviewed-by: Simon Horman <simon.horman@corigine.com> Tested-by: Simon Horman <simon.horman@corigine.com> Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
-rw-r--r--lib/netdev-offload-tc.c13
1 files changed, 11 insertions, 2 deletions
diff --git a/lib/netdev-offload-tc.c b/lib/netdev-offload-tc.c
index 27b87847e..dd4bdc4e7 100644
--- a/lib/netdev-offload-tc.c
+++ b/lib/netdev-offload-tc.c
@@ -867,7 +867,11 @@ parse_tc_flower_to_actions__(struct tc_flower *flower, struct ofpbuf *buf,
ct_offset = nl_msg_start_nested(buf, OVS_ACTION_ATTR_CT);
if (action->ct.commit) {
- nl_msg_put_flag(buf, OVS_CT_ATTR_COMMIT);
+ if (action->ct.force) {
+ nl_msg_put_flag(buf, OVS_CT_ATTR_FORCE_COMMIT);
+ } else {
+ nl_msg_put_flag(buf, OVS_CT_ATTR_COMMIT);
+ }
}
if (action->ct.zone) {
@@ -1356,7 +1360,12 @@ parse_put_flow_ct_action(struct tc_flower *flower,
NL_ATTR_FOR_EACH_UNSAFE (ct_attr, ct_left, ct, ct_len) {
switch (nl_attr_type(ct_attr)) {
case OVS_CT_ATTR_COMMIT: {
- action->ct.commit = true;
+ action->ct.commit = true;
+ }
+ break;
+ case OVS_CT_ATTR_FORCE_COMMIT: {
+ action->ct.commit = true;
+ action->ct.force = true;
}
break;
case OVS_CT_ATTR_ZONE: {