summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBen Pfaff <blp@nicira.com>2014-07-14 14:33:01 -0700
committerBen Pfaff <blp@nicira.com>2014-07-15 09:39:08 -0700
commite27e4ce996e70e12f3d4c8e362f42d967c2c6fa0 (patch)
tree28043c61fb0e3848e252091a0b07b08bcab7b847
parent3b62a9d360ad6b6c6dc364d5bfbf4347aeca85fa (diff)
downloadopenvswitch-e27e4ce996e70e12f3d4c8e362f42d967c2c6fa0.tar.gz
ofp-util: Fix null pointer dereference in ofputil_pull_buckets().
Found by clang-analyzer. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Jarno Rajahalme <jrajahalme@nicira.com>
-rw-r--r--lib/ofp-util.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/lib/ofp-util.c b/lib/ofp-util.c
index 6d551ada4..a4ee2c298 100644
--- a/lib/ofp-util.c
+++ b/lib/ofp-util.c
@@ -6986,6 +6986,7 @@ ofputil_pull_buckets(struct ofpbuf *msg, size_t buckets_length,
if (!ob) {
VLOG_WARN_RL(&bad_ofmsg_rl, "buckets end with %"PRIuSIZE" leftover bytes",
buckets_length);
+ return OFPERR_OFPGMFC_BAD_BUCKET;
}
ob_len = ntohs(ob->len);