summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorHyong Youb Kim <hyonkim@cisco.com>2019-02-01 23:19:40 -0800
committerBen Pfaff <blp@ovn.org>2019-02-04 12:29:11 -0800
commitd9e09b13df1bc521f01cff18ceb6624422e7df32 (patch)
treebabcbb1874047b4735fb74b115d21a983de7d218
parent6e361c991ab303b049665b5bf02dc76753404e7f (diff)
downloadopenvswitch-d9e09b13df1bc521f01cff18ceb6624422e7df32.tar.gz
ovs-tcpdump: Fix an undefined variable
Run ovs-tcpdump without --span, and it throws the following exception. Define mirror_select_all to avoid the error. Traceback (most recent call last): File "/usr/local/bin/ovs-tcpdump", line 488, in <module> main() File "/usr/local/bin/ovs-tcpdump", line 454, in main mirror_select_all) UnboundLocalError: local variable 'mirror_select_all' referenced before assignment Fixes: 0475db71c650 ("ovs-tcpdump: Add --span to mirror all ports on bridge.") Acked-by: Ilya Maximets <i.maximets@samsung.com> Signed-off-by: Hyong Youb Kim <hyonkim@cisco.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
-rwxr-xr-xutilities/ovs-tcpdump.in1
1 files changed, 1 insertions, 0 deletions
diff --git a/utilities/ovs-tcpdump.in b/utilities/ovs-tcpdump.in
index f0c0774a9..842d7d283 100755
--- a/utilities/ovs-tcpdump.in
+++ b/utilities/ovs-tcpdump.in
@@ -364,6 +364,7 @@ def main():
skip_next = False
mirror_interface = None
+ mirror_select_all = False
dump_cmd = 'tcpdump'
for cur, nxt in argv_tuples(sys.argv[1:]):