diff options
| author | Daniele Di Proietto <diproiettod@vmware.com> | 2016-07-28 18:02:01 -0700 |
|---|---|---|
| committer | Daniele Di Proietto <diproiettod@vmware.com> | 2016-07-29 14:08:10 -0700 |
| commit | efe179e041f97205d0442fd740e8ca7568534e2d (patch) | |
| tree | 0328e9163fc6711587282b511853dec286780de4 /lib/netdev-dummy.c | |
| parent | ac1432a467752c6295d0a138e4cd80a24ac732db (diff) | |
| download | openvswitch-efe179e041f97205d0442fd740e8ca7568534e2d.tar.gz | |
netdev-*: Do not use dp_packet_pad() in recv() functions.
All the netdevs used by dpif-netdev (except for netdev-dpdk) have a
dp_packet_pad() call in the receive function, probably because the
userspace datapath couldn't handle properly short packets.
This doesn't appear to be the case anymore.
This commit removes the call to have a more consistent behavior with the
kernel datapath.
All the testsuite changes in this commit adjust the expectations for
packet lengths in flow dumps and other stats. There's only one fix in
ovn.at: one of the test_ip() functions generated an incomplete udp
packet, which was not a problem until now, because of the padding.
Signed-off-by: Daniele Di Proietto <diproiettod@vmware.com>
Acked-by: Ben Pfaff <blp@ovn.org>
Diffstat (limited to 'lib/netdev-dummy.c')
| -rw-r--r-- | lib/netdev-dummy.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/lib/netdev-dummy.c b/lib/netdev-dummy.c index 813ce6933..a95040931 100644 --- a/lib/netdev-dummy.c +++ b/lib/netdev-dummy.c @@ -993,8 +993,6 @@ netdev_dummy_rxq_recv(struct netdev_rxq *rxq_, struct dp_packet_batch *batch) netdev->stats.rx_bytes += dp_packet_size(packet); ovs_mutex_unlock(&netdev->mutex); - dp_packet_pad(packet); - batch->packets[0] = packet; batch->count = 1; return 0; |