diff options
author | Ben Pfaff <blp@ovn.org> | 2018-08-24 14:50:14 -0700 |
---|---|---|
committer | Ben Pfaff <blp@ovn.org> | 2018-08-30 13:53:45 -0700 |
commit | 3ee9b38d5cd6c7b5dc29a5854432ffb77aa4f7db (patch) | |
tree | 69ca7de21ca9114789c1d4a6f3a2e50bb8ef30e4 /ofproto/collectors.h | |
parent | fc253483d6c874295c1a9eb7a86f44d2fe4f57ee (diff) | |
download | openvswitch-3ee9b38d5cd6c7b5dc29a5854432ffb77aa4f7db.tar.gz |
ofp-actions: Re-fix error path for parsing OpenFlow actions.
A previous commit attempted to fix the error path when the actions nested
within clone provoked an error. However, this commit just introduced a new
problem in another case, since it made ofpacts_pull_openflow_actions__()
restore a previously valid pointer to data that might have been
reallocated.
This commit takes another approach. Instead of trying to restore anything
at all, it just defines ofpacts_pull_openflow_actions__() to clear the
output buffer when there's an error. It seems that this is less error
prone. Most of the callers don't care; this commit fixes up the ones that
do.
Reported-at: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=9975
Fixes: 20cdd1dbd546 ("ofp-actions: Avoid assertion failure for clone(ct(...bad actions...)).")
Signed-off-by: Ben Pfaff <blp@ovn.org>
Tested-by: Yifeng Sun <pkusunyifeng@gmail.com>
Reviewed-by: Yifeng Sun <pkusunyifeng@gmail.com>
Diffstat (limited to 'ofproto/collectors.h')
0 files changed, 0 insertions, 0 deletions