summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* cfm: Define old_cfm_fault as 'enum cfm_fault_reason'.branch-1.8Alex Wang2014-03-201-1/+1
| | | | | | | | | | | CFM fault variable type has been changed to 'enum cfm_fault_reason' for long time. However, inside cfm_run(), the old_cfm_fault is still defined as boolean. This commit fixes the issue. Found by inspection. Signed-off-by: Alex Wang <alexw@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>
* packets: Fix typo in reserved multicast Ethernet addresses.Ben Pfaff2013-06-052-16/+17
| | | | | | | | | The reserved multicast Ethernet addresses begin with 01:80:c2, not 01:08:c2. Reported-by: Padmanabhan Krishnan <kprad1@yahoo.com> Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Ethan Jackson <ethan@nicira.com>
* connmgr: Fix memory leak in ofconn monitor table.Ben Pfaff2013-03-121-0/+1
| | | | | Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Ethan Jackson <ethan@nicira.com>
* ovsdb: Fix memory leak.Ben Pfaff2013-03-121-0/+5
| | | | | Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Ethan Jackson <ethan@nicira.com>
* netdev-linux: Fix netdev_linux_send() return value in corner case.Ben Pfaff2013-02-281-1/+1
| | | | | | | A negative 'sock' means there was an error but netdev_linux_send() returns a positive errno value on error. Signed-off-by: Ben Pfaff <blp@nicira.com>
* ofp-parse: Ignore "idle_age" and "hard_age" when parsing a flow string.Justin Pettit2013-02-011-1/+3
| | | | | | | | | | It should be possible to feed to output of "ovs-ofctl dump-flows" to "ovs-ofctl add-flows". However, some of the metadata needs to be ignored. "idle_age" and "hard_age" was recently added to the output of "ovs-ofctl dump-flows", but they were not ignored like the other metadata. This commit ignores them. Signed-off-by: Justin Pettit <jpettit@nicira.com>
* ovsdb-tool: Fix memory leak on error path in "show-log" implementation.Ben Pfaff2013-01-311-2/+4
| | | | | | | Found by Coverity. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Ethan Jackson <ethan@nicira.com>
* ovsdb-idl: Fix memory leak on error path.Ben Pfaff2013-01-311-1/+2
| | | | | | | Found by Coverity. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Ethan Jackson <ethan@nicira.com>
* meta-flow: Add missing "break" to mf_set_wild().Ben Pfaff2013-01-311-1/+2
| | | | | | | Found by Coverity. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Ethan Jackson <ethan@nicira.com>
* meta-flow: Avoid null pointer dereference in mf_format_frag_string().Ben Pfaff2013-01-311-6/+3
| | | | | | | | | | | | | The 'maskp' parameter to this function can be NULL, but the function always dereferenced it. This commit fixes the problem. This commit also fixes the order in which the value and mask were adjusted to correctly discard 1-bits outside of FLOW_NW_FRAG_MASK. Found by Coverity. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Ethan Jackson <ethan@nicira.com>
* ovsdb: Fix double-free in ovsdb_jsonrpc_session_close().Ben Pfaff2013-01-241-2/+1
| | | | | | | | | | | | | ovsdb_session_destroy() was called twice but it should only be called once. This double-free is unlikely to cause problems in practice because it only triggers if there were ever more than two outstanding requests in the session at a time (because the only data being freed is an hmap, which does not allocate any heap memory unless the hmap has more than two elements). Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Ethan Jackson <ethan@nicira.com>
* Revert "datapath: Avoid null deref when GSO is for verifying header ↵Jesse Gross2013-01-211-2/+0
| | | | | | | | | | | | | | | | | | integrity only." This reverts commit 00c7faf3e5b7d4020e995a1429cf94313f197171. In general, it should not be possible have a NULL return value from skb_gso_segment() since we're not actually trying to verify the header integrity. No other callers with similar needs have NULL checks. The actual cause of the problem was LRO packets, which OVS isn't equipped to handle. The commit 33e031e99cc630baf1b0cb9256710dee7d9ab66d (datapath: Move LRO check from transmit to receive.) solves that problem by fixing the LRO check. In order to avoid possibly masking any other problems, this reverts the GSO check which should no longer be needed. Signed-off-by: Jesse Gross <jesse@nicira.com>
* datapath: Move LRO check from transmit to receive.Jesse Gross2013-01-211-11/+12
| | | | | | | | | | | | | | | | | | | Commit 24b019f808211a95078efd916064af0975ca5733 (datapath: Disable LRO from userspace instead of the kernel.) accidentally moved the check for LRO packets from the receive path to transmit. Since this check is supposed to protect OVS (and other parts of the system) from packets that it cannot handle it is obviously not useful on egress. Therefore, this commit moves it back to the receive side. The primary problem that this caused is upcalls to userspace tried to segment the packet even though no segmentation information is available. This would later cause NULL pointer dereferences when skb_gso_segment() did nothing. Bug #14772 Signed-off-by: Jesse Gross <jesse@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>
* datapath: Avoid null deref when GSO is for verifying header integrity only.Ben Pfaff2013-01-211-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | skb_gso_segment() has the following comment: * It may return NULL if the skb requires no segmentation. This is * only possible when GSO is used for verifying header integrity. Somehow queue_gso_packets() has never hit this case before, but some failures have suddenly been reported. This commit should fix the problem. Additional commentary by Jesse: We shouldn't normally be hitting this case because we're actually trying to do GSO, not header validation. However, I guess the guest/backend must be generating a packet with an MSS, which tricks us into thinking that it's GSO, but no GSO is actually requested. In the case of the bridge, header validation does take place so the situation is handled already. It seems not ideal that the network backend doesn't sanitize these packets but it's probably good that we handle it in any case. Bug #14772. Reported-by: Deepesh Govindan <dgovindan@vmware.com> Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Jesse Gross <jesse@nicira.com>
* rconn: Avoid memory leak in rconn_send_with_limit() on queue overflow.Ben Pfaff2013-01-071-6/+5
| | | | | | Bug #14357. Reported-by: Luca Giraudo <lgiraudo@nicira.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
* ovs-ctl: Exit, instead of resuming, after handling fatal signals.Ben Pfaff2012-12-261-1/+1
| | | | | | | | | | | | | | | When I wrote the "trap" calls in ovs-ctl, I had the mistaken notion that "trap $cmd $signal" would execute $cmd and then exit when $signal was caught. This is incorrect. Instead, it executes $cmd and then resumes executing the shell script. On the other hand, "trap $cmd 0" does by itself what I wanted: it causes the shell to execute $cmd and then exits due to the signal. So this commit changes the offending traps to use this form. Bug #14290. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Kyle Mestery <kmestery@cisco.com>
* meta-flow: Don't allow negative port numbers.Justin Pettit2012-12-131-1/+4
| | | | | | | | | | | | | | | If a negative number is supplied, the parsing code used to convert it into a signed one. We ran into an incident where a third-party script was attempting to get the OpenFlow port number for an interface, but got -1 from the database, since the number had not yet been assigned. This was converted to 65535, which maps to OFPP_NONE and all flows with ingress port OFPP_NONE were modified. This commit disallows negative port numbers to help prevent broken integration scripts from disturbing the flow table. Issue #14036 Signed-off-by: Justin Pettit <jpettit@nicira.com>
* bond: Fix segfault sending learning packets with LACP disabled.Ben Pfaff2012-11-292-1/+2
| | | | | | | | | | | | | | | | | | | | | It is essentially an invalid configuration to disable LACP but request TCP balancing: in this configuration, the bond drops all packets. But may_send_learning_packets() would still indicate that learning packets should be sent, so bond_compose_learning_packet() would try to choose an output slave for those packets, which would be NULL (because all packets are dropped), which would cause a segfault upon dereference. This commit fixes the problem by making may_send_learning_packets() no longer indicate that learning packets should be sent. I tested this issue by modifying bond_should_send_learning_packets() to always return true if may_send_learning_packets() returns true, and then introducing the invalid configuration described above. Without this comit, ovs-vswitchd segfaults quickly; with this commit, it does not. Bug #14090. Reported-by: Kiran Shanbhog <kiran@vmware.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
* python/ovs/stream: Fix Stream.connect() retval for incomplete connection.Ben Pfaff2012-11-211-9/+11
| | | | | | | | | | If the loop condition in Stream.connect() was false, which is especially likely for TCP connections, then Stream.connect() would return None, which violates its documented behavior. This commit fixes the problem. Reported-by: Isaku Yamahata <yamahata@valinux.co.jp> Tested-by: Isaku Yamahata <yamahata@valinux.co.jp> Signed-off-by: Ben Pfaff <blp@nicira.com>
* ovs-ctl.in: increase the limit of fdCong Wang2012-11-151-1/+1
| | | | | | | | | We can't create more than 248 bridges with the current limit 5000, so increase it to 6000 so that at least 256+ bridges could be created. Cc: Ben Pfaff <blp@nicira.com> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
* socket-util: Report fd of -1 on error in inet_open_active().Ben Pfaff2012-11-071-0/+1
| | | | | | | | | | | | | | | | inet_open_active() is documented to report a fd of -1 when an error occurs. All three of its callers rely on this, by checking only the fd to determine whether there was an error. This means that if the call to set_nonblocking() or set_dscp() or connect() failed, then the callers would try to use a fd that had already been closed, wreaking havoc. This fixes a bug introduced in commit a4efa3fc5d (socket-util: Close socket on failed dscp modification.) Bug #13750. Reported-by: Scott Hendricks <shendricks@vmware.com> Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Ethan Jackson <ethan@nicira.com>
* netdev-vport: Fix ToS/TTL mixup in unparsing.Jesse Gross2012-09-251-2/+2
| | | | | | | | | When unparsing the kernel tunnel configuration, TTL was incorrectly converted to "tos". Although it leads to confusing configuration output, actual operation is not affected. Signed-off-by: Jesse Gross <jesse@nicira.com> Acked-by: Kyle Mestery <kmestery@cisco.com>
* stream-unix: Reduce connection failure log level from ERR to WARN.Ben Pfaff2012-09-171-1/+1
| | | | | | | | | Sometimes this just means that the daemon we're connecting to is restarting. Bug #13177. Reported-by: Scott Hendricks <shendricks@nicira.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
* stream-ssl: Change "bootstrap race" log message from ERR to INFO.Ben Pfaff2012-09-172-1/+2
| | | | | | | | | This situation can and will happen, and we handle it successfully, so it's not an error. Bug #12922. Reported-by: Scott Hendricks <shendricks@nicira.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
* dpif-linux: Report packet loss as WARN instead of ERR.Ben Pfaff2012-09-051-2/+2
| | | | | | | | Packet loss is recoverable so it doesn't warrant an ERR. Bug #12920. Reported-by: Scott Hendricks <shendricks@nicira.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
* datapath: Fix FLOW_BUFSIZE definition.Jesse Gross2012-09-031-3/+5
| | | | | | | | | | | | | | | | | This is analogous to the change made in userspace with 2508ac16defd417b94fb69689b6b1da4fbc76282 (odp-util: Update ODPUTIL_FLOW_KEY_BYTES for current kernel flow format.). The extra space for vlan encapsulation was not included in the allocation for maximum length flows. Found by code inspection and to my knowledge has never been hit, likely because skb allocations are padded out to a cacheline, making userspace more susceptible to this problem than the kernel. In theory, however, the right combination of flow and packet size could result in a kernel panic. Signed-off-by: Jesse Gross <jesse@nicira.com> Acked-by: Kyle Mestery <kmestery@cisco.com>
* man-pages: Add missing entry for matching metadataJoe Stringer2012-08-311-0/+8
| | | | | Signed-off-by: Joe Stringer <joe@wand.net.nz> Signed-off-by: Ben Pfaff <blp@nicira.com>
* vswitchd: Respect other_config:stp-enable port setting.Ethan Jackson2012-08-291-1/+1
| | | | | | | | | | | | Commit a699f614 (lib: Utilize smaps in the idl.) broke the other_config:stp-enable port setting in two ways. First, it changed the default if the setting was missing to disabled. Second, if the setting was present, it did the opposite of what the user configured. Bug #13122. Reported-by: Paul Ingram <paul@nicira.com> Signed-off-by: Ethan Jackson <ethan@nicira.com>
* ofproto-dpif: Make sure one-packet flows have zero duration (again).Ben Pfaff2012-08-281-15/+21
| | | | | | | | | | | | | | | | | | | | | | | | | commit 6a0a5bbbc (ofproto-dpif: Make sure one-packet flows have zero duration.) was supposed to fix failures in the "ofproto-dpif - NetFlow flow expiration" test, but it didn't fix the whole problem. That commit eliminated one reason why a one-packet flow might be shown as having an nonzero duration, but missed another. The other reason was that the call to dpif_flow_stats_extract() could obtain a time later than the time that a new facet was created. (This wasn't obvious because dpif_flow_stats_extract() obtained the time internally instead of taking it from the caller.) This commit fixes that problem, by using the facet creation there too for the first packet in a facet. This problem has suddenly started showing up in a lot of builds. I think it's probably because of the recent change that makes x86-64 skip the timer optimizations, so that the return value of time_msec() changes every 1 ms, not just every 100 ms. I've tested this by running the test in question in a loop for several minutes, without any failures. Signed-off-by: Ben Pfaff <blp@nicira.com>
* dpif: Add 'used' argument to dpif_flow_stats_extract().Ben Pfaff2012-08-283-8/+10
| | | | | | | | | | | The following commit will need to use a value other than a literal time_msec() in one case. This commit is just preparation. Factoring the time_msec() call out of the loop in handle_flow_miss_without_facet() is a really minor optimization. It isn't the main point here. Signed-off-by: Ben Pfaff <blp@nicira.com>
* datapath: Fix namespace refcount leak on failed init.Jesse Gross2012-08-221-1/+3
| | | | | | | | | | | | If a datapath fails to initialze fully (likely due to out-of-memory) then it's possible that we can take a reference to a network namespace but never release it. This fixes the problem by releasing any resources in the event of an error. Found by code inspection, it's likely to be extremely rare in practice. Signed-off-by: Jesse Gross <jesse@nicira.com> Acked-by: Pravin B Shelar <pshelar@nicira.com>
* stp: port_no counter is off by oneAnsis Atteka2012-08-211-1/+1
| | | | | | | | | | | | This counter was off by one, because port_num should be less than STP_MAX_PORTS. This caused an assert hit later in stp_get_port(). Issue: 13059 Signed-off-by: Ansis Atteka <aatteka@nicira.com> Reported-by: Ram Jothikumar <rjothikumar@nicira.com> Acked-by: Ethan Jackson <ethan@nicira.com>
* bond: Tag flows according to their hash bucket, not just their slave.Ben Pfaff2012-08-212-4/+7
| | | | | | | | | | | | | | | | | | | | | | | | | The bonding code is supposed to tag flows two ways: - According to the chosen bond slave, to make it easy to invalidate all of the flows assigned to a given slave. - According to the hash value for a flow, to make it easy to invalidate all of the flows that hash into the same bucket. However, the code wasn't actually applying the hash-based tags. This meant that rebalancing didn't take effect immediately, and so after rebalancing we could get log messages like this: inconsistency in subfacet (actions were: 5) (correct actions: 4) specifying some flow that was moved by the rebalance. This commit fixes the problem by applying the hash-based tags. Bug #12847. Reported-by: Pratap Reddy <preddy@nicira.com> Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Ethan Jackson <ethan@nicira.com>
* ofp-print: Fix memory leak printing flow stats replies.Ben Pfaff2012-08-171-0/+1
| | | | | | Found by valgrind. Signed-off-by: Ben Pfaff <blp@nicira.com>
* ofproto-dpif: Avoid dereferencing possibly null or wild pointer.Ben Pfaff2012-08-161-1/+2
| | | | | | | | | | | | | If ofpacts_len is 0 then ofpacts->type is a bad reference. (An early draft of ofpacts used an OFPACT_END sentinel so that there was always data there in this function, but in review the sentinel got deleted and I did not notice that this function needed an update.) Found by valgrind. Bug #12847. Signed-off-by: Ben Pfaff <blp@nicira.com>
* ofproto-dpif: Make sure one-packet flows have zero duration.Ben Pfaff2012-08-161-1/+9
| | | | | | | | | | | | | | | | | | | | | A Nicira internal build recently failed the "ofproto-dpif - NetFlow flow expiration" test because of the following difference in output: header: v5, seq 0, engine 2,1 -rec: [...], 1 pkts, 60 bytes, ICMP 8:0, time <moment> +rec: [...], 1 pkts, 60 bytes, ICMP 8:0, time <range> Looking at the actual output, it is: rec: 192.168.0.1 > 192.168.0.2, if 1 > 65535, 1 pkts, 60 bytes, ICMP 8:0, time 8...9 That is, a one-packet flow was shown to have more than a momentary duration, which doesn't make sense. This commit fixes the problem by making sure that creating a facet and then its initial subfacet only checks the current time once. Signed-off-by: Ben Pfaff <blp@nicira.com>
* ofproto-dpif: Avoid searching all subfacets when creating first in a facet.Ben Pfaff2012-08-161-10/+14
| | | | | | | | | | | | When we create the first subfacet within a facet, we know that there cannot be an existing subfacet with the same key, so we can skip the search through the ofproto's table of subfacets. This is a small optimization, but it should not affect the flow setup rate in most benchmarks, because in the stressful situations that benchmarks create, OVS does not set up flows. Signed-off-by: Ben Pfaff <blp@nicira.com>
* netdev: Map to OpenFlow port for flow lookupEd Maste2012-08-151-1/+1
| | | | | | | | In the flow hash special ports are stored using OpenFlow constants. For example the "local port" is stored as 0xfffe (OFPP_LOCAL). Signed-off-by: Ed Maste <emaste@freebsd.org> Signed-off-by: Ben Pfaff <blp@nicira.com>
* datapath: Relax set header validation.Jesse Gross2012-08-032-4/+4
| | | | | | | | | | | | | | | | | When installing a flow with an action to set a particular field we need to validate that the packets that are part of the flow actually contain that header. With IP we use zeroed addresses and with TCP/UDP the check is for zeroed ports. This check is overly broad and can catch packets like DHCP requests that have a zero source address in a legitimate header. This changes the check to look for a zeroed protocol number for IP or for both ports be zero for TCP/UDP before considering the header to not exist. Bug #12769 Reported-by: Ethan Jackson <ethan@nicira.com> Signed-off-by: Jesse Gross <jesse@nicira.com> Acked-by: Pravin B Shelar <pshelar@nicira.com>
* flow: Correctly consider nw_frag_mask in some flow_wildcards_*() functions.Ben Pfaff2012-08-031-1/+4
| | | | | | | This probably means that some classifier functions based on the fragment type of packets have never worked properly. Signed-off-by: Ben Pfaff <blp@nicira.com>
* ofproto: Avoid sensitivity to hash order in flow monitor pause/resume test.Ben Pfaff2012-08-031-3/+24
| | | | Signed-off-by: Ben Pfaff <blp@nicira.com>
* flow: Fix wild pointer dereference in flow_compose().Ethan Jackson2012-08-011-0/+1
| | | | | | | | | | | The 'ip' variable in flow_compose() points to some memory allocated in an ofpbuf. The ofpbuf is modified without making the necessary updates to the location of 'ip' causing a potential wild memory access. Found by inspection. Signed-off-by: Ethan Jackson <ethan@nicira.com>
* Set dates for release of 1.7.0.Justin Pettit2012-07-302-2/+3
| | | | Signed-off-by: Justin Pettit <jpettit@nicira.com>
* ovs-ctl.in: Don't stop forwarding while restarting the database.Justin Pettit2012-07-301-9/+27
| | | | | | | | | | | | | | | | | | Previously, the force-reload-kmod command would stop forwarding, stop the database, restart the database, and then restart forwarding. If the database is large, it can take a while to be read (we've seen as much as 10 seconds), which means the switch is not forwarding traffic during that time. This change stops and starts the database before restarting the forwarding path. This means that ovs-vswitchd will lose its connectivity to the database during a force-reload-kmod, but while it will complain a little in the logs, it will continue to operate properly. Signed-off-by: Justin Pettit <jpettit@nicira.com> Feature #12643
* ovs-ctl.in: Consistently use spaces instead of tabs.Justin Pettit2012-07-301-40/+40
| | | | Signed-off-by: Justin Pettit <jpettit@nicira.com>
* Avoid implementation-defined strerror behaviourEd Maste2012-07-271-1/+2
| | | | | | | | | | | | | | | | | POSIX states that the string returned by strerror() may be overwritten by a subsequent call (i.e., because it returns a pointer to a static buffer). Make a copy of one of the two strerror() strings to avoid this. Background: FreeBSD historically returned such a pointer only in the case of an invalid errno. With the addition of NLS strerror was changed to do so for all calls. Prior to this change I had confusing results from the test suite like "... is 22 (Invalid argument) but should be 0 (Invalid argument)". Signed-off-by: Ed Maste <emaste@adaranet.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
* ovs-ctl: Start the rest of Open vSwitch if loading brcompat module fails.Ben Pfaff2012-07-271-1/+6
| | | | | | | | | | | This may be more useful in practice than failing the entire OVS startup sequence. Debian bug #681955. CC: 681955@bugs.debian.org Reported-by: Bastian Blank <waldi@debian.org> Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Simon Horman <horms@verge.net.au>
* packets: First-hop router redundancy protocol MAC addresses are not BPDUs.Ben Pfaff2012-07-262-62/+70
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Commit c93f9a78c349 (packets: Update the reserved protocols list.) added a number of first-hop router redundancy protocol MAC addresses to the list of BPDU MAC addresses. This means that packets destined to those MAC addresses are dropped when other-config:forward-bpdu is set to false on a bridge (the default setting). However, this behavior is incorrect, because these MAC addresses are not special in the way that, say, STP frames are special. STP is a switch-to-switch protocol that end hosts have no use for, but end hosts do speak directly to routers on the MAC addresses assigned by VRRP and the other protocols in this category. Therefore, dropping packets in this category means that end hosts can no longer talk to their first-hop router, if that router is running one of these protocols. This commit also refines the match used for EDP and EAPS, and adds Cisco CFM to the protocols that are dropped. After this commit, the following destination MACs are dropped: - 01:08:c2:00:00:00 - 01:08:c2:00:00:01 - 01:08:c2:00:00:02 - 01:08:c2:00:00:03 - 01:08:c2:00:00:04 - 01:08:c2:00:00:05 - 01:08:c2:00:00:06 - 01:08:c2:00:00:07 - 01:08:c2:00:00:08 - 01:08:c2:00:00:09 - 01:08:c2:00:00:0a - 01:08:c2:00:00:0b - 01:08:c2:00:00:0c - 01:08:c2:00:00:0d - 01:08:c2:00:00:0e - 01:08:c2:00:00:0f - 00:e0:2b:00:00:00 - 00:e0:2b:00:00:04 - 00:e0:2b:00:00:06 - 01:00:0c:00:00:00 - 01:00:0c:cc:cc:cc - 01:00:0c:cc:cc:cd - 01:00:0c:cd:cd:cd - 01:00:0c:cc:cc:c0 - 01:00:0c:cc:cc:c1 - 01:00:0c:cc:cc:c2 - 01:00:0c:cc:cc:c3 - 01:00:0c:cc:cc:c4 - 01:00:0c:cc:cc:c5 - 01:00:0c:cc:cc:c6 - 01:00:0c:cc:cc:c7 Bug #12618. CC: Ben Basler <bbasler@nicira.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
* NEWS: Document flow setup improvement in 1.7 release.Justin Pettit2012-07-251-1/+2
| | | | | | Also use consistent capitalization for "DSCP". Signed-off-by: Justin Pettit <jpettit@nicira.com>
* ovs-ofctl: Avoid printing false differences on "ovs-ofctl diff-flows".Ben Pfaff2012-07-252-22/+59
| | | | | | | | | | | | | | | | | | It is possible for "struct ofpact"s to differ bytewise even if they are equivalent when converted to another representation, such as OpenFlow 1.0 action format or a string representation. This can cause "ovs-ofctl diff-flows" to print surprising false "differences", e.g. as in the bug report: - actions=resubmit(,1) + actions=resubmit(,1) This commit fixes the problem by comparing not just the ofpacts but also the string representation and printing a difference only if both differ. Bug #8899. Reported-by: Luca Giraudo <lgiraudo@nicira.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
View Lorry Controller Status