summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Prepare for 1.7.2.v1.7.2Justin Pettit2012-11-093-1/+12
| | | | Signed-off-by: Justin Pettit <jpettit@nicira.com>
* socket-util: Report fd of -1 on error in inet_open_active().Ben Pfaff2012-11-071-0/+1
| | | | | | | | | | | | | | | | inet_open_active() is documented to report a fd of -1 when an error occurs. All three of its callers rely on this, by checking only the fd to determine whether there was an error. This means that if the call to set_nonblocking() or set_dscp() or connect() failed, then the callers would try to use a fd that had already been closed, wreaking havoc. This fixes a bug introduced in commit a4efa3fc5d (socket-util: Close socket on failed dscp modification.) Bug #13750. Reported-by: Scott Hendricks <shendricks@vmware.com> Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Ethan Jackson <ethan@nicira.com>
* netdev-vport: Fix ToS/TTL mixup in unparsing.Jesse Gross2012-09-251-2/+2
| | | | | | | | | When unparsing the kernel tunnel configuration, TTL was incorrectly converted to "tos". Although it leads to confusing configuration output, actual operation is not affected. Signed-off-by: Jesse Gross <jesse@nicira.com> Acked-by: Kyle Mestery <kmestery@cisco.com>
* datapath: Fix FLOW_BUFSIZE definition.v1.7.1Jesse Gross2012-09-031-3/+5
| | | | | | | | | | | | | | | | | This is analogous to the change made in userspace with 2508ac16defd417b94fb69689b6b1da4fbc76282 (odp-util: Update ODPUTIL_FLOW_KEY_BYTES for current kernel flow format.). The extra space for vlan encapsulation was not included in the allocation for maximum length flows. Found by code inspection and to my knowledge has never been hit, likely because skb allocations are padded out to a cacheline, making userspace more susceptible to this problem than the kernel. In theory, however, the right combination of flow and packet size could result in a kernel panic. Signed-off-by: Jesse Gross <jesse@nicira.com> Acked-by: Kyle Mestery <kmestery@cisco.com>
* datapath: Fix namespace refcount leak on failed init.Jesse Gross2012-08-221-1/+3
| | | | | | | | | | | | If a datapath fails to initialze fully (likely due to out-of-memory) then it's possible that we can take a reference to a network namespace but never release it. This fixes the problem by releasing any resources in the event of an error. Found by code inspection, it's likely to be extremely rare in practice. Signed-off-by: Jesse Gross <jesse@nicira.com> Acked-by: Pravin B Shelar <pshelar@nicira.com>
* stp: port_no counter is off by oneAnsis Atteka2012-08-221-1/+1
| | | | | | | | | | | | This counter was off by one, because port_num should be less than STP_MAX_PORTS. This caused an assert hit later in stp_get_port(). Issue: 13059 Signed-off-by: Ansis Atteka <aatteka@nicira.com> Reported-by: Ram Jothikumar <rjothikumar@nicira.com> Acked-by: Ethan Jackson <ethan@nicira.com>
* bond: Tag flows according to their hash bucket, not just their slave.Ben Pfaff2012-08-212-4/+7
| | | | | | | | | | | | | | | | | | | | | | | | | The bonding code is supposed to tag flows two ways: - According to the chosen bond slave, to make it easy to invalidate all of the flows assigned to a given slave. - According to the hash value for a flow, to make it easy to invalidate all of the flows that hash into the same bucket. However, the code wasn't actually applying the hash-based tags. This meant that rebalancing didn't take effect immediately, and so after rebalancing we could get log messages like this: inconsistency in subfacet (actions were: 5) (correct actions: 4) specifying some flow that was moved by the rebalance. This commit fixes the problem by applying the hash-based tags. Bug #12847. Reported-by: Pratap Reddy <preddy@nicira.com> Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Ethan Jackson <ethan@nicira.com>
* netdev: Map to OpenFlow port for flow lookupEd Maste2012-08-161-1/+1
| | | | | | | | In the flow hash special ports are stored using OpenFlow constants. For example the "local port" is stored as 0xfffe (OFPP_LOCAL). Signed-off-by: Ed Maste <emaste@freebsd.org> Signed-off-by: Ben Pfaff <blp@nicira.com>
* Prepare for 1.7.1.Justin Pettit2012-08-133-1/+12
| | | | Signed-off-by: Justin Pettit <jpettit@nicira.com>
* tests: Fix MockXenAPI to make the ovs-xapi-sync test case pass again.Ben Pfaff2012-08-131-1/+17
| | | | | | | | | Commit a8d9dfc788 (xenserver: Improve efficiency of code by using get_all_records_where()) updated the ovs-xapi-sync script and caused a unit test failure. This fixes it. Bug #12848. Signed-off-by: Ben Pfaff <blp@nicira.com>
* xenserver: Improve efficiency of code by using get_all_records_where()Rob Hoes2012-08-131-4/+3
| | | | | | | | | | | | Replace the get_record() for network references which caused as many slave-to-master calls as there are Network records plus one. The get_all_records_where() call gets exactly what is needed with a single call. Bug #12848. Signed-off-by: Rob Hoes <rob.hoes@citrix.com> Acked-by: Dominic Curran <dominic.curran@citrix.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
* rconn: Treat draining a message from the send queue as activity.Ben Pfaff2012-08-131-9/+14
| | | | | | | | | | | | | | | | | | | | | | | | Until now, the rconn module has used messages received from the controller as the sole means to determine that the connection is up. This can interact badly with the OVS connection manager in ofproto, which stops reading and processing messages from the receive queue when there is a backlog in the send queue for a given connection (because reading and processes messages is the main cause of messages getting pushed onto the send queue). So, if a send queue backlog lasts more than twice the inactivity probe interval, then the connection drops, whether the controller is sending messages or not. Dumping a large flow table can trigger this behavior if the controller becomes temporarily busy or if the network between OVS and a controller is slow. The problem can easily repeat itself, since upon reconnection the controller will generally dump the flow table. This commit fixes the problem by expanding the definition of "activity" to include successfully sending an OpenFlow message that was previously queued. Bug #12789. Reported-by: Natasha Gude <natasha@nicira.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
* rconn: Remove unused functions.Ben Pfaff2012-08-132-61/+0
| | | | Signed-off-by: Ben Pfaff <blp@nicira.com>
* datapath: Relax set header validation.Jesse Gross2012-08-032-4/+4
| | | | | | | | | | | | | | | | | When installing a flow with an action to set a particular field we need to validate that the packets that are part of the flow actually contain that header. With IP we use zeroed addresses and with TCP/UDP the check is for zeroed ports. This check is overly broad and can catch packets like DHCP requests that have a zero source address in a legitimate header. This changes the check to look for a zeroed protocol number for IP or for both ports be zero for TCP/UDP before considering the header to not exist. Bug #12769 Reported-by: Ethan Jackson <ethan@nicira.com> Signed-off-by: Jesse Gross <jesse@nicira.com> Acked-by: Pravin B Shelar <pshelar@nicira.com>
* flow: Correctly consider nw_frag_mask in some flow_wildcards_*() functions.Ben Pfaff2012-08-031-2/+5
| | | | | | | This probably means that some classifier functions based on the fragment type of packets have never worked properly. Signed-off-by: Ben Pfaff <blp@nicira.com>
* flow: Fix wild pointer dereference in flow_compose().Ethan Jackson2012-08-011-0/+1
| | | | | | | | | | | The 'ip' variable in flow_compose() points to some memory allocated in an ofpbuf. The ofpbuf is modified without making the necessary updates to the location of 'ip' causing a potential wild memory access. Found by inspection. Signed-off-by: Ethan Jackson <ethan@nicira.com>
* Set dates for release of 1.7.0.v1.7.0Justin Pettit2012-07-302-2/+3
| | | | Signed-off-by: Justin Pettit <jpettit@nicira.com>
* Avoid implementation-defined strerror behaviourEd Maste2012-07-271-1/+2
| | | | | | | | | | | | | | | | | POSIX states that the string returned by strerror() may be overwritten by a subsequent call (i.e., because it returns a pointer to a static buffer). Make a copy of one of the two strerror() strings to avoid this. Background: FreeBSD historically returned such a pointer only in the case of an invalid errno. With the addition of NLS strerror was changed to do so for all calls. Prior to this change I had confusing results from the test suite like "... is 22 (Invalid argument) but should be 0 (Invalid argument)". Signed-off-by: Ed Maste <emaste@adaranet.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
* ovs-ctl: Start the rest of Open vSwitch if loading brcompat module fails.Ben Pfaff2012-07-271-1/+6
| | | | | | | | | | | This may be more useful in practice than failing the entire OVS startup sequence. Debian bug #681955. CC: 681955@bugs.debian.org Reported-by: Bastian Blank <waldi@debian.org> Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Simon Horman <horms@verge.net.au>
* NEWS: Document flow setup improvement in 1.7 release.Justin Pettit2012-07-251-1/+2
| | | | | | Also use consistent capitalization for "DSCP". Signed-off-by: Justin Pettit <jpettit@nicira.com>
* Fix race condition in parallel execution of "make install".Ben Pfaff2012-07-231-1/+1
| | | | | | | | | | | | | ovs-vsctl is listed, incorrectly, in both bin_PROGRAMS and bin_SCRIPTS. This meant that "make install" with the -j option could try to install ovs-vsctl two times in parallel, a race that occasionally caused a build failure, e.g.: http://buildd.debian.org/status/fetch.php?pkg=openvswitch&arch=s390&ver=1.4.2%2Bgit20120612-5&stamp=1342851603 Debian bug #682384. CC: 682384@bugs.debian.org Reported-by: Bastian Blank <waldi@debian.org> Signed-off-by: Ben Pfaff <blp@nicira.com>
* debian: Remove controller keys on openvswitch-controller package purge.Ben Pfaff2012-07-202-0/+45
| | | | | | | | | | | A Debian package is expected to remove all its configuration files (which includes all files in /etc) when it is purged, but the openvswitch-controller package wasn't doing that. This fixes the problem. Debian bug #682187. CC: 682187@bugs.debian.org Reported-by: Andreas Beckmann <debian@abeckmann.de> Signed-off-by: Ben Pfaff <blp@nicira.com>
* debian: Do not change iptables rules by default.Ben Pfaff2012-07-181-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Debian kernel maintainer Bastian Blank writes, at http://bugs.debian.org/680537: The netfilter rules are a shared resource. There is no synchronization, so the admin have the last word. As kernel maintainer, I see it similar to a configuration file, so §10.7 policy applies. The purpose of openvswitch is to provide support for switching, not to setup filter rules. This means it violates the principle of least surprise. I believe that the argument by analogy to configuration files is weak, given that the Debian policy section in question is very specifically about files, not about general principles. On the other hand, Debian does not install any firewall by default, so the presence of a rule that blocks GRE traffic is a sign that the administrator has taken an explicit action to install a firewall that blocks GRE, and therefore it is rather rude to override this. Therefore, this patch simply turns off this behavior on Debian, given that in ordinary Debian installations it will have no adverse effect on Open vSwitch. Debian bug #680537. CC: 680537@bugs.debian.org Reported-by: Bastian Blank <waldi@debian.org> Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Simon Horman <horms@verge.net.au>
* cfm: Always initialize CCM "internal_ms_x" extension field.Ben Pfaff2012-07-111-0/+2
| | | | | | | | | | | | | | | | | | | | | | Found by valgrind: Syscall param socketcall.sendmsg(msg.msg_iov[i]) points to uninitialised byte(s) at 0x42D3021: sendmsg (in /lib/libc-2.5.so) by 0x80E4D23: nl_sock_transact (netlink-socket.c:670) by 0x80D9086: dpif_linux_execute__ (dpif-linux.c:872) by 0x807D6AE: dpif_execute__ (dpif.c:957) by 0x807D6FE: dpif_execute (dpif.c:987) by 0x805DED9: send_packet (ofproto-dpif.c:4727) by 0x805F8E1: port_run_fast (ofproto-dpif.c:2441) by 0x8065CF6: run_fast (ofproto-dpif.c:926) by 0x805674F: ofproto_run_fast (ofproto.c:1148) by 0x804C957: bridge_run_fast (bridge.c:1980) by 0x8053F49: main (ovs-vswitchd.c:123) Address 0xbea0895c is on thread 1's stack Bug #11797. Signed-off-by: Ben Pfaff <blp@nicira.com>
* datapath: Check gso_type for correct sk_buff in queue_gso_packets().Ben Pfaff2012-07-101-1/+2
| | | | | | | | | | | | | | | | | At the point where it was used, skb_shinfo(skb)->gso_type referred to a post-GSO sk_buff. Thus, it would always be 0. We want to know the pre-GSO gso_type, so we need to obtain it before segmenting. Before this change, the kernel would pass inconsistent data to userspace: packets for UDP fragments with nonzero offset would be passed along with flow keys that indicate a zero offset (that is, the flow key for "later" fragments claimed to be "first" fragments). This inconsistency tended to confuse Open vSwitch userspace, causing it to log messages about "failed to flow_del" the flows with "later" fragments. Bug #12394. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Jesse Gross <jesse@nicira.com>
* debian: Remove obsolete advice to edit /etc/default/openvswitch-switch.Ben Pfaff2012-07-091-5/+1
| | | | | | This hasn't been necessary for a long time. Signed-off-by: Ben Pfaff <blp@nicira.com>
* debian: Add "netbase" dependency for /etc/protocols.Ben Pfaff2012-07-092-1/+2
| | | | | | | | | | ovs-ctl.in uses /etc/protocols, which is in the "netbase" package, so a dependency is required. Debian bug #680537. CC: 680537@bugs.debian.org Reported-by: Bastian Blank <waldi@debian.org> Signed-off-by: Ben Pfaff <blp@nicira.com>
* ovs-check-dead-ifs: Tolerate processes that disappear during run.Ben Pfaff2012-07-052-1/+7
| | | | | | | | | os.listdir("/proc/%d/fd" % pid) throws OSError if 'pid' died since the list of pids was obtained. Bug #12375. Reported-by: Amey Bhide <abhide@nicira.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
* ovs-brcompatd: Fix sending replies to kernel requests.Ben Pfaff2012-07-054-19/+44
| | | | | | | | | | | | | | | Commit 7d7447 (netlink: Postpone choosing sequence numbers until send time.) broke ovs-brcompatd because it prevented userspace replies to kernel requests from using the correct sequence numbers. This commit fixes it. Atzm Watanabe found the root cause and provided an alternative patch to avoid the problem. Reported-by: André Ruß <andre.russ@hybris.com> Reported-by: Atzm Watanabe <atzm@stratosphere.co.jp> Tested-by: Atzm Watanabe <atzm@stratosphere.co.jp> Signed-off-by: Ben Pfaff <blp@nicira.com>
* python: Call 'wait' methods correctly in jsonrpc and stream code.Ben Pfaff2012-07-022-2/+2
| | | | | | Bug #12301. Reported-by: Mike Kruze <mkruze@nicira.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
* ovs-vswitchd: Call mlockall() from the daemon, not the parent or monitor.Ben Pfaff2012-06-291-7/+15
| | | | | | | | | | | | | | | mlockall(2) says: Memory locks are not inherited by a child created via fork(2) and are automatically removed (unlocked) during an execve(2) or when the process terminates. which means that --mlockall was ineffective in combination with --detach or --monitor or both. Both are used in the most common production configuration of Open vSwitch, so this means that --mlockall has never been effective in production. Signed-off-by: Ben Pfaff <blp@nicira.com>
* Update dates and notes for 1.6.1 release.Justin Pettit2012-06-262-1/+14
| | | | Signed-off-by: Justin Pettit <jpettit@nicira.com>
* lib: Do not assume sig_atomic_t is int.Ed Maste2012-06-262-2/+3
| | | | | | | | On FreeBSD sig_atomic_t is long, which causes the comparison in fatal_signal_run to be true when no signal has been reported. Signed-off-by: Ed Maste <emaste@freebsd.org> Signed-off-by: Ben Pfaff <blp@nicira.com>
* ofproto-dpif-governor: Improve performance when most flows get set up.Ben Pfaff2012-06-252-9/+39
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The "flow setup governor" was introduced to avoid the cost of setting up short flows when there are many of them. It works very well for short flows, in fact. However, when the bulk of flows are short, but still long enough to be set up by the governor, we end up with the worst of both worlds: OVS processes the first 5 packets of every flow "by hand" and then it still has to set up a flow. This commit refines the flow setup governor so that, when most of the flows that go through it actually get set up, it in turn starts setting up most flows at the first packet. When it does this, it continues to sample a small fraction of the flows in the governor's usual manner, so that if the behavior changes it can react to it. This increases netperf TCP_CRR transactions per second by about 25% in my test setup, without affecting "ovs-benchmark rate" performance. (I found that to get relatively stable performance for TCP_CRR, regardless of whether Open vSwitch or any kind of bridging was involved, I had to pin the netperf processes on each side of the link to a single core. I found that my NIC's interrupts were already pinned. Thanks to Luca Giraudo <lgiraudo@nicira.com> for these hints.) Bug #12080. Reported-by: Gurucharan Shetty <gshetty@nicira.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
* ofp-util: Avoid use-after-free in ofputil_encode_flow_mod().Ben Pfaff2012-06-251-1/+1
| | | | | | | | | nx_put_match() can reallocate the ofpbuf's data so we need to reload the pointer. Found by inspection. Signed-off-by: Ben Pfaff <blp@nicira.com>
* dpif-linux: Zero 'stats' outputs of dpif_operate() ops on failure.Ben Pfaff2012-06-251-10/+24
| | | | | | | | | | | | | | | | | | | | | | | | When DPIF_OP_FLOW_PUT or DPIF_OP_FLOW_DEL operations failed, they left their 'stats' outputs uninitialized. For DPIF_OP_FLOW_DEL, this meant that the caller would read indeterminate data: Conditional jump or move depends on uninitialised value(s) at 0x805C1EB: subfacet_reset_dp_stats (ofproto-dpif.c:4410) by 0x80637D2: expire_batch (ofproto-dpif.c:3471) by 0x8066114: run (ofproto-dpif.c:3513) by 0x8059DF4: ofproto_run (ofproto.c:1035) by 0x8052E17: bridge_run (bridge.c:2005) by 0x8053F74: main (ovs-vswitchd.c:108) It's unusual for a delete operation to fail. The most common reason is an administrator running "ovs-dpctl del-flows". The only user of DPIF_OP_FLOW_PUT did not request stats, so this doesn't fix an actual bug for that case. Bug #11797. Reported-by: James Schmidt <jschmidt@nicira.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
* ofproto-dpif-governor: Wake up only when there is genuinely work to do.Ben Pfaff2012-06-201-1/+3
| | | | | | | | | | | | | | | | | Until now, governor_wait() has awakened the poll loop whenever the generation timer expires, to allow it to shrink the governor to the next smaller size in governor_run(). However, if the governor is already the smallest possible size, then governor_run() will not have anything to do and will not restart the timer, which means that governor_wait() will again immediately wake up the poll loop, and we end up using 100% CPU. This is kind of hard to trigger because normally the client will destroy a governor in such a case. However, if there are too many subfacets, the client will keep even a minimum-size governor, triggering the bug. Bug #12106. Reported-by: Alex Yip <alex@nicira.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
* debian: Make DKMS automatically build for running kernel.Ben Pfaff2012-06-192-0/+3
| | | | | | | | | | | | By default DKMS doesn't build on demand for each kernel booted or updated. Adding AUTOINSTALL=yes gives it this behavior. Based on a small sample of Debian packages and how-to guides for Ubuntu, AUTOINSTALL=yes is what most packages use and what users expect. Fix-suggested-by: Kirill Kabardin Reported-by: Ralf Heiringhoff <ralf@frosty-geek.net> Reported-at: https://bugs.launchpad.net/bugs/962189 Signed-off-by: Ben Pfaff <blp@nicira.com>
* vlog: Avoid use-after-free in corner case.Ben Pfaff2012-06-131-1/+8
| | | | | | Found by valgrind. Signed-off-by: Ben Pfaff <blp@nicira.com>
* datapath: Check currect return value from skb_gso_segment()Pravin B Shelar2012-06-121-2/+2
| | | | | | | | | Fix return check typo. Signed-off-by: Pravin B Shelar <pshelar@nicira.com> Acked-by: Jesse Gross <jesse@nicira.com> Bug #11933
* dpif-netdev: Fix use-after-free in dpif_netdev_recv.Ben Pfaff2012-06-091-1/+1
| | | | | | Found by valgrind. Signed-off-by: Ben Pfaff <blp@nicira.com>
* datapath: Fix use-after-free bug in dp_notify.Pravin B Shelar2012-06-071-2/+3
| | | | | | | | dp_notify, in unregister case, is accessing vport after detaching it. Following patch fixes it. Signed-off-by: Pravin B Shelar <pshelar@nicira.com> Acked-by: Jesse Gross <jesse@nicira.com>
* ofproto: Fix use after free in ofoperation_complete().Ethan Jackson2012-06-071-0/+1
| | | | | | | | | | In one edge case, ofoperation_complete() destroys its rule, without updating its ofoperation that the rule is gone. Later in the same function, ofoperation_destroy() attempts to modify the rule which already destroyed. Bug #11797. Signed-off-by: Ethan Jackson <ethan@nicira.com>
* Set dates for release of 1.5.0.Justin Pettit2012-06-012-2/+2
| | | | Signed-off-by: Justin Pettit <jpettit@nicira.com>
* NEWS: Move learning timeout changes to 1.5.0 section.Justin Pettit2012-06-011-2/+2
| | | | | | | Changes to the default MAC learning timeout and making it configurable were added in 1.5.0, not 1.6.0. Signed-off-by: Justin Pettit <jpettit@nicira.com>
* ofp-util: Clean up cookie handling.Justin Pettit2012-05-2912-69/+266
| | | | | | | | | | | | | | | | | | | | | | | Commit e72e793 (Add ability to restrict flow mods and flow stats requests to cookies.) modified cookie handling. Some of its behavior was unintuitive and there was at least one bug (described below). Commit f66b87d (DESIGN: Document uses for flow cookies.) attempted to document a clean design for cookie handling. This commit updates the DESIGN document and brings the implementation in line with it. In commit e72e793, the code that handled processing OpenFlow flow modification requests set the cookie mask to exact-match. This seems reasonable for adding flows, but is not correct for matching, since OpenFlow 1.0 doesn't support matching based on the cookie. This commit changes to cookie mask to fully wildcarded, which is the correct behavior for modifications and deletions. It doesn't cause any problems for flow additions, since the mask is ignored for that operation. Bug #9742 Reported-by: Luca Giraudo <lgiraudo@nicira.com> Reported-by: Paul Ingram <paul@nicira.com> Signed-off-by: Justin Pettit <jpettit@nicira.com>
* datapath: Avoid system freeze due to ovs-flow-rehash softlockup.Pravin B Shelar2012-05-232-11/+4
| | | | | | | | | | | | | | | | | | | | OVS datapath does periodic flow table rehash which takes genl_lock in workq context. In some cases, like ports add or delete, genl_lock can cause softlockup as vswitchd would take and succeed with genl_lock and rehash workq would block on the lock. Eventually rehash will proceed, flow rehash is low priority task so this is not problem for rehashing. But it is blocking workq thread; some other workq item from other kernel subsystem would be blocked and can cause system freeze. To avoid workq blocking and system freeze, we can use OVS compat workq. It runs in separate kernel thread thus does not block any non-ovs deferred workq work item. We will fix it by making genetlink lockless and having fine granular locking in OVS. Signed-off-by: Pravin B Shelar <pshelar@nicira.com> Acked-by: Jesse Gross <jesse@nicira.com>
* bridge: Ignore "null" interfaces as required.Ethan Jackson2012-05-211-2/+3
| | | | | | | | | | Commit bae7208e91a0 (bridge: Refactor bridge_reconfigure().) introduced a regression in which the switch would attempt to instantiate "null" interfaces in the datapath. This would, of course, fail and trigger a warning. Though harmless, these warnings confused users. Signed-off-by: Ethan Jackson <ethan@nicira.com>
* ofproto-dpif-governor: Fix bug in log message.Ben Pfaff2012-05-221-1/+1
| | | | Signed-off-by: Ben Pfaff <blp@nicira.com>
* Fix typo in "PYTHONPATH".Ben Pfaff2012-05-221-1/+1
| | | | | Reported-by: Justin Pettit <jpettit@nicira.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
View Lorry Controller Status