summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
| * ovsdb-idl: Document that the IDL always presents a consistent view.Ben Pfaff2015-06-112-1/+6
| | | | | | | | | | | | | | We've had this question a couple of times so we might as well document it. Requested-by: Saurabh Shrivastava (सौरभ श्रीवास्तव) <saurabh@gmail.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
| * datapath-windows: Stateless TCP Tunnelling protocol - Initial implementationEitan Eliahu2015-06-1114-65/+634
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change include an initial implementable of STT. The following should be added: [1] Checksum offload (SW and HW) [2] LSO (SW and HW) [3] IP layer WFP callout for IP segments Added support for multiple (per TCP port) STT ports Testing: link layer connection through ping works. File transfer. Signed-off-by: Eitan Eliahu <eliahue@vmware.com> Co-authored-by: Saurabh Shah <ssaurabh@vmware.com> Signed-off-by: Saurabh Shah <ssaurabh@vmware.com> Acked-by: Nithin Raju <nithin@vmware.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
| * datapath-windows: Correctly complete the original NBL with multiple NBsSorin Vinturis2015-06-111-2/+3
| | | | | | | | | | | | | | | | | | | | | | OvsCreateNewNBLsFromMultipleNBs function failed to correctly complete the original NBL with multiple NBs after creating multiple NBLs with single NB. Signed-off-by: Sorin Vinturis <svinturis@cloudbasesolutions.com> Acked-by: Eitan Eliahu <eliahue@vmware.com> Acked-by: Nithin Raju <nithin@vmware.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
| * netdev-vport: Mark netdev_vport_get_dpif_port() as OVS_WARN_UNUSED_RESULT.Ben Pfaff2015-06-111-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | Ignoring the result of this function means that the caller is quite likely blindly using the character array passed in, instead of the return value, which leads to latent bugs. This would have prevented one of the bugs fixed by commit "tunneling: Fix a tunnel name display bug". CC: Andy Zhou <azhou@nicira.com> Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Andy Zhou <azhou@nicira.com>
| * classifier: Support table versioningJarno Rajahalme2015-06-109-195/+347
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch allows classifier rules to become visible and invisible in specific versions. A 'version' is defined as a positive monotonically increasing integer, which never wraps around. The new 'visibility' attribute replaces the prior 'to_be_removed' and 'visible' attributes. When versioning is not used, the 'version' parameter should be passed as 'CLS_MIN_VERSION' when creating rules, and 'CLS_MAX_VERSION' when looking up flows. This feature enables the support for atomic OpenFlow bundles without significant performance penalty on 64-bit systems. There is a performance decrease in 32-bit systems due to 64-bit atomics used. Signed-off-by: Jarno Rajahalme <jrajahalme@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>
| * ovs-ofctl: Add bundle support and unit testing.Jarno Rajahalme2015-06-1014-49/+807
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | All existing ovs-ofctl flow mod commands now take an optional '--bundle' argument, which executes the flow mods as a single transaction. OpenFlow 1.4+ is implicitly assumed when '--bundle' is specified. ovs-ofctl 'add-flow' and 'add-flows' commands now accept flow specifications that start with an optional 'add', 'modify', 'delete', 'modify_strict', or 'delete_strict' keyword, so that arbitrary flow table modifications may be specified. For backwards compatibility, a missing keyword is treated as an 'add'. With the new '--bundle' option all the modifications are executed as a single transaction using an OpenFlow 1.4 bundle. OpenFlow 1.4 requires bundles to support at least flow and port mods. This implementation does not yet support port mods in bundles. Another restriction is that the atomic transactions are not yet supported. Signed-off-by: Jarno Rajahalme <jrajahalme@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>
| * ofproto: Rename *_begin functions as *_start.Jarno Rajahalme2015-06-101-19/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Weirdest things can bother you at night when you try to sleep ;-) Now we have function triples such as add_flow_begin(), add_flow_finish(), and add_flow_revert(), where a modification is started in *_begin(), which can fail, and when successful can be either made permanent with *_finish(), or cancelled with *_revert(). Linguistically it should be either "begin/end" or "start/finish", not "begin/finish". "begin/end" has some C++ STL baggage, so let's go with "start/finish". IMO "revert" rhymes with it, too. Signed-off-by: Jarno Rajahalme <jrajahalme@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>
| * debian: Remove obsolete manual setting of CFLAGS and warnings from rules.Ben Pfaff2015-06-101-8/+1
| | | | | | | | | | | | | | | | Setting CFLAGS by hand before invoking dpkg-buildflags is ineffective, because dpkg-buildflags overrides it. Reported-by: Andrey Korolyov <andrey@xdel.ru> Signed-off-by: Ben Pfaff <blp@nicira.com>
| * configure: Stop avoiding -Wformat-zero-length.Ben Pfaff2015-06-106-31/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Debian likes to enable -Wformat-zero-length, even over our code trying to disable it. It isn't too hard to make our code warning-free against this option, so this commit both stops disabling it and fixes the warnings. The first fix is to change set_subprogram_name() to take a plain string instead of a format string, and to adjust its few callers. This fixes one warning since one of those callers passed in an empty string. The second fix is to remove a test for ovs_scan() against an empty string. I couldn't find a way to avoid a warning for this test, and it isn't too valuable in any case. This allows us to drop filtering for -Wformat from the Debian rules file, so this commit removes it. Signed-off-by: Ben Pfaff <blp@nicira.com>
| * types: Rename and move ovs_u128_equal().Joe Stringer2015-06-096-12/+13
| | | | | | | | | | | | | | | | This function doesn't need to be exported in the public OVS headers, and it had an inconsistent name compared to uuid_equals(). Rename and move. Signed-off-by: Joe Stringer <joestringer@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>
| * odp-util: Reuse UUID marshalling for UFID.Joe Stringer2015-06-094-29/+13
| | | | | | | | | | | | | | | | | | Unique flow identifiers are really a UUID of sorts, so it makes sense to reuse the UUID string representations for UFID. Suggested-by: Ben Pfaff <blp@nicira.com> Signed-off-by: Joe Stringer <joestringer@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>
| * dpif: Always generate RFC4122 UUIDs for UFID.Joe Stringer2015-06-093-0/+9
| | | | | | | | | | | | | | | | | | | | | | This patch sacrifices a few bits of hash quality from the 128-bit unique flow identifiers to make the UFIDs RFC4122-conformant as per the version 4 (random) UUID spec. Given that the 128-bit space is already quite large, this should not affect the spread of UFIDs in any meaningful way for hashing. Signed-off-by: Joe Stringer <joestringer@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>
| * ofp-parse: Use F_OUT_PORT when parsing.Jarno Rajahalme2015-06-092-5/+5
| | | | | | | | | | | | | | | | | | | | | | We set this field flag for the cases when an out_port should be parsed, but failed to make use of it. Two test cases needed to be updated due to use of out_port in flow add, while out_port is legal for flow deletes only. Suggested-by: Ben Pfaff <blp@nicira.com> Signed-off-by: Jarno Rajahalme <jrajahalme@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>
| * odp-util: Simplify parsing function for GCC.Jarno Rajahalme2015-06-091-6/+2
| | | | | | | | | | | | | | | | | | GCC 4.7.2 -O3 flagged potential use before initialization for the 'id' and 'id_mask' being scanned in scan_vxlan_gbp(). For the 'id' this was a real possiblity, but for the 'id_mask' it seems to be a false positive in gcc analysis. Simplify scan_vxlan_gbp() to fix this. Signed-off-by: Jarno Rajahalme <jrajahalme@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>
| * ofproto: Fix memory leak in ofproto_rule_delete().Jarno Rajahalme2015-06-091-1/+6
| | | | | | | | | | | | | | | | | | | | | | Commit 401aa90e33be (ofproto: Fix memory leak in flow deletion.) fixed the memory leak when a rule is deleted, but failed to do the same when all rules in a bridge are deleted just before the bridge itself is deleted. This patch adds the necessary unref to ofproto_rule_delete(). Signed-off-by: Jarno Rajahalme <jrajahalme@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>
| * flow: Add 'const' qualifiers in flow extraction.Ben Pfaff2015-06-081-9/+9
| | | | | | | | | | Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Daniele Di Proietto <diproiettod@vmware.com>
| * ovsdb-monitor: add json cacheAndy Zhou2015-06-083-24/+103
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Although multiple jsonrpc monitors can share the same ovsdb monitor, each change still needs to translated into json object from scratch. This can be wasteful if multiple jsonrpc monitors are interested in the same changes. Json cache improves this by keeping an copy of json object generated for transaction X to current transaction. When jsonrpc is interested in a change, the cache is searched first, if an json object is found, a copy of it is handed back, skipping the regeneration process. Any commit to the monitor will empty the cache. This can be further optimized to not throw away the cache if the updated tables and columns are not being monitored. Signed-off-by: Andy Zhou <azhou@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>
| * ovsdb-monitor: allow multiple jsonrpc monitors to share a single ovsdbAndy Zhou2015-06-083-15/+141
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | monitor Store ovsdb monitor in a global hmap. If a newly created ovsdb monitor object monitors the same tables and columns as an existing one, the existing monitor will be reused. With this patch, jsonrpc monitor and ovsdb monitor now have N:1 mapping. The goals are to: 1) Reduce the cost of maintaining duplicated monitors. 2) Allow for create Json cache for the same updates. Json cache will be introduced in the following patch. Signed-off-by: Andy Zhou <azhou@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>
| * ovsdb-monitor: refactor ovsdb_monitor_create()Andy Zhou2015-06-081-5/+12
| | | | | | | | | | | | | | | | Add ovsdb_monitor_add_jsonrpc_monitor(). This change will allow ovsdb_monitor to be reference counted. Signed-off-by: Andy Zhou <azhou@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>
| * tunneling: Fix a tunnel name display bugAndy Zhou2015-06-082-6/+16
| | | | | | | | | | | | | | | | | | | | | | | | Currently, 'ovs-appctl tnl/ports/show' command won't display gre port name correctly. Since netdev_vport_get_dpif_port() will not always set the 'namebuf' it receives. Should use the name by its return value instead. Found by inspection. Also extend the test case to cover this command. Signed-off-by: Andy Zhou <azhou@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>
| * ofp-util: Convert flow_metadata to match structure.Jesse Gross2015-06-0813-186/+100
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We have a special flow_metadata structure to represent the parts of a packet that aren't carried in the payload itself. This is used in the case where we need to send the packet as a Packet In to an OpenFlow controller. This is a subset of the more general struct flow. In practice, almost all operations we do on this structure involve converting it to or from a match or have code that is the same as a match. Serialization to NXM and back is done as a match. There is special flow_metadata formatting code that is almost identical to match formatting. The uses for struct flow_metadata aren't performance critical when it comes to memory, so we can save quite a bit of code by just using a match structure directly instead. In addition, as metadata increases and becomes more complex (Geneve options require some special handling beyond just additional fields), using the match structure means we only have to do this work in one place. Signed-off-by: Jesse Gross <jesse@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>
| * This commit adds the windows installer to the OVS tree.Alin Gabriel Serdean2015-06-0728-41/+1493
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Requirements are the following: Visual Studio Community 2013 WiX Toolset 3.9 Microsoft_VC120_CRT_x86.msm More detailed information on the requirements and build instructions can be found under: https://github.com/cloudbase/ovs-windows-installer/blob/master/README.rst To run and make the installer issue the following: ./boot.sh ./configure CC=./build-aux/cccl LD="`which link`" \ LIBS="-lws2_32 -liphlpapi" --prefix="C:/openvswitch/usr" \ --localstatedir="C:/openvswitch/var" --sysconfdir="C:/openvswitch/etc" \ --with-pthread="C:/pthread" --with-vstudiotarget="Release" make clean && make -j16 windows_installer To uninstall one could use the following Powershell commandlets: $app = Get-WmiObject -Class Win32_Product | Where-Object ` { $_.Name -match "Open Vswitch" } $app.Uninstall() Signed-off-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com> Co-authored-by: Alessandro Pilotti <apilotti@cloudbasesolutions.com> Signed-off-by: Alessandro Pilotti <apilotti@cloudbasesolutions.com> Signed-off-by: Gurucharan Shetty <gshetty@nicira.com>
| * tests: Fix unit test failure.Alex Wang2015-06-071-2/+2
| | | | | | | | | | | | | | | | This commit fixes unit test failure caused by commit f171fa8 (odp-util: Make sure vlan tci mask has exact match for VLAN_CFI.). Signed-off-by: Alex Wang <alexw@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>
| * ovs-appctl-bashcomp: bash_completion shouldn't modify user environment.Zang MingJie2015-06-071-4/+1
| | | | | | | | | | Signed-off-by: Zang MingJie <zealot0630@gmail.com> Acked-by: Alex Wang <alexw@nicira.com>
| * odp-util: Make sure vlan tci mask has exact match for VLAN_CFI.Alex Wang2015-06-072-0/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | OVS datapath has check which prevents the installation of flow that matches VLAN TCI but does not have exact match for VLAN_CFI bit. To follow this rule, ovs userspace must make sure the flow key for datapath flow matching VLAN TCI has exact match for VLAN_CFI bit. Before this commit, this is not enforced, so OpenFlow flow like "vlan_tci=0x000a/0x0fff,action=output:local" can generate datapath flow like "vlan(vid=10/0xfff,pcp=0/0x0,cfi=1/0)". With the OVS datapath check, the installation of such datapath flow will be rejected with: "|WARN|system@ovs-system: failed to put[create][modify] (Invalid argument)" This commit makes ovs userspace always exact match the VLAN_CFI bit if the flow matches VLAN TCI. Reported-by: Ronald Lee <ronaldlee@vmware.com> Signed-off-by: Alex Wang <alexw@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com> Acked-by: Jarno Rajahalme <jrajahalme@nicira.com>
| * Add support functions for 8021.ad push and pop vlan.Thomas F. Herbert2015-06-074-5/+13
| | | | | | | | | | | | | | | | Changes to allow the tpid to be specified and all vlan tpid checking to be generalized. Signed-off-by: Thomas F Herbert <thomasfherbert@gmail.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
| * ofproto-dpif: Use xzalloc instead of xmalloc.Sabyasachi Sengupta2015-06-051-3/+3
| | | | | | | | | | | | | | | | | | Use xzalloc instead of xmalloc for some key structure allocations in ofproto-dpif (viz. ofproto_dpif, ofport_dpif and rule_dpif) so as to prevent uninitialized values in these structures. Signed-off-by: Sabyasachi Sengupta <sabyasachi.sengupta@alcatel-lucent.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
| * ofproto-dpif: Avoid creating OpenFlow ports for duplicate tunnels.Ben Pfaff2015-06-054-9/+22
| | | | | | | | | | | | | | | | | | | | | | | | Until now, when two tunnels had an identical configuration, both of them were assigned OpenFlow ports, but only one of those OpenFlow ports was functional. With this commit, only one of the two (or more) identically configured tunnels will be assigned an OpenFlow port number. Reported-by: Keith Holleman <hollemanietf@gmail.com> Signed-off-by: Ben Pfaff <blp@nicira.com> Co-authored-by: Andy Zhou <azhou@nicira.com> Signed-off-by: Andy Zhou <azhou@nicira.com>
| * appveyor: Add a newer ssl link.Gurucharan Shetty2015-06-051-3/+3
| | | | | | | | | | | | | | The older version is no longer available for download. Signed-off-by: Gurucharan Shetty <gshetty@nicira.com> Acked-by: Alin Serdean <aserdean@cloudbasesolutions.com>
| * Link library updates for appveyorAlin Serdean2015-06-051-1/+1
| | | | | | | | | | | | | | Add the library iphlpapi to the appveyor.yml build script. Signed-off-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com> Signed-off-by: Gurucharan Shetty <gshetty@nicira.com>
| * ovs-vswitchd: Update documentationMijo Safradin2015-06-051-4/+5
| | | | | | | | | | | | | | | | Commit 7a6cf343a410d77e05ebd7bf5b5ade52803879ae raised the MAXFD limit from 7500 to 65535. Signed-off-by: Mijo Safradin <mijo@linux.vnet.ibm.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
| * dpif-netdev: Fix non-pmd thread queue id.Daniele Di Proietto2015-06-031-5/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Non pmd threads have a core_id == UINT32_MAX, while queue ids used by netdevs range from 0 to the number of CPUs. Therefore core ids cannot be used directly to select a queue. This commit introduces a simple mapping to fix the problem: pmd threads continue using queues 0 to N (where N is the number of CPUs in the system), while non pmd threads use queue N+1. Fixes: d5c199ea7ff7 ("netdev-dpdk: Properly support non pmd threads.") Reported-by: 차은호 <eunho.cha@atto-research.com Signed-off-by: Daniele Di Proietto <diproiettod@vmware.com> Signed-off-by: Mark D. Gray <mark.d.gray@intel.com> Signed-off-by: Ethan Jackson <ethan@nicira.com> Acked-by: Flavio Leitner <fbl@redhat.com> Acked-by: Ethan Jackson <ethan@nicira.com>
| * Update my email addressYAMAMOTO Takashi2015-06-031-1/+1
| | | | | | | | | | Signed-off-by: YAMAMOTO Takashi <yamamoto@midokura.com> Acked-by: Justin Pettit <jpettit@nicira.com>
| * lib/util.c: style fixesAndy Zhou2015-06-021-5/+5
| | | | | | | | | | | | | | Covert tabs into spaces. Found by inspection. Signed-off-by: Andy Zhou <azhou@nicira.com> Acked-by: Jesse Gross <jesse@nicira.com>
| * metaflow: Convert hex parsing to use new utility functions.Jesse Gross2015-06-012-47/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | We now have functions that can do parsing and printing of long hex strings, so we should use them for meta flow fields to ensure consistent behavior. Since these functions can handle infinitely long strings, we can also increase the maximum field size for MFS_HEXADECIMAL types to the limit allowed by NXM/OXM. This is useful for future large fields, such as Geneve options. Signed-off-by: Jesse Gross <jesse@nicira.com> Acked-by: Andy Zhou <azhou@nicira.com>
| * ofproto: Add support for reverting flow mods and bundle commit.Jarno Rajahalme2015-06-016-200/+313
| | | | | | | | Signed-off-by: Jarno Rajahalme <jrajahalme@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>
| * ofproto: Split delete_flow*().Jarno Rajahalme2015-06-011-14/+65
| | | | | | | | Signed-off-by: Jarno Rajahalme <jrajahalme@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>
| * ofproto: Split modify_flows().Jarno Rajahalme2015-06-011-36/+78
| | | | | | | | Signed-off-by: Jarno Rajahalme <jrajahalme@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>
| * ofproto: Split add_flow().Jarno Rajahalme2015-06-011-89/+122
| | | | | | | | | | | | | | | | | | | | | | Split add_flow() to add_flow_begin() which does all the error checking, and add_flow_finish() which can not fail. Since we still want to send an error response for an unknown 'buffer_id', send_buffered_packet() now send the error response itself. Signed-off-by: Jarno Rajahalme <jrajahalme@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>
| * ofproto: Refactor modify_flows__().Jarno Rajahalme2015-06-011-130/+181
| | | | | | | | Signed-off-by: Jarno Rajahalme <jrajahalme@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>
| * ofproto: Use enum ofperr for 'error'.Jarno Rajahalme2015-06-012-15/+13
| | | | | | | | | | | | Clean up error return types and related comments. Signed-off-by: Jarno Rajahalme <jrajahalme@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>
| * ofproto: Factor out ofproto_rule_create().Jarno Rajahalme2015-06-011-37/+59
| | | | | | | | | | | | Makes add_flow() easier to read and understand. Signed-off-by: Jarno Rajahalme <jrajahalme@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>
| * ofproto: Factor out ofproto_rule_insert__().Jarno Rajahalme2015-06-011-8/+21
| | | | | | | | | | | | Pairs well with ofproto_rule_remove__(). Signed-off-by: Jarno Rajahalme <jrajahalme@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>
| * bundles: Manage bundles in connmgr.Jarno Rajahalme2015-06-014-94/+98
| | | | | | | | | | | | This will make implementing bundle commit in ofproto.c easier. Signed-off-by: Jarno Rajahalme <jrajahalme@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>
| * bundles: Validate bundled messages.Jarno Rajahalme2015-06-016-40/+107
| | | | | | | | | | | | | | | | OpenFlow bundle messages should be decoded and validated at the time they are added to the bundle. This commit does this for flow mod and port mod messages. Signed-off-by: Jarno Rajahalme <jrajahalme@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>
| * classifier: Support duplicate rules.Jarno Rajahalme2015-06-012-59/+137
| | | | | | | | | | | | | | | | | | | | | | | | OpenFlow 1.4 bundles are easier to implement when it is possible to mark a rule as 'to_be_removed' and then insert a new, identical rule with the same priority. All but one out of the identical rules must be marked as 'to_be_removed', and the one rule that is not 'to_be_removed' must have been inserted last. Signed-off-by: Jarno Rajahalme <jrajahalme@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>
| * classifier: Add support for invisible flows.Jarno Rajahalme2015-06-015-15/+59
| | | | | | | | | | | | | | This makes it possible to tentatively add flows to the classifier without the datapath seeing them. Signed-off-by: Jarno Rajahalme <jrajahalme@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>
| * ofp-util: Fix xid in ofputil_encode_bundle_add().Jarno Rajahalme2015-06-011-1/+3
| | | | | | | | | | | | Bundle add must use the same xid as the embedded message. Signed-off-by: Jarno Rajahalme <jrajahalme@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>
| * ofproto: Eliminate use of unset error code.Jarno Rajahalme2015-06-011-2/+1
| | | | | | | | Signed-off-by: Jarno Rajahalme <jrajahalme@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>
| * ovsdb-monitor: allow multiple of 'ovsdb_monitor_changes' in each ovsdb ↵Andy Zhou2015-05-291-40/+86
| | | | | | | | | | | | | | monitor table Signed-off-by: Andy Zhou <azhou@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>