summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* vtep: Limit the split elements to 2 (maxsplit + 1)Mark Maglana2015-03-031-1/+1
| | | | | | | | | | This change ensures that we always end up with two elements even if the name of the physical port contains dashes. For example, a binding of "0100-br0-eth1" will be split to ["0100", "br0-eth1"] instead of ["0100", "br0", "eth1"]. Signed-off-by: Mark Maglana <mmaglana@gmail.com> Signed-off-by: Gurucharan Shetty <gshetty@nicira.com>
* AUTHORS: Add Gianluca Merlo as an author.Gurucharan Shetty2015-03-031-0/+1
| | | | Signed-off-by: Gurucharan Shetty <gshetty@nicira.com>
* ovs-docker: check if port is already attached for container/interfaceGianluca Merlo2015-03-031-0/+9
| | | | | | | | Reuse code for determining attached port to prevent ovs-docker to proceed if a port for the given container and interface is already attached. Signed-off-by: Gianluca Merlo <gianluca.merlo@gmail.com> Signed-off-by: Gurucharan Shetty <gshetty@nicira.com>
* ovs-save: Preserve IPv6 link-local address on interface save.Alexey I. Froloff2015-03-031-2/+3
| | | | | | | | | | If IPv6 link-local address is removed from interface, it is unable to receive any IPv6 packets, including Route Advertisements. In save_interface only skip IPv4 "scope link" addresses. Signed-off-by: Alexey I. Froloff <raorn@raorn.name> Signed-off-by: Ben Pfaff <blp@nicira.com>
* ofproto-dpif: Fix UFID typo.Joe Stringer2015-02-271-3/+3
| | | | | | | While UFIDs are technically userspace flow IDs, the canonical name is "unique flow identifiers". Signed-off-by: Joe Stringer <joestringer@nicira.com>
* datapath: Fix masked key serialization.Pravin B Shelar2015-02-271-1/+1
| | | | | | | | Fix typo where mask is used rather than key. Fixes: 74ed7ab9264("openvswitch: Add support for unique flow IDs.") Reported-by: Joe Stringer <joestringer@nicira.com> Signed-off-by: Pravin B Shelar <pshelar@nicira.com>
* datapath: Initialize unmasked key and uid len.Pravin B Shelar2015-02-271-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Flow alloc needs to initialize unmasked key pointer. Otherwise it can crash kernel trying to free random unmasked-key pointer. general protection fault: 0000 [#1] SMP 3.19.0-rc6-net-next+ #457 Hardware name: Supermicro X7DWU/X7DWU, BIOS 1.1 04/30/2008 RIP: 0010:[<ffffffff8111df0e>] [<ffffffff8111df0e>] kfree+0xac/0x196 Call Trace: [<ffffffffa060bd87>] flow_free+0x21/0x59 [openvswitch] [<ffffffffa060bde0>] ovs_flow_free+0x21/0x23 [openvswitch] [<ffffffffa0605b4a>] ovs_packet_cmd_execute+0x2f3/0x35f [openvswitch] [<ffffffffa0605995>] ? ovs_packet_cmd_execute+0x13e/0x35f [openvswitch] [<ffffffff811fe6fb>] ? nla_parse+0x4f/0xec [<ffffffff8139a2fc>] genl_family_rcv_msg+0x26d/0x2c9 [<ffffffff8107620f>] ? __lock_acquire+0x90e/0x9aa [<ffffffff8139a3be>] genl_rcv_msg+0x66/0x89 [<ffffffff8139a358>] ? genl_family_rcv_msg+0x2c9/0x2c9 [<ffffffff81399591>] netlink_rcv_skb+0x3e/0x95 [<ffffffff81399898>] ? genl_rcv+0x18/0x37 [<ffffffff813998a7>] genl_rcv+0x27/0x37 [<ffffffff81399033>] netlink_unicast+0x103/0x191 [<ffffffff81399382>] netlink_sendmsg+0x2c1/0x310 [<ffffffff811007ad>] ? might_fault+0x50/0xa0 [<ffffffff8135c773>] do_sock_sendmsg+0x5f/0x7a [<ffffffff8135c799>] sock_sendmsg+0xb/0xd [<ffffffff8135cacf>] ___sys_sendmsg+0x1a3/0x218 [<ffffffff8113e54b>] ? get_close_on_exec+0x86/0x86 [<ffffffff8115a9d0>] ? fsnotify+0x32c/0x348 [<ffffffff8115a720>] ? fsnotify+0x7c/0x348 [<ffffffff8113e5f5>] ? __fget+0xaa/0xbf [<ffffffff8113e54b>] ? get_close_on_exec+0x86/0x86 [<ffffffff8135cccd>] __sys_sendmsg+0x3d/0x5e [<ffffffff8135cd02>] SyS_sendmsg+0x14/0x16 [<ffffffff81411852>] system_call_fastpath+0x12/0x17 Reported-by: Or Gerlitz <ogerlitz@mellanox.com> Signed-off-by: Pravin B Shelar <pshelar@nicira.com>
* datapath: Add support for unique flow IDs.Joe Stringer2015-02-277-97/+420
| | | | | | | | | | | | | | | | | | | | | | | | | | Previously, flows were manipulated by userspace specifying a full, unmasked flow key. This adds significant burden onto flow serialization/deserialization, particularly when dumping flows. This patch adds an alternative way to refer to flows using a variable-length "unique flow identifier" (UFID). At flow setup time, userspace may specify a UFID for a flow, which is stored with the flow and inserted into a separate table for lookup, in addition to the standard flow table. Flows created using a UFID must be fetched or deleted using the UFID. All flow dump operations may now be made more terse with OVS_UFID_F_* flags. For example, the OVS_UFID_F_OMIT_KEY flag allows responses to omit the flow key from a datapath operation if the flow has a corresponding UFID. This significantly reduces the time spent assembling and transacting netlink messages. With all OVS_UFID_F_OMIT_* flags enabled, the datapath only returns the UFID and statistics for each flow during flow dump, increasing ovs-vswitchd revalidator performance by 40% or more. Signed-off-by: Joe Stringer <joestringer@nicira.com> Acked-by: Pravin B Shelar <pshelar@nicira.com> Signed-off-by: David S. Miller <davem@davemloft.net>
* compat: Add genlmsg_parse() helper function.Joe Stringer2015-02-272-0/+12
| | | | | | | | The first user will be the next patch. Signed-off-by: Joe Stringer <joestringer@nicira.com> Acked-by: Pravin B Shelar <pshelar@nicira.com> Signed-off-by: David S. Miller <davem@davemloft.net>
* datapath: Use sw_flow_key_range for key ranges.Joe Stringer2015-02-271-11/+9
| | | | | | | | These minor tidyups make a future patch a little tidier. Signed-off-by: Joe Stringer <joestringer@nicira.com> Acked-by: Pravin B Shelar <pshelar@nicira.com> Signed-off-by: David S. Miller <davem@davemloft.net>
* datapath: Refactor ovs_flow_tbl_insert().Joe Stringer2015-02-271-7/+14
| | | | | | | | | Rework so that ovs_flow_tbl_insert() calls flow_{key,mask}_insert(). This tidies up a future patch. Signed-off-by: Joe Stringer <joestringer@nicira.com> Acked-by: Pravin B Shelar <pshelar@nicira.com> Signed-off-by: David S. Miller <davem@davemloft.net>
* datapath: Refactor ovs_nla_fill_match().Joe Stringer2015-02-273-40/+46
| | | | | | | | | | | | Refactor the ovs_nla_fill_match() function into separate netlink serialization functions ovs_nla_put_{unmasked_key,mask}(). Modify ovs_nla_put_flow() to handle attribute nesting and expose the 'is_mask' parameter - all callers need to nest the flow, and callers have better knowledge about whether it is serializing a mask or not. Signed-off-by: Joe Stringer <joestringer@nicira.com> Acked-by: Pravin B Shelar <pshelar@nicira.com> Signed-off-by: David S. Miller <davem@davemloft.net>
* test-hash: Remove the check_word_hash() for hash_bytes128_cb.Alex Wang2015-02-272-10/+1
| | | | | | | | | | | | | The original test fails on big-endian system due to the hash function performing not as well when input is uint32_t. In reality, users should only use hash_bytes128() to hash words larger than 128 bits (e.g. struct flow). Besides, we do check the 1-bit set case for 16 128-bit words in following test case. Therefore, the cleanest way to fix the failure in big-endian system seems to be just removing the check_word_hash() test for hash_bytes128_cb. Signed-off-by: Alex Wang <alexw@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>
* test-hash: Refine the check_256byte_hash().Alex Wang2015-02-271-18/+22
| | | | | | | | This commit refines the check_256byte_hash() function by moving some checks to outer loop. Signed-off-by: Alex Wang <alexw@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>
* test-hash: Make check_256byte_hash() test no 1-bits set case.Alex Wang2015-02-261-2/+4
| | | | | | | | | | | The test comment mentions that we will test the no 1-bits set case. So, this commit makes sure that it is tested. Signed-off-by: Alex Wang <alexw@nicira.com> --- PATCH->V2: - explain why calling set_bit128 with i or j == n_bits is okay.
* util: Fix typo in comment.Ben Pfaff2015-02-261-3/+3
| | | | | Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Justin Pettit <jpettit@nicira.com>
* datapath: Fix return of uninitialized variable.Alex Wang2015-02-261-1/+2
| | | | | | | | | | This commit fixes a return of uninitialized variable bug. The bug can cause failures of operations like flow_add. VMware-BZ: #1405810 Signed-off-by: Alex Wang <alexw@nicira.com> Acked-by: Pravin B Shelar <pshelar@nicira.com>
* OpenFlow 1.5 is final, so change OF1.5 draft references to just say OF1.5.Ben Pfaff2015-02-254-12/+12
| | | | | | Reported-by: Jean Tourrilhes <jt@hpl.hp.com> Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Jean Tourrilhes <jt@hpl.hp.com>
* ovsdb: Raise the jsonrpc server session limitAndy Zhou2015-02-241-1/+1
| | | | | | | | | | Raise the connection limit to allow larger number of concurrent ovsdb-server connections. Note, ovsdb-server may not perform well at the new limit. It is rather a prelude to further scaling tests and optimizations. Signed-off-by: Andy Zhou <azhou@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>
* ovsdb: Warn about reaching max session limitAndy Zhou2015-02-241-13/+19
| | | | | | | | | | Without the log message, it was not obvious why ovsdb-server no longer accepts new connections when the session limit was reached. This patch adds a log message to make it obvious. Signed-off-by: Andy Zhou <azhou@nicira.com> Acked-by: Russell Bryant <rbryant@redhat.com> Acked-by: Ben Pfaff <blp@nicira.com>
* FAQ.md: Mention Linux version that first could handle IPFIX flow monitoring.Ben Pfaff2015-02-231-2/+3
| | | | | | | | | I think that the critical commit is commit 4490108b4a5ada (openvswitch: Allow OVS_USERSPACE_ATTR_USERDATA to be variable length.), which first appeared in Linux 3.10. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Romain Lenglet <romain.lenglet@oracle.com>
* stream-tcp: Remove extra initializer in pwindows_pstream_class.Saurabh Shah2015-02-231-1/+0
| | | | | | | | commit c2e3cbaf ("stream: Eliminate pstream_set_dscp().") removed the set_dscp() callback from pstream_class. Signed-off-by: Saurabh Shah <ssaurabh@vmware.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
* ovs-docker: Use a different mechanism to check for commands.Gurucharan Shetty2015-02-232-7/+15
| | | | | | | | | | | | | | Currently, the script uses '--version' option from different commands to check for their availability. uuidgen on Centos6 has been reported not to have the '--version' option causing failure in script invocation. This commit looks for the utilities in $PATH instead. The code is copied from build-aux/dist-docs. Reported-by: Michael J. Smalley <michaeljsmalley@gmail.com> Suggested-by: Ben Pfaff <blp@nicira.com> Signed-off-by: Gurucharan Shetty <gshetty@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>
* ovs-sandbox: Add -d option to run ovsdb-server under GDBAndy Zhou2015-02-222-3/+9
| | | | | Signed-off-by: Andy Zhou <azhou@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>
* ovs-sandbox: Show the running program on xterm's titleAndy Zhou2015-02-221-2/+5
| | | | | | | | | | When debugging multiple programs under GDB, it will be easier to identify xterms with the program name displayed as title. Without this patch, xterms will have the title of "gdb", which is the first program the xterm executes. This change is useful for the next patch. Signed-off-by: Andy Zhou <azhou@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>
* datapath: Account for "openvswitch: Add support for checksums on UDP tunnels."Jesse Gross2015-02-203-4/+12
| | | | | | | | | | | | | | | | | | Upstream commit: openvswitch: Add support for checksums on UDP tunnels. Currently, it isn't possible to request checksums on the outer UDP header of tunnels - the TUNNEL_CSUM flag is ignored. This adds support for requesting that UDP checksums be computed on transmit and properly reported if they are present on receive. Signed-off-by: Jesse Gross <jesse@nicira.com> Signed-off-by: David S. Miller <davem@davemloft.net> Upstream: b8693877 ("openvswitch: Add support for checksums on UDP tunnels.") Signed-off-by: Jesse Gross <jesse@nicira.com> Acked-by: Thomas Graf <tgraf@noironetworks.com> Acked-by: Pravin B Shelar <pshelar@nicira.com>
* datapath: Backport upstream Geneve implementation.Jesse Gross2015-02-205-291/+377
| | | | | | | | | | This resolves the differences between the OVS Geneve implementation and the upstream kernel, particularly in the area of the split between vport-geneve.c and the generic Geneve data plane. Signed-off-by: Jesse Gross <jesse@nicira.com> Acked-by: Thomas Graf <tgraf@noironetworks.com> Acked-by: Pravin B Shelar <pshelar@nicira.com>
* datapath: Account for "udp: Do not require sock in udp_tunnel_xmit_skb"Jesse Gross2015-02-204-19/+20
| | | | | | | | | | | | | | | | | | | | | | Upstream commit: udp: Do not require sock in udp_tunnel_xmit_skb The UDP tunnel transmit functions udp_tunnel_xmit_skb and udp_tunnel6_xmit_skb include a socket argument. The socket being passed to the functions (from VXLAN) is a UDP created for receive side. The only thing that the socket is used for in the transmit functions is to get the setting for checksum (enabled or zero). This patch removes the argument and and adds a nocheck argument for checksum setting. This eliminates the unnecessary dependency on a UDP socket for UDP tunnel transmit. Signed-off-by: Tom Herbert <therbert@google.com> Signed-off-by: David S. Miller <davem@davemloft.net> Upstream: d998f8ef ("udp: Do not require sock in udp_tunnel_xmit_skb") Signed-off-by: Jesse Gross <jesse@nicira.com> Acked-by: Thomas Graf <tgraf@noironetworks.com> Acked-by: Pravin B Shelar <pshelar@nicira.com>
* datapath: Account for "vlan: introduce *vlan_hwaccel_push_inside helpers"Jesse Gross2015-02-202-8/+39
| | | | | | | | | | | | | | | | | Upstream commit: vlan: introduce *vlan_hwaccel_push_inside helpers Use them to push skb->vlan_tci into the payload and avoid code duplication. Signed-off-by: Jiri Pirko <jiri@resnulli.us> Acked-by: Pravin B Shelar <pshelar@nicira.com> Signed-off-by: David S. Miller <davem@davemloft.net> Upstream: 5968250c ("vlan: introduce *vlan_hwaccel_push_inside helpers") Signed-off-by: Jesse Gross <jesse@nicira.com> Acked-by: Thomas Graf <tgraf@noironetworks.com> Acked-by: Pravin B Shelar <pshelar@nicira.com>
* datapath: Use additional common UDP functions for LISP.Jesse Gross2015-02-201-75/+26
| | | | | | | | | LISP can also take advantage of setup_udp_tunnel_sock() and udp_tunnel_xmit_skb() to increase code reuse. Signed-off-by: Jesse Gross <jesse@nicira.com> Acked-by: Thomas Graf <tgraf@noironetworks.com> Acked-by: Pravin B Shelar <pshelar@nicira.com>
* datapath: Account for "vxlan: Refactor vxlan driver to make use of the ↵Jesse Gross2015-02-201-65/+16
| | | | | | | | | | | | | | | | | | | | | | | common UDP tunnel functions." Upstream commit: vxlan: Refactor vxlan driver to make use of the common UDP tunnel functions. Simplify vxlan implementation using common UDP tunnel APIs. Signed-off-by: Andy Zhou <azhou@nicira.com> Signed-off-by: David S. Miller <davem@davemloft.net> Using the upstream functions where available also has the side effect of ensuring that we can use hardware offloads. The GBP changes forced the use of the OVS emulated GSO path on kernels that lack GBP. This resulted in the loss of VXLAN offload on earlier kernels. This restores the offload support (for both GBP and non-GBP VXLAN). Upstream: acbf74a7 ("vxlan: Refactor vxlan driver to make use of the common UDP tunnel functions.") Signed-off-by: Jesse Gross <jesse@nicira.com> Acked-by: Thomas Graf <tgraf@noironetworks.com> Acked-by: Pravin B Shelar <pshelar@nicira.com>
* datapath: Consistently set skb->inner_protocol for tunnels.Jesse Gross2015-02-204-1/+6
| | | | | | | | | | | skb->inner_protocol is used by GSO and TSO for tunnels on new kernels. Since we are setting up packets to be handled by the kernel's GSO and not just our own, we need to initialize this field properly. Signed-off-by: Jesse Gross <jesse@nicira.com> Acked-by: Thomas Graf <tgraf@noironetworks.com> Acked-by: Pravin B Shelar <pshelar@nicira.com>
* datapath: Account for "udp-tunnel: Add a few more UDP tunnel APIs"Jesse Gross2015-02-203-5/+145
| | | | | | | | | | | | | | | | | | | | | | | | Upstream commit: udp-tunnel: Add a few more UDP tunnel APIs Added a few more UDP tunnel APIs that can be shared by UDP based tunnel protocol implementation. The main ones are highlighted below. setup_udp_tunnel_sock() configures UDP listener socket for receiving UDP encapsulated packets. udp_tunnel_xmit_skb() and upd_tunnel6_xmit_skb() transmit skb using UDP encapsulation. udp_tunnel_sock_release() closes the UDP tunnel listener socket. Signed-off-by: Andy Zhou <azhou@nicira.com> Signed-off-by: David S. Miller <davem@davemloft.net> Upstream: 6a93cc90 ("udp-tunnel: Add a few more UDP tunnel APIs") Signed-off-by: Jesse Gross <jesse@nicira.com> Acked-by: Thomas Graf <tgraf@noironetworks.com> Acked-by: Pravin B Shelar <pshelar@nicira.com>
* datapath: Enable OVS GSO to be used up to 3.18 if necessary.Jesse Gross2015-02-2010-170/+165
| | | | | | | | | | | | | | | | | | There are two important GSO tunnel features that were introduced after the 3.12 cutoff for our current out of tree GSO implementation: * 3.16 introduced support for outer UDP checksums. * 3.18 introduced support for verifying hardware support for protocols other than VXLAN. In cases where these features are used, we should use OVS GSO to ensure correct behavior. However, we also want to continue to use kernel GSO or hardware TSO in existing situations. Therefore, this extends the range of kernels where OVS GSO is available to 3.18 and makes it easier to select which one to use. Signed-off-by: Jesse Gross <jesse@nicira.com> Acked-by: Thomas Graf <tgraf@noironetworks.com> Acked-by: Pravin B Shelar <pshelar@nicira.com>
* datapath: Fix net exit.Pravin B Shelar2015-02-202-2/+45
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Open vSwitch allows moving internal vport to different namespace while still connected to the bridge. But when namespace deleted OVS does not detach these vports, that results in dangling pointer to netdevice which causes kernel panic as follows. This issue is fixed by detaching all ovs ports from the deleted namespace at net-exit. BUG: unable to handle kernel NULL pointer dereference at 0000000000000028 IP: [<ffffffffa0aadaa5>] ovs_vport_locate+0x35/0x80 [openvswitch] Oops: 0000 [#1] SMP Call Trace: [<ffffffffa0aa6391>] lookup_vport+0x21/0xd0 [openvswitch] [<ffffffffa0aa65f9>] ovs_vport_cmd_get+0x59/0xf0 [openvswitch] [<ffffffff8167e07c>] genl_family_rcv_msg+0x1bc/0x3e0 [<ffffffff8167e319>] genl_rcv_msg+0x79/0xc0 [<ffffffff8167d919>] netlink_rcv_skb+0xb9/0xe0 [<ffffffff8167deac>] genl_rcv+0x2c/0x40 [<ffffffff8167cffd>] netlink_unicast+0x12d/0x1c0 [<ffffffff8167d3da>] netlink_sendmsg+0x34a/0x6b0 [<ffffffff8162e140>] sock_sendmsg+0xa0/0xe0 [<ffffffff8162e5e8>] ___sys_sendmsg+0x408/0x420 [<ffffffff8162f541>] __sys_sendmsg+0x51/0x90 [<ffffffff8162f592>] SyS_sendmsg+0x12/0x20 [<ffffffff81764ee9>] system_call_fastpath+0x12/0x17 Reported-by: Assaf Muller <amuller@redhat.com> Fixes: 46df7b81454("openvswitch: Add support for network namespaces.") Signed-off-by: Pravin B Shelar <pshelar@nicira.com> Reviewed-by: Thomas Graf <tgraf@noironetworks.com> Signed-off-by: David S. Miller <davem@davemloft.net> Upstream: 7b4577a9da ("openvswitch: Fix net exit"). Acked-by: Andy Zhou <azhou@nicira.com>
* INSTALL.Docker: Fix malformed sentence.Gurucharan Shetty2015-02-201-4/+3
| | | | | | | | While adding support to Github markup language, the sentence had gotten malformed. Signed-off-by: Gurucharan Shetty <gshetty@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>
* userspace: Replace all uses of strncpy() by ovs_strlcpy().Ben Pfaff2015-02-205-16/+17
| | | | | | | | | | strncpy() has a lot of pitfalls. A while back we replaced all its uses by calls to ovs_strlcpy() or ovs_strzcpy(), but some more have crept in. This commit fixes them. Reported-by: Russell Bryant <rbryant@redhat.com> Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Thomas Graf <tgraf@noironetworks.com>
* socket-util: Use correct address family in set_dscp(), instead of guessing.Ben Pfaff2015-02-203-40/+37
| | | | | | | | | | | | | | | | | The set_dscp() function, until now, tried to set the DSCP as IPv4 and as IPv6. This worked OK on Linux, where an ENOPROTOOPT error made it really clear which one was wrong, but FreeBSD uses EINVAL instead, which has multiple meanings and which it therefore seems somewhat risky to ignore. Instead, this commit just tries to set the correct address family's DSCP option. Tested by Alex Wang on FreeBSD 9.3. Reported-by: Atanu Ghosh <atanu@acm.org> Signed-off-by: Ben Pfaff <blp@nicira.com> Co-authored-by: Alex Wang <alexw@nicira.com> Signed-off-by: Alex Wang <alexw@nicira.com> Tested-by: Alex Wang <alexw@nicira.com>
* stream: Eliminate pstream_set_dscp().Ben Pfaff2015-02-2010-85/+25
| | | | | | | | | | | | | | | | This function is really of marginal utility. This commit drops it and makes the existing callers instead open a new pstream with the desired dscp. The ulterior motive here is that the set_dscp() function that actually sets the DSCP on a socket really wants to know the address family (AF_INET vs. AF_INET6). We could plumb that down through the stream code, and that's one reasonable option, but I thought that simply eliminating some calls to set_dscp() where we don't already have the address family handy was another reasonable way to go. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Alex Wang <alexw@nicira.com>
* timeval: Remove duplicate memset().Russell Bryant2015-02-201-1/+0
| | | | | | | | | init_clock begins with a memset of 0 of the full clock struct. This memset at the end of a single struct member just makes extra sure that it's set to 0, which is unnecessary. Signed-off-by: Russell Bryant <rbryant@redhat.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
* FAQ.md: Update LTS release version number from 1.9 to 2.3.Ben Pfaff2015-02-201-1/+1
| | | | | | | | | The 2.3 branch has been the long-term release for a while now, but somehow we forgot to update the FAQ. Reported-by: Kentaro Ebisawa <ebiken.g@gmail.com> Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Gurucharan Shetty <gshetty@nicira.com>
* datapath: Account for "udp: Generic functions to set checksum"Jesse Gross2015-02-204-0/+57
| | | | | | | | | | | | | | | | Upstream commit: udp: Generic functions to set checksum Added udp_set_csum and udp6_set_csum functions to set UDP checksums in packets. These are for simple UDP packets such as those that might be created in UDP tunnels. Signed-off-by: Tom Herbert <therbert@google.com> Signed-off-by: David S. Miller <davem@davemloft.net> Upstream: af5fcba7 ("udp: Generic functions to set checksum") Signed-off-by: Jesse Gross <jesse@nicira.com> Acked-by: Thomas Graf <tgraf@noironetworks.com>
* datapath: Use udp_sock_create() for LISP.Jesse Gross2015-02-201-21/+11
| | | | | | | | Use the common udp_sock_create() for LISP, similar to what was done for VXLAN. Signed-off-by: Jesse Gross <jesse@nicira.com> Acked-by: Thomas Graf <tgraf@noironetworks.com>
* datapath: Account for "vxlan: Call udp_sock_create"Jesse Gross2015-02-201-24/+40
| | | | | | | | | | | | | | | Upstream commit: vxlan: Call udp_sock_create In vxlan driver call common function udp_sock_create to create the listener UDP port. Signed-off-by: Tom Herbert <therbert@google.com> Signed-off-by: David S. Miller <davem@davemloft.net> Upstream: 3ee64f39 ("vxlan: Call udp_sock_create") Signed-off-by: Jesse Gross <jesse@nicira.com> Acked-by: Thomas Graf <tgraf@noironetworks.com>
* datapath: Account for "udp: Add udp_sock_create for UDP tunnels to open ↵Jesse Gross2015-02-204-0/+141
| | | | | | | | | | | | | | | | | | listener socket" Upstream commit: udp: Add udp_sock_create for UDP tunnels to open listener socket Added udp_tunnel.c which can contain some common functions for UDP tunnels. The first function in this is udp_sock_create which is used to open the listener port for a UDP tunnel. Signed-off-by: Tom Herbert <therbert@google.com> Signed-off-by: David S. Miller <davem@davemloft.net> Upstream: 8024e028 ("udp: Add udp_sock_create for UDP tunnels to open listener socket") Signed-off-by: Jesse Gross <jesse@nicira.com> Acked-by: Thomas Graf <tgraf@noironetworks.com>
* datapath: Remove compat vxlan_src_port().Jesse Gross2015-02-202-21/+0
| | | | | | | | | | vxlan_src_port() has been replaced with the more generic udp_flow_src_port() upstream. We already have a backport for this and it is used everywhere where this is needed, so we can remove the dead vxlan_src_port() function. Signed-off-by: Jesse Gross <jesse@nicira.com> Acked-by: Thomas Graf <tgraf@noironetworks.com>
* FAQ: Update VXLAN references from draft to RFC7348Kentaro Ebisawa2015-02-203-5/+5
| | | | | | | VXLAN is now RFC, so we better to change the pointer to it. Signed-off-by: Kentaro Ebisawa <ebiken.g@gmail.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
* ovs-sandbox: Add an option to allow running ovs-vswitchd under gdbAndy Zhou2015-02-193-4/+49
| | | | | | | | | | | It is some times useful to leverage the sandbox facility to experiment and explore the internals of ovs-vswitchd. Since GDB requires console access for user inputs, this patch launch an xterm for GDB, The main terminal continue to run the sub-shell as before. Exiting the sub-shell will also kill the ovs-vswitchd under GDB (but not GDB itself currently) Signed-off-by: Andy Zhou <azhou@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>
* ovsdb-doc: Add license and copyright notice.Ben Pfaff2015-02-191-0/+14
| | | | | | | | | The copyright dates are taken from "git log --follow ovsdb/ovsdb-doc", considering only Nicira authors' changes. (Only one change was from a non-Nicira author anyhow.) Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Thomas Graf <tgraf@noironetworks.com>
* xml2nroff: New program to generate a manpage from XML input.Ben Pfaff2015-02-192-0/+124
| | | | | | | | | I really can't stand nroff syntax. This makes it possible to install nroff but write in a more sensible XML syntax. The following commit adds the first user. Signed-off-by: Ben Pfaff <blp@nicira.com>
View Lorry Controller Status