summaryrefslogtreecommitdiff
path: root/AUTHORS.rst
Commit message (Collapse)AuthorAgeFilesLines
* AUTHORS: Add Yunjian Wang.Ben Pfaff2017-05-311-0/+1
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* netdev-linux: Refactor netdev_linux_send() in forwarding batch packets.Zhenyu Gao2017-05-311-0/+1
| | | | | | | | We don't need to initialize sock,msg and sll before calling sendmsg each time. Just initialize them before the loop, it can reduce cpu cycles. Signed-off-by: Zhenyu Gao <sysugaozhenyu@gmail.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* AUTHORS: Add Daniel Alvarez.Ben Pfaff2017-05-301-0/+1
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* debian: Add SYSTEMCTL_SKIP_REDIRECT to init filesRaymond Burkholder2017-05-301-0/+1
| | | | | | | | | | Current versions of systemd in Debian Stretch use SYSTEMCTL_SKIP_REDIRECT instead of _SYSTEMCTL_SKIP_REDIRECT. Provide both variables in the .init files. Signed-off-by: Raymond Burkholder <ray@oneunified.net> Suggested-by: Guru Shetty <guru@ovn.org> Signed-off-by: Gurucharan Shetty <guru@ovn.org>
* AUTHORS: Correct spelling of Przemyslaw.Ben Pfaff2017-05-191-1/+1
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* AUTHORS: Add PrzemyslawX Szczerbik.Ben Pfaff2017-05-181-0/+1
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* bridge: Fix controller status updateAndy Zhou2017-05-151-0/+1
| | | | | | | | | | | | | When multiple bridges connects to the same controller, the controller status should be maintained separately for each bridge. Current logic pushes status updates only based on the connection string, which is the same across multiple bridges when connecting to the same controller. Report-at: https://mail.openvswitch.org/pipermail/ovs-discuss/2017-May/044412.html Reported-by: Tulio Ribeiro <tribeiro@lasige.di.fc.ul.pt> Signed-off-by: Andy Zhou <azhou@ovn.org> Reviewed-by: Greg Rose <gvrose@8192@gmail.com>
* packets: add compose_nd_raZong Kai LI2017-05-041-0/+1
| | | | | | | | | | | | | | | This patch introduces methods to compose a Router Advertisement (RA) packet, introduces flags for RA. RA packet composed structures against specification in RFC4861. Caller can use compse_nd_ra_with_sll_mtu_opts to compose a RA packet with Source Link-layer Address Option and MTU Option. Caller can use packet_put_ra_prefix_opt to append a Prefix Information Option to a RA packet. Signed-off-by: Zongkai LI <zealokii@gmail.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* ovn: Document limitation in the L3HA planMiguel Angel Ajo2017-05-011-0/+1
| | | | | | | | | | | | | The intergateway monitoring covers host failure well, but it doesn't cover path failure which is a more complicated problem. By this change I don't mean we should implement something to cover path failure right away, but that we should keep the limitation in mind. Signed-off-by: Miguel Angel Ajo <majopela@redhat.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* datapath: openvswitch: Add missing case OVS_TUNNEL_KEY_ATTR_PADKris Murphy2017-04-191-0/+1
| | | | | | | | | | | | | | | | | | | | | openvswitch: Add missing case OVS_TUNNEL_KEY_ATTR_PAD Added a case for OVS_TUNNEL_KEY_ATTR_PAD to the switch statement in ip_tun_from_nlattr in order to prevent the default case returning an error. Fixes: b46f6ded906e ("libnl: nla_put_be64(): align on a 64-bit area") Signed-off-by: Kris Murphy <kriskend@linux.vnet.ibm.com> Acked-by: Joe Stringer <joe@ovn.org> Signed-off-by: David S. Miller <davem@davemloft.net> Upstream: 8f3dbfd79ed9("openvswitch: Add missing case OVS_TUNNEL_KEY_ATTR_PAD") Fixes: f34648187b03 ("datapath: backport: libnl: nla_put_be64(): align on a 64-bit area") Signed-off-by: Andy Zhou <azhou@ovn.org> Acked-by: Joe Stringer <joe@ovn.org>
* datapath: net/openvswitch: Set the ipv6 source tunnel key address attribute ↵Or Gerlitz2017-04-191-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | correctly Upstream commit: net/openvswitch: Set the ipv6 source tunnel key address attribute correctly When dealing with ipv6 source tunnel key address attribute (OVS_TUNNEL_KEY_ATTR_IPV6_SRC) we are wrongly setting the tunnel dst ip, fix that. Fixes: 6b26ba3a7d95 ('openvswitch: netlink attributes for IPv6 tunneling') Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com> Reported-by: Paul Blakey <paulb@mellanox.com> Acked-by: Jiri Benc <jbenc@redhat.com> Acked-by: Joe Stringer <joe@ovn.org> Signed-off-by: David S. Miller <davem@davemloft.net> Upstream: 3d20f1f7bd575 ("net/openvswitch: Set the ipv6 source tunnel key address attribute correctly") Fixes: 8a2d4905a00f ("datapath: Add support for IPv6 tunnels.") Signed-off-by: Andy Zhou <azhou@ovn.org> Acked-by: Joe Stringer <joe@ovn.org>
* datapath: actions: fixed a brace coding style warning.Peter Downs2017-04-191-0/+1
| | | | | | | | | | | | | | Upstream commit: openvswitch: actions: fixed a brace coding style warning Fixed a brace coding style warning reported by checkpatch.pl Signed-off-by: Peter Downs <padowns@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net> Upstream: f1304f7ba398 ("openvswitch: actions: fixed a brace coding style warning") Signed-off-by: Joe Stringer <joe@ovn.org> Signed-off-by: Andy Zhou <azhou@ovn.org>
* compat: ipv6: orphan skbs in reassembly unit.Eric Dumazet2017-04-191-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Upstream commit: ipv6: orphan skbs in reassembly unit Andrey reported a use-after-free in IPv6 stack. Issue here is that we free the socket while it still has skb in TX path and in some queues. It happens here because IPv6 reassembly unit messes skb->truesize, breaking skb_set_owner_w() badly. We fixed a similar issue for IPV4 in commit 8282f27449bf ("inet: frag: Always orphan skbs inside ip_defrag()") Acked-by: Joe Stringer <joe@ovn.org> ================================================================== BUG: KASAN: use-after-free in sock_wfree+0x118/0x120 Read of size 8 at addr ffff880062da0060 by task a.out/4140 page:ffffea00018b6800 count:1 mapcount:0 mapping: (null) index:0x0 compound_mapcount: 0 flags: 0x100000000008100(slab|head) raw: 0100000000008100 0000000000000000 0000000000000000 0000000180130013 raw: dead000000000100 dead000000000200 ffff88006741f140 0000000000000000 page dumped because: kasan: bad access detected CPU: 0 PID: 4140 Comm: a.out Not tainted 4.10.0-rc3+ #59 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Bochs 01/01/2011 Call Trace: __dump_stack lib/dump_stack.c:15 dump_stack+0x292/0x398 lib/dump_stack.c:51 describe_address mm/kasan/report.c:262 kasan_report_error+0x121/0x560 mm/kasan/report.c:370 kasan_report mm/kasan/report.c:392 __asan_report_load8_noabort+0x3e/0x40 mm/kasan/report.c:413 sock_flag ./arch/x86/include/asm/bitops.h:324 sock_wfree+0x118/0x120 net/core/sock.c:1631 skb_release_head_state+0xfc/0x250 net/core/skbuff.c:655 skb_release_all+0x15/0x60 net/core/skbuff.c:668 __kfree_skb+0x15/0x20 net/core/skbuff.c:684 kfree_skb+0x16e/0x4e0 net/core/skbuff.c:705 inet_frag_destroy+0x121/0x290 net/ipv4/inet_fragment.c:304 inet_frag_put ./include/net/inet_frag.h:133 nf_ct_frag6_gather+0x1125/0x38b0 net/ipv6/netfilter/nf_conntrack_reasm.c:617 ipv6_defrag+0x21b/0x350 net/ipv6/netfilter/nf_defrag_ipv6_hooks.c:68 nf_hook_entry_hookfn ./include/linux/netfilter.h:102 nf_hook_slow+0xc3/0x290 net/netfilter/core.c:310 nf_hook ./include/linux/netfilter.h:212 __ip6_local_out+0x52c/0xaf0 net/ipv6/output_core.c:160 ip6_local_out+0x2d/0x170 net/ipv6/output_core.c:170 ip6_send_skb+0xa1/0x340 net/ipv6/ip6_output.c:1722 ip6_push_pending_frames+0xb3/0xe0 net/ipv6/ip6_output.c:1742 rawv6_push_pending_frames net/ipv6/raw.c:613 rawv6_sendmsg+0x2cff/0x4130 net/ipv6/raw.c:927 inet_sendmsg+0x164/0x5b0 net/ipv4/af_inet.c:744 sock_sendmsg_nosec net/socket.c:635 sock_sendmsg+0xca/0x110 net/socket.c:645 sock_write_iter+0x326/0x620 net/socket.c:848 new_sync_write fs/read_write.c:499 __vfs_write+0x483/0x760 fs/read_write.c:512 vfs_write+0x187/0x530 fs/read_write.c:560 SYSC_write fs/read_write.c:607 SyS_write+0xfb/0x230 fs/read_write.c:599 entry_SYSCALL_64_fastpath+0x1f/0xc2 arch/x86/entry/entry_64.S:203 RIP: 0033:0x7ff26e6f5b79 RSP: 002b:00007ff268e0ed98 EFLAGS: 00000206 ORIG_RAX: 0000000000000001 RAX: ffffffffffffffda RBX: 00007ff268e0f9c0 RCX: 00007ff26e6f5b79 RDX: 0000000000000010 RSI: 0000000020f50fe1 RDI: 0000000000000003 RBP: 00007ff26ebc1220 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000206 R12: 0000000000000000 R13: 00007ff268e0f9c0 R14: 00007ff26efec040 R15: 0000000000000003 The buggy address belongs to the object at ffff880062da0000 which belongs to the cache RAWv6 of size 1504 The buggy address ffff880062da0060 is located 96 bytes inside of 1504-byte region [ffff880062da0000, ffff880062da05e0) Freed by task 4113: save_stack_trace+0x16/0x20 arch/x86/kernel/stacktrace.c:57 save_stack+0x43/0xd0 mm/kasan/kasan.c:502 set_track mm/kasan/kasan.c:514 kasan_slab_free+0x73/0xc0 mm/kasan/kasan.c:578 slab_free_hook mm/slub.c:1352 slab_free_freelist_hook mm/slub.c:1374 slab_free mm/slub.c:2951 kmem_cache_free+0xb2/0x2c0 mm/slub.c:2973 sk_prot_free net/core/sock.c:1377 __sk_destruct+0x49c/0x6e0 net/core/sock.c:1452 sk_destruct+0x47/0x80 net/core/sock.c:1460 __sk_free+0x57/0x230 net/core/sock.c:1468 sk_free+0x23/0x30 net/core/sock.c:1479 sock_put ./include/net/sock.h:1638 sk_common_release+0x31e/0x4e0 net/core/sock.c:2782 rawv6_close+0x54/0x80 net/ipv6/raw.c:1214 inet_release+0xed/0x1c0 net/ipv4/af_inet.c:425 inet6_release+0x50/0x70 net/ipv6/af_inet6.c:431 sock_release+0x8d/0x1e0 net/socket.c:599 sock_close+0x16/0x20 net/socket.c:1063 __fput+0x332/0x7f0 fs/file_table.c:208 ____fput+0x15/0x20 fs/file_table.c:244 task_work_run+0x19b/0x270 kernel/task_work.c:116 exit_task_work ./include/linux/task_work.h:21 do_exit+0x186b/0x2800 kernel/exit.c:839 do_group_exit+0x149/0x420 kernel/exit.c:943 SYSC_exit_group kernel/exit.c:954 SyS_exit_group+0x1d/0x20 kernel/exit.c:952 entry_SYSCALL_64_fastpath+0x1f/0xc2 arch/x86/entry/entry_64.S:203 Allocated by task 4115: save_stack_trace+0x16/0x20 arch/x86/kernel/stacktrace.c:57 save_stack+0x43/0xd0 mm/kasan/kasan.c:502 set_track mm/kasan/kasan.c:514 kasan_kmalloc+0xad/0xe0 mm/kasan/kasan.c:605 kasan_slab_alloc+0x12/0x20 mm/kasan/kasan.c:544 slab_post_alloc_hook mm/slab.h:432 slab_alloc_node mm/slub.c:2708 slab_alloc mm/slub.c:2716 kmem_cache_alloc+0x1af/0x250 mm/slub.c:2721 sk_prot_alloc+0x65/0x2a0 net/core/sock.c:1334 sk_alloc+0x105/0x1010 net/core/sock.c:1396 inet6_create+0x44d/0x1150 net/ipv6/af_inet6.c:183 __sock_create+0x4f6/0x880 net/socket.c:1199 sock_create net/socket.c:1239 SYSC_socket net/socket.c:1269 SyS_socket+0xf9/0x230 net/socket.c:1249 entry_SYSCALL_64_fastpath+0x1f/0xc2 arch/x86/entry/entry_64.S:203 Memory state around the buggy address: ffff880062d9ff00: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc ffff880062d9ff80: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc >ffff880062da0000: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb ^ ffff880062da0080: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb ffff880062da0100: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb ================================================================== Reported-by: Andrey Konovalov <andreyknvl@google.com> Signed-off-by: Eric Dumazet <edumazet@google.com> Signed-off-by: David S. Miller <davem@davemloft.net> This patch is a bugfix, and will be progressively backported to earlier kernels. If it is backported to any kernel 4.5 through 4.10, then users use that updated kernel with the OVS kernel module prior to this patch, it could cause a crash. The compat code here resolves such issues. Upstream: 48cac18ecf1d ("ipv6: orphan skbs in reassembly unit") Signed-off-by: Joe Stringer <joe@ovn.org> Signed-off-by: Andy Zhou <azhou@ovn.org> Acked-by: Joe Stringer <joe@ovn.org>
* AUTHORS: Add Greg Rose.Ben Pfaff2017-04-171-0/+1
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* python: Allow tuning the session probe_interval from IDLLucas Alvares Gomes2017-04-131-0/+1
| | | | | | | | | | | | | This patch is adding a new parameter called "probe_interval" to the constructor of the Idl class. This new parameter will be used to tune the database connection probing for that IDL session, some users might want to tune it to be less agressive than the current 5s default in OVS or even disable it. Reported-at: https://bugs.launchpad.net/networking-ovn/+bug/1680146 Signed-off-by: Lucas Alvares Gomes <lucasagomes@gmail.com> Acked-by: Daniel Alvarez <dalvarez@redhat.com> Signed-off-by: Russell Bryant <russell@ovn.org>
* AUTHORS: Add wenxu.Ben Pfaff2017-04-061-0/+1
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* Document how to get Open vSwitch source code.Ben Pfaff2017-03-291-0/+1
| | | | | | Suggested-by: "Nadathur, Sundar" <sundar.nadathur@intel.com> Signed-off-by: Ben Pfaff <blp@ovn.org> Acked-by: Gurucharan Shetty <guru@ovn.org>
* AUTHORS: Add Khem Raj.Ben Pfaff2017-03-201-0/+1
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* debian; Avoid installing ovs-vswitchd.conf.db manpage as "db" language.Ben Pfaff2017-03-171-0/+1
| | | | | | | | | | | Usually, when the name of a manpage has a two-letter extension, it means that the manpage is written in the language designated by that language code. Reported-by: Michael Stapelberg <stapelberg@debian.org> Reported-at: https://bugs.debian.org/850631 Signed-off-by: Ben Pfaff <blp@ovn.org> Tested-by: nickcooper-zhangtonghao <nic@opencloud.tech>
* AUTHORS: Add Xiao Liang.Ben Pfaff2017-03-161-0/+1
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* AUTHORS: Add Mika Väisänen.Joe Stringer2017-03-091-0/+1
| | | | Signed-off-by: Joe Stringer <joe@ovn.org>
* AUTHORS: Add Robert Wojciechowicz.Ben Pfaff2017-03-081-0/+1
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* AUTHORS: Add Tony van der Peet.Ben Pfaff2017-03-081-0/+1
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* packaging: Make Fedora spec file CentOS compatibleLeif Madsen2017-03-081-0/+1
| | | | | | | | | | | On CentOS, the package names aren't prefixed with python2, but rather are prefixed with simply python. This change addresses that and fixes up some documentation that was outdated, and updates the Vagrantfile to use the proper spec file and package names. Fixes: bb1a7ca21107 ("fedora: Add python3-openvswitch split package") Signed-off-by: Leif Madsen <lmadsen@redhat.com> Signed-off-by: Russell Bryant <russell@ovn.org>
* rhel: Add hostname as dependencyJakub Libosvar2017-02-231-0/+1
| | | | | | | | ovs-ctl script uses hostname. This patch adds dependency for rhel systems. Signed-off-by: Jakub Libosvar <libosvar@redhat.com> Signed-off-by: Russell Bryant <russell@ovn.org>
* netdev-dpdk: Fix rx_error stat for dpdk ports.Ian Stokes2017-02-161-0/+1
| | | | | | | | | | | | | | | | | | | "rx_error" stat for a DPDK interface was calculated with the assumption that dropped packets due to hardware buffer overload were counted as errors in DPDK and the rte ierror stat included rte imissed packets i.e. rx_errors = rte_stats.ierrors - rte_stats.imissed This results in negative statistic values as imissed packets are no longer counted as part of ierror since DPDK v.16.04. Fix this by setting rx_errors equal to ierrors only. Fixes: 9e3ddd45 (netdev-dpdk: Add some missing statistics.) CC: Timo Puha <timox.puha@intel.com>) Reported-by: Stepan Andrushko <stepanx.andrushko@intel.com> Signed-off-by: Ian Stokes <ian.stokes@intel.com> Signed-off-by: Daniele Di Proietto <diproiettod@vmware.com>
* dpif-netdev: Conditional EMC insertCiara Loftus2017-02-161-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | Unconditional insertion of EMC entries results in EMC thrashing at high numbers of parallel flows. When this occurs, the performance of the EMC often falls below that of the dpcls classifier, rendering the EMC practically useless. Instead of unconditionally inserting entries into the EMC when a miss occurs, use a 1% probability of insertion. This ensures that the most frequent flows have the highest chance of creating an entry in the EMC, and the probability of thrashing the EMC is also greatly reduced. The probability of insertion is configurable, via the other_config:emc-insert-inv-prob option. This value sets the average probability of insertion to 1/emc-insert-inv-prob. For example the following command changes the insertion probability to (on average) 1 in every 20 packets ie. 1/20 ie. 5%. ovs-vsctl set Open_vSwitch . other_config:emc-insert-inv-prob=20 Signed-off-by: Ciara Loftus <ciara.loftus@intel.com> Signed-off-by: Georg Schmuecking <georg.schmuecking@ericsson.com> Co-authored-by: Georg Schmuecking <georg.schmuecking@ericsson.com> Acked-by: Kevin Traynor <ktraynor@redhat.com> Signed-off-by: Daniele Di Proietto <diproiettod@vmware.com>
* AUTHORS: Add Mickey SpiegelMickey Spiegel2017-02-131-0/+1
| | | | | Signed-off-by: Mickey Spiegel <mickeys.dev@gmail.com> Signed-off-by: Russell Bryant <russell@ovn.org>
* rhel: make openvswitch service start return when readyAlan Pevec2017-02-131-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | In OVS 2.6 openvswitch systemd service was changed to use BindsTo instead of Requires for sub-services but also removed them from After This made main openvswitch service return before sub-services were ready breaking scripts which assumed everything is ready after systemctl start e.g. in OpenStack CI infra [1] is calling ovs-vsctl immediately after service start exposing a race in virtualized CI environment: 2017-02-09T23:11:12.498Z|00007|bridge|INFO|ovs-vswitchd (Open vSwitch) 2.6.1 but ovs-ctl tried to access it few msec too early: 2017-02-09 23:11:12.352493 | ovs-vsctl: unix:/var/run/openvswitch/db.sock: database connection failed (No such file or directory) Solution is to add ordering dependencies, BindsTo/Requires do not ensure it [2] [1] https://github.com/openstack-infra/devstack-gate/blob/c435a724bd257b22a2e39e8e9125c11302a8c81d/functions.sh#L1057-L1078 [2] https://www.freedesktop.org/software/systemd/man/systemd.unit.html#Requires= Fixes: 84ad120 ("rhel: Improved Systemd Integration") Signed-off-by: Alan Pevec <alan.pevec@redhat.com> Acked-by: Aaron Conole <aconole@redhat.com> Signed-off-by: Russell Bryant <russell@ovn.org>
* rhel: Fix dpdk-devel version and dependencies in fedora packagerTimothy Redaelli2017-02-101-0/+1
| | | | | | | | | | Now dpdk-devel >= 16.11 is needed and also libpcap-devel numactl-devel Tested on mock with rawhide chroot and Fedora 23 vagrant machine by using the rawhide dpdk and dpdk-devel packages Signed-off-by: Timothy Redaelli <tredaelli@redhat.com> Signed-off-by: Daniele Di Proietto <diproiettod@vmware.com>
* rhel: Firewall service files for OVN.Marcin Mirecki2017-02-031-0/+1
| | | | | | | | | Firewall service files allowing to open firewalld ports required for running OVN Signed-off-by: Marcin Mirecki <mmirecki@redhat.com> Acked-by: Ben Pfaff <blp@ovn.org> Signed-off-by: Russell Bryant <russell@ovn.org>
* ofproto-dpif: Reduce the time to create many bridges.Sha Zhang2017-01-311-0/+1
| | | | | | | | | | | This patch moves xlate_txn_start() and xlate_txn_commit() out of the loop traversing all the ofproto-dpifs to reduce the time of creating a large mount of bridges in separate database transactions. As a global variable, new_xcfg should only be allocated at the beginning and commited at the end once time, rather than doing it repeatedly in the loop body. Signed-off-by: Sha Zhang <zhangsha.zhang@huawei.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* AUTHORS: Add Roi Dayan.Ben Pfaff2017-01-311-0/+1
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* tnl-neigh-cache: Force revalidation for a new neighbor entry.Ben Pfaff2017-01-201-0/+1
| | | | | | | | | | When a new ARP or ND entry was added, the code failed to force revalidation. This commit fixes the problem. Reported-by: László Sürü <laszlo.suru@ericsson.com> Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2017-January/327788.html Tested-by: László Sürü <laszlo.suru@ericsson.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* AUTHORS: Add Dong Jun.Ben Pfaff2017-01-101-0/+1
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* ovn-nbctl: Specify the range of the tag for "ovn-nbctl lsp-add" command.zhaojingjing2017-01-061-0/+1
| | | | | | | | When configuring the wrong tag for "ovn-nbctl lsp-add" command， it shows "invalid tag". The range of the tag is not known. Signed-off-by: zhaojingjing <zhao.jingjing1@zte.com.cn> Signed-off-by: Ben Pfaff <blp@ovn.org>
* ovsdb-data: Add support for integer ranges in database commandsLukasz Rzasik2017-01-051-0/+1
| | | | | | | | | | | | | | | | Adding / removing a range of integers to a column accepting a set of integers requires enumarating all of the integers. This patch simplifies it by introducing 'range' concept to the database commands. Two integers separated by a hyphen represent an inclusive range. The patch adds positive and negative tests for the new syntax. The patch was tested by 'make check'. Covarage was tested by 'make check-lcov'. Signed-off-by: Lukasz Rzasik <lukasz.rzasik@gmail.com> Suggested-by: <my_ovs_discuss@yahoo.com> Suggested-by: Ben Pfaff <blp@ovn.org> Signed-off-by: Ben Pfaff <blp@ovn.org>
* Python tests: Add winutils.py moduleAlin Balutoiu2017-01-031-0/+1
| | | | | | | | | | | | This patch adds a new python module which contains helper functions. These will be neccessary for the Windows implementation. They cover the following aspects: sockets and namedpipes. Signed-off-by: Alin Balutoiu <abalutoiu@cloudbasesolutions.com> Acked-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions> Signed-off-by: Gurucharan Shetty <guru@ovn.org>
* lacp: Select a may-enable IF as the lead IFBen Pfaff2016-12-231-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | A reboot of one switch in an MC-LAG bond makes all bond links to go down, causing a total connectivity loss for 3 seconds. Packet capture shows that spurious LACP PDUs are sent to OVS with a different MAC address (partner system id) during the final stages of the MC-LAG switch reboot. The current code selects a lead interface based on information in the LACP PDU, regardless of its synchronization state. If a non-synchronized interface is selected as the OVS lead interface then all other interfaces are forced down as their stored partner system id differs and the bond ends up with no working interface. The bond recovers within three seconds after the last spurious message. To avoid the problem, this commit requires a lead interface to be synchronized. In case no synchronized interface exists, the selection of lead interface is done as in the current code. Signed-off-by: Torgny Lindberg <torgny.lindberg@ericsson.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* lib/ovs-thread: set prefer writer lock for ovs_rwlock_init()zangchuanqiang2016-12-221-0/+1
| | | | | | | | | | | | | | An alternative "writer nonrecursive" rwlock allows recursive read-locks to succeed only if there are no threads waiting for the write-lock. In the function ovs_rwlock_init(), there exist a problem, the parameter of 'attr' is not used to set the attributes of ovs_rwlock 'l_', just because use pthread_rwlock_init(&l->lock, NULL) to init l->lock. The attr object needs to be passed to the pthread_rwlock_init() call in order to make use of it. Signed-off-by: zangchuanqiang <zangchuanqiang@huawei.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* ofproto-dpif-xlate: Adding IGMP/MLD checksum verificationEelco Chaudron2016-12-221-0/+1
| | | | | | | | | When IGMP or MLD packets arrive their content is used without the checksum being verified. With this change the checksum is verified, and the packet is not used for multicast snooping on failure. Signed-off-by: Eelco Chaudron <echaudro@redhat.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* ovn: Fix the duplicate code: start) ovsdb_server_start; ;Guoshuai Li2016-12-061-0/+1
| | | | | | In 341 line already have this code Signed-off-by: Ben Pfaff <blp@ovn.org>
* doc: Convert AUTHORS to rSTStephen Finucane2016-11-301-0/+532
Signed-off-by: Stephen Finucane <stephen@that.guru> Signed-off-by: Russell Bryant <russell@ovn.org>
View Lorry Controller Status