summaryrefslogtreecommitdiff
path: root/AUTHORS.rst
Commit message (Collapse)AuthorAgeFilesLines
* AUTHORS: Add Keshav Gupta and Rohith Basavaraja.Ben Pfaff2018-07-061-0/+2
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* AUTHORS: Update email-id of Manohar K C.Manohar K C2018-06-261-1/+1
| | | | | | CC: Manohar K C <manukc@gmail.com> Signed-off-by: Manohar K C <manohar.krishnappa.chidambaraswamy@ericsson.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* AUTHORS: Add Neal Shrader.Ben Pfaff2018-06-261-0/+1
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* AUTHORS: Add Kyle Simpson.Ben Pfaff2018-06-181-0/+1
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* AUTHROS: Add Ivan Dyukov.Ben Pfaff2018-06-141-0/+1
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* python: Update docstring in ovs.db.idl.Idl class.Toms Atteka2018-06-051-0/+1
| | | | | | | | | Adjusted docstring and variable names according to previous code changes; Fixed grammar "a attribute" > "an attribute". Fixes: bf42f674 (idl: Convert python daemons to utilize SchemaHelper) Signed-off-by: Toms Atteka <cpp.code.lv@gmail.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* rstp: Eliminate BPDU padding and uninitialized bytes.Ben Pfaff2018-06-051-0/+1
| | | | | | | | | | | | | | | | When the RSTP implementation sent BPDUs, it failed to initialize some of their bytes. None of the code initialized an array of 7 padding bytes, and some of it also failed to initialize the version1_length field. In addition, the padding bytes confused some implementations that did not correctly ignore extra bytes. This commit fixes both problems, by removing the padding bytes and initializing every byte in outgoing messages. Reported-by: David van Moolenbroek <dvmoolenbroek@aimvalley.nl> Reported-at: https://mail.openvswitch.org/pipermail/ovs-discuss/2018-June/046864.html Tested-by: David van Moolenbroek <dvmoolenbroek@aimvalley.nl> Signed-off-by: Ben Pfaff <blp@ovn.org>
* ofp-flow: Fix uninitialized data decoding OF1.5 flow stats.Ben Pfaff2018-05-231-0/+1
| | | | | | | | Reported-by: Paul Greenberg Reported-at: https://github.com/openvswitch/ovs-issues/issues/149 Fixes: c7b02b800615 ("Add support for OpenFlow 1.5 statistics (OXS).") Signed-off-by: Ben Pfaff <blp@ovn.org> Acked-by: Darrell Ball <dlu998@gmail.com>
* lacp: New command "lacp/show-stats" fordisplaying LACP counters.Nitin Katiyar2018-04-181-0/+1
| | | | | | | | | | | | | | | | | | | | | | Currently OVS does not provide any command to display stats for LACP without which it is difficult to debug LACP issues. Here we propose to display various statistics about LACP PDUs and slave state change. Sample output: ovs_lacp # ovs-appctl lacp/stats-show ---- bond-prv statistics ---- slave: dpdk0: RX PDUs: 128 RX Bad PDUs: 0 TX PDUs: 5 Link Expired: 2 Link Defaulted: 1 Carrier Status Changed: 0 Signed-off-by: Nitin Katiyar <nitin.katiyar@ericsson.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* AUTHORS: Add Andrea Kao.Ben Pfaff2018-04-161-0/+1
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* Fix AUTHORS.rstLucas Alvares Gomes2018-04-111-344/+344
| | | | | | | | | | | | | The commit 9afc6f14ee7b2622703d98689acb0044d4a5492e added a new author which name was too long that broke the column size. Runinng "make docs-checks" was failing because of that. All this patch does is to enlarge the "Name" column to fit the new author's name. Signed-off-by: Lucas Alvares Gomes <lucasagomes@gmail.com> Signed-off-by: Ben Pfaff <blp@ovn.org> Acked-by: Daniel Alvarez <dalvarez@redhat.com>
* AUTHORS: Add Manohar Krishnappa Chidambaraswamy.Ben Pfaff2018-04-101-0/+1
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* AUTHORS: Add aginwala.Ben Pfaff2018-04-041-0/+1
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* AUTHORS: Add Frédéric Tobias Christ.Ben Pfaff2018-04-031-0/+1
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* ofp-flow: Reduce memory consumption for ofputil_flow_mod, using minimatch.Ben Pfaff2018-03-311-0/+1
| | | | | | | | | | | | | | | | | | | | | | | Until now, struct ofputil_flow_mod, which represents an OpenFlow flow table modification request, has incorporated a struct match, which made the overall ofputil_flow_mod about 2.5 kB. This is OK for a small number of flows, but absurdly inflates memory requirements when there are hundreds of thousands of flows. This commit fixes the problem by changing struct match to struct minimatch inside ofputil_flow_mod, which reduces its size to about 100 bytes plus the actual size of the flow match (usually a few dozen bytes). This affects memory usage of ovs-ofctl (when it adds a large number of flows) more than ovs-vswitchd. Reported-by: Michael Ben-Ami <mbenami@digitalocean.com> Signed-off-by: Ben Pfaff <blp@ovn.org> Reviewed-by: Armando Migliaccio <armamig@gmail.com> Tested-by: Armando Migliaccio <armamig@gmail.com> Reviewed-by: Jan Scheurich <jan.scheurich@ericsson.com> Tested-by: Jan Scheurich <jan.scheurich@ericsson.com> Tested-by: Yifeng Sun <pkusunyifeng@gmail.com> Reviewed-by: Yifeng Sun <pkusunyifeng@gmail.com>
* ovsdb-idl: Use modern form of <monitor-requests>.Ben Pfaff2018-03-141-0/+1
| | | | | | | | | | | Long ago, a <monitor-requests> object in the OVSDB protocol mapped a table name to a single <monitor-request>. Since then, it has mapped a table name to an *array of* <monitor-request> objects, but the OVSDB IDL has never been updated to use the modern form. This commit makes that change. Reported-by: Anil Jangam <anilj.mailing@gmail.com> Signed-off-by: Ben Pfaff <blp@ovn.org> Acked-by: Justin Pettit <jpettit@ovn.org>
* AUTHORS: update email address for Mark KavanaghMark Kavanagh2018-02-281-1/+1
| | | | | Signed-off-by: Mark Kavanagh <mark.b.kavanagh@intel.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* ovn-sbctl: Remove incorrect manpage options.Dan Williams2018-02-281-0/+1
| | | | | | | These options are not implemented by ovn-sbctl. Signed-off-by: Dan Williams <dcbw@redhat.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* AUTHORS: update e-mail address of Zoltan BaloghZoltan Balogh2018-02-231-2/+1
| | | | | | Signed-off-by: Zoltan Balogh <zoltan.balogh@ericsson.com> CC: Zoltan Balogh <zoltan.balogh.eth@gmail.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* AUTHORS: Add JunhanYan <juyan@redhat.com>.Ben Pfaff2018-02-011-0/+1
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* AUTHORS: Add Frode Nordahl <frode.nordahl@gmail.com>.Ben Pfaff2018-02-011-0/+1
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* AUTHORS: Add Robert Mulik.Ben Pfaff2018-01-231-0/+1
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* ofproto: Delete all groups and meters when (un)configuring a controller.Ben Pfaff2018-01-081-0/+1
| | | | | | | | | | | | | | Open vSwitch has always deleted all flows from the flow table whenever a controller is configured or whenever all the controllers are unconfigured. After this commit, OVS additionally deletes all OpenFlow groups and meters. Suggested-by: Periyasamy Palanisamy <periyasamy.palanisamy@ericsson.com> Suggested-by: Jan Scheurich <jan.scheurich@ericsson.com> Signed-off-by: Ben Pfaff <blp@ovn.org> Acked-by: Jan Scheurich <jan.scheurich@ericsson.com> Tested-by: Jan Scheurich <jan.scheurich@ericsson.com> Reviewed-by: Greg Rose <gvrose8192@gmail.com> Tested-by: Greg Rose <gvrose8192@gmail.com>
* AUTHORS: Add Brad Cowie.Ben Pfaff2018-01-081-0/+1
|
* AUTHORS: Add Lorenzo Bianconi.Ben Pfaff2018-01-081-0/+1
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* faq: Correct location of flow.h.Ben Pfaff2018-01-021-0/+1
| | | | | | Reported-by: Alan Kayahan <hsykay@gmail.com> Signed-off-by: Ben Pfaff <blp@ovn.org> Reviewed-by: Greg Rose <gvrose8192@gmail.com>
* ofproto: Keep inserting buckets into a group from changing group type.Ben Pfaff2017-12-111-0/+1
| | | | | | | | | | | The "insert buckets" and "delete buckets" operations on a group should not change the group's type or properties, but the implementation did this by mistake. This fixes the problem. Reported-by: shivani dommeti <shivani.dommeti@gmail.com> Tested-by: shivani dommeti <shivani.dommeti@gmail.com> Reported-at: https://mail.openvswitch.org/pipermail/ovs-discuss/2017-December/045830.html Signed-off-by: Ben Pfaff <blp@ovn.org>
* AUTHORS: Update email address for Thadeu Lima de Souza Cascardo.Ben Pfaff2017-12-081-1/+1
| | | | | Signed-off-by: Ben Pfaff <blp@ovn.org> Acked-by: Thadeu Lima de Souza Cascardo <cascardo@cascardo.eti.br>
* AUHTORS: Add Vishal Deep Ajmera.Ben Pfaff2017-11-201-0/+1
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* netdev, dpif: fix the crash/assert on port deleteAshish Varma2017-11-131-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | a crash is seen in "netdev_ports_remove" when an interface is deleted and added back in the system and when the interface is part of a bridge configuration. e.g. steps: create a tap0 interface using "ip tuntap add.." add the tap0 interface to br0 using "ovs-vsctl add-port.." delete the tap0 interface from system using "ip tuntap del.." add the tap0 interface back in system using "ip tuntap add.." (this changes the ifindex of the interface) delete tap0 from br0 using "ovs-vsctl del-port.." In the function "netdev_ports_insert", two hmap entries were created for mapping "portnum -> netdev" and "ifindex -> portnum". When the interface is deleted from the system, the "netdev_ports_remove" function is not getting called and the old ifindex entry is not getting cleaned up from the "ifindex_to_port" hmap. As part of the fix, added function "dpif_port_remove" which will call "netdev_ports_remove" in the path where the interface deletion from the system is detected. Also, in "netdev_ports_remove", added the code where the "ifindex_to_port_data" (ifindex -> portnum map node) is getting freed when the ifindex is not available any more. (as the interface is already deleted.) VMware-BZ: #1975788 Signed-off-by: Ashish Varma <ashishvarma.ovs@gmail.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* AUTHORS: Add Matteo Croce.Ben Pfaff2017-11-031-0/+1
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* AUTHORS: Add Duan Jiong.Ben Pfaff2017-11-031-0/+1
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* netdev-dummy: Avoid double-free in netdev_dummy_ip4addr().Yifeng Sun2017-11-021-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | netdev_dummy_ip6addr() calls netdev_close() twice though it increases netdev's reference only once from netdev_from_name(). As a result, Valgrind test 788 (tunnel_push_pop - action) reports the error below: ==20465== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0) Invalid read of size 8 at 0x493FE0: netdev_get_name (netdev.c:911) by 0x5125D3: tnl_port_map_delete_ipdev (tnl-ports.c:470) by 0x4E551C: __rt_entry_delete (ovs-router.c:252) by 0x4E64AA: ovs_router_flush (ovs-router.c:478) by 0x475CA8: call_hooks.part.2 (fatal-signal.c:254) by 0x5E53FF7: __run_exit_handlers (exit.c:82) by 0x5E54044: exit (exit.c:104) by 0x5E3A836: (below main) (libc-start.c:325) Address 0x65ea680 is 0 bytes inside a block of size 640 free'd at 0x4C2EDEB: free (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) by 0x492BA2: netdev_unref (netdev.c:572) by 0x41646E: ofport_destroy__ (ofproto.c:2516) by 0x41FD58: ofproto_destroy (ofproto.c:1645) by 0x40B96B: bridge_destroy (bridge.c:3273) by 0x410238: bridge_exit (bridge.c:506) by 0x40700E: main (ovs-vswitchd.c:135) Block was alloc'd at at 0x4C2FB55: calloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) by 0x516A82: xcalloc (util.c:103) by 0x48D74D: netdev_dummy_alloc (netdev-dummy.c:661) by 0x4931D1: netdev_open.part.12 (netdev.c:406) by 0x40A985: iface_do_create (bridge.c:1784) by 0x40A985: iface_create (bridge.c:1837) by 0x40A985: bridge_add_ports__ (bridge.c:931) by 0x40C7EA: bridge_add_ports (bridge.c:947) by 0x40C7EA: bridge_reconfigure (bridge.c:663) by 0x410485: bridge_run (bridge.c:2998) by 0x406F64: main (ovs-vswitchd.c:119) Signed-off-by: Yifeng Sun <pkusunyifeng@gmail.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* AUTHORS: Add Kaige Fu.Ben Pfaff2017-10-301-0/+1
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* timeval: Check for OS-provided clock_gettime on macOSRichard Oliver2017-10-301-0/+1
| | | | | | | | | | | | | | | | [Problem] Compilation error on newer versions of macOS (Sierra onwards) due to multiple declarations of clock_gettime. [Solution] Have configure check for clock_gettime and check this result in timeval to avoid incorrectly declaring/defining clock_gettime again. [Testing] Source code now successfully builds on macOS. Signed-off-by: Richard Oliver <richard@richard-oliver.co.uk> Signed-off-by: Ben Pfaff <blp@ovn.org>
* vswitch.xml: Better document patch ports.Ben Pfaff2017-10-121-0/+1
| | | | | | Reported-by: Hui Xiang <xianghuir@gmail.com> Signed-off-by: Ben Pfaff <blp@ovn.org> Acked-by: Andy Zhou <azhou@ovn.org>
* ofproto-dpif-xlate: Remove assertion for truncatedIWASE Yusuke2017-10-101-0/+1
| | | | | | | | | | | | | | Because OpenFlow Spec does not clearly stipulate that "max_len" in OUTPUT action must be zero when "port" is other than OFPP_CONTROLLER, it is too strict assertion that confirm "max_len" is not zero, and "max_len" should be ignored when not used. Also this assertion causes the lack of the interoperability with some controller implementations. This patch removes these redundant assertions of if truncated or not. Signed-off-by: IWASE Yusuke <iwase.yusuke0@gmail.com> Signed-off-by: Andy Zhou <azhou@ovn.org>
* Fix a typo in the controller name in the howtoIman Tabrizian2017-10-021-0/+1
| | | | | | | | | This commit fixes potential unintended mistake in howto guide of userspace tunneling. Submitted-at: https://github.com/openvswitch/ovs/pull/209 Signed-off-by: Iman Tabrizian <tabrizian@outlook.com> Signed-off-by: Russell Bryant <russell@ovn.org>
* ovn-controller: pending_ct_zones should be destroyed000379972017-09-251-0/+1
| | | | | | | | pending_ct_zones in ovn-controller main should be destroyed when exit. Signed-off-by: xu rong <xu.rong@zte.com.cn> Acked-by: Miguel Angel Ajo <majopela@redhat.com> Signed-off-by: Russell Bryant <russell@ovn.org>
* AUTHORS.rst: Update Daniele VenturinoDaniele Venturino2017-09-211-1/+1
| | | | | | | Update email address. Signed-off-by: Daniele Venturino <venturino.daniele+ovs@gmail.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* bridge: Fix controller status update to passive connectionsAndy Zhou2017-09-141-0/+1
| | | | | | | | | | | | The bug can cause ovs-vswitchd to crash (due to assert) when it is set up with a passive controller connection. Since only active connections are kept, the passive connection status update should be ignored and not trigger asserts. Fixes: 85c55772a453 ("bridge: Fix controller status update") Reported-by: Josh Bailey <josh@faucet.nz> Signed-off-by: Andy Zhou <azhou@ovn.org> Acked-by: Joe Stringer <joe@ovn.org>
* add libressl compatibilityStuart Cardall2017-09-101-0/+1
| | | | | | | | fixes undefined reference to ASN1_STRING_get0_data Submitted-at: https://github.com/openvswitch/ovs/pull/202 Signed-off-by: Stuart Cardall <developer@it-offshore.co.uk> Signed-off-by: Russell Bryant <russell@ovn.org>
* AUTHORS.rst: Add Jakub Sitnicki.Russell Bryant2017-09-061-0/+1
| | | | Signed-off-by: Russell Bryant <russell@ovn.org>
* conntrack: Fix ct-clean thread crash bug.Lily Huang2017-08-251-0/+1
| | | | | | | | | | | | | | | | | | | Conn should be removed from the connection expiry list when the connection tracker experiences NAT resource exhaustion and the connection needing NAT mapping cannot get it. If this is not done, the connection tracker can crash during cleanup of expired connections by the clean thread. This crash will be triggered when a established flow do ct(nat) again, like "ip,actions=ct(table=1) table=1,in_port=1,ip,actions=ct(commit,nat(dst=5.5.5.5)),2 table=1,in_port=2,ip,ct_state=+est,actions=1 table=1,in_port=1,ip,ct_state=+est,actions=2" Fixes: bd5e81a0e596 ("Userspace Datapath: Add ALG infra and FTP.") Signed-off-by: Lili Huang <huanglili.huang@huawei.com> Signed-off-by: Darrell Ball <dlu998@gmail.com>
* AUTHORS: Add Wang Zhike.Joe Stringer2017-08-071-0/+1
| | | | | Signed-off-by: Joe Stringer <joe@ovn.org> Acked-by: Ben Pfaff <blp@ovn.org>
* ovsdb-server: Document clarification for some bad wording in RFC 7047.Ben Pfaff2017-08-041-0/+1
| | | | | | Reported-by: Harish Kanakaraju <hkanakaraju@vmware.com> Signed-off-by: Ben Pfaff <blp@ovn.org> Acked-by: Andy Zhou <azhou@ovn.org>
* debian.rst: Clarify that "dpkg" needs manual help with dependencies.Ben Pfaff2017-08-041-0/+1
| | | | | | Reported-by: Mircea Ulinic <ping@mirceaulinic.net> Signed-off-by: Ben Pfaff <blp@ovn.org> Acked-by: Andy Zhou <azhou@ovn.org>
* AUTHORS: Add Jorge Arturo Sauma Vargas and fix a misspelling.Ben Pfaff2017-08-031-1/+2
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* ovn-northd: Optimize acl of localnet-port.wangqianyu2017-07-261-0/+1
| | | | | | | | | | | | | Localnet port is not an endpoint, and have no security requirements to use localnet port at present. So, for performance consideration, we could do not use ct for localnet port. The more specific discussion can be found from https://mail.openvswitch.org/pipermail/ovs-dev/2017-July/335048.html Signed-off-by: wangqianyu <wang.qianyu@zte.com.cn> Acked-by: Han Zhou <zhouhan@gmail.com> Signed-off-by: Russell Bryant <russell@ovn.org>
* AUTHORS.rst: Add Mark Michelson.Russell Bryant2017-07-251-0/+1
| | | | Signed-off-by: Russell Bryant <russell@ovn.org>
View Lorry Controller Status