summaryrefslogtreecommitdiff
path: root/AUTHORS.rst
Commit message (Collapse)AuthorAgeFilesLines
* Remove duplicate include fileYi Li2020-09-221-0/+1
| | | | | | | Found by checkincludes.pl Signed-off-by: Yi Li <yili@winhong.com> Signed-off-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com>
* AUTHORS: Add Boleslaw Tokarski.Ilya Maximets2020-09-161-0/+1
| | | | Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
* AUTHORS: update email for Mark GrayMark Gray2020-09-081-1/+1
| | | | | | | Update email address for Mark Gray Signed-off-by: Mark Gray <mark.d.gray@redhat.com> Signed-off-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com>
* ovs-monitor-ipsec: Convert Python2 code to Python3.lzhecheng2020-08-171-0/+1
| | | | | | | | Submitted-at: https://github.com/openvswitch/ovs/pull/331 Reported-at: https://github.com/openvswitch/ovs-issues/issues/192 Fixes: 1ca0323e7c29 ("Require Python 3 and remove support for Python 2.") Signed-off-by: lzhecheng <lzhecheng@vmware.com> Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
* AUTHORS: Add Sivaprasad Tummala.Ian Stokes2020-08-121-0/+1
| | | | Signed-off-by: Ian Stokes <ian.stokes@intel.com>
* ovs-router: Fix flushing of local routes.Ilya Maximets2020-07-211-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | Since commit 8e4e45887ec3, priority of 'local' route entries no longer matches with 'plen'. This should be taken into account while flushing cached routes, otherwise they will remain in OVS even after removing them from the system: # ifconfig eth0 11.0.0.1 # ovs-appctl ovs/route/show --- A new route synchronized from kernel route table --- Cached: 11.0.0.1/32 dev eth0 SRC 11.0.0.1 local # ifconfig eth0 0 # ovs-appctl ovs/route/show -- the new route entry is still in ovs route table --- Cached: 11.0.0.1/32 dev eth0 SRC 11.0.0.1 local CC: wenxu <wenxu@ucloud.cn> Fixes: 8e4e45887ec3 ("ofproto-dpif-xlate: makes OVS native tunneling honor tunnel-specified source addresses") Reported-by: Zheng Jingzhou <glovejmm@163.com> Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2020-July/373093.html Acked-by: William Tu <u9012063@gmail.com> Signed-off-by: Ilya Maximets <i.maximets@ovn.org> Signed-off-by: William Tu <u9012063@gmail.com>
* AUTHORS: Add Jeff Squyres.Ilya Maximets2020-07-171-0/+1
| | | | Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
* dpif-netdev: Avoid deadlock with offloading during PMD thread deletion.Ilya Maximets2020-07-161-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Main thread will try to pause/stop all revalidators during datapath reconfiguration via datapath purge callback (dp_purge_cb) while holding 'dp->port_mutex'. And deadlock happens in case any of revalidator threads is already waiting on 'dp->port_mutex' while dumping offloaded flows: main thread revalidator --------------------------------- ---------------------------------- ovs_mutex_lock(&dp->port_mutex) dpif_netdev_flow_dump_next() -> dp_netdev_flow_to_dpif_flow -> get_dpif_flow_status -> dpif_netdev_get_flow_offload_status() -> ovs_mutex_lock(&dp->port_mutex) <waiting for mutex here> reconfigure_datapath() -> reconfigure_pmd_threads() -> dp_netdev_del_pmd() -> dp_purge_cb() -> udpif_pause_revalidators() -> ovs_barrier_block(&udpif->pause_barrier) <waiting for revalidators to reach barrier> <DEADLOCK> We're not allowed to call offloading API without holding global port mutex from the userspace datapath due to thread safety restrictions on netdev-offload-dpdk module. And it's also not easy to rework datapath reconfiguration process in order to move actual PMD removal and datapath purge out of the port mutex. So, for now, not sleeping on a mutex if it's not immediately available seem like an easiest workaround. This will have impact on flow statistics update rate and on ability to get the latest statistics before removing the flow (latest stats will be lost in case we were not able to take the mutex). However, this will allow us to operate normally avoiding the deadlock. The last bit is that to avoid flapping of flow attributes and statistics we're not failing the operation, but returning last statistics and attributes returned by offload provider. Since those might be updated in different threads, stores and reads are atomic. Reported-by: Frank Wang (王培辉) <wangpeihui@inspur.com> Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2020-June/371753.html Fixes: a309e4f52660 ("dpif-netdev: Update offloaded flows statistics.") Acked-by: Kevin Traynor <ktraynor@redhat.com> Acked-by: Ian Stokes <ian.stokes@intel.com> Tested-by: Eli Britstein <elibr@mellanox.com> Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
* AUTHORS: Add Adrian Moreno.Ilya Maximets2020-07-071-0/+1
| | | | Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
* AUTHORS: Add Peng He.William Tu2020-07-051-0/+1
| | | | Signed-off-by: William Tu <u9012063@gmail.com>
* AUTHORS: Add Sriharsha Basavapatna.Ilya Maximets2020-06-221-0/+1
| | | | Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
* ovs-rcu: Avoid flushing callbacks during postponing.Ilya Maximets2020-06-101-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ovsrcu_flush_cbset() call during ovsrcu_postpone() could cause use after free in case the caller sets new pointer only after postponing free for the old one: ------------------ ------------------ ------------------- Thread 1 Thread 2 RCU Thread ------------------ ------------------ ------------------- pointer = A ovsrcu_quiesce(): thread->seqno = 30 global_seqno = 31 quiesced read pointer A postpone(free(A)): flush cbset pop flushed_cbsets ovsrcu_synchronize: target_seqno = 31 ovsrcu_quiesce(): thread->seqno = 31 global_seqno = 32 quiesced read pointer A use pointer A ovsrcu_quiesce(): thread->seqno = 32 global_seqno = 33 quiesced read pointer A pointer = B ovsrcu_quiesce(): thread->seqno = 33 global_seqno = 34 quiesced target_seqno exceeded by all threads call cbs to free A use pointer A (use after free) ----------------------------------------------------------- Fix that by using dynamically re-allocated array without flushing to the global flushed_cbsets until writer enters quiescent state. Fixes: 0f2ea84841e1 ("ovs-rcu: New library.") Reported-by: Linhaifeng <haifeng.lin@huawei.com> Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2020-June/371265.html Acked-by: Ben Pfaff <blp@ovn.org> Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
* AUTHORS: Add Eiichi Tsukata.Ilya Maximets2020-05-281-0/+1
| | | | Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
* AUTHORS: Add Jiang Lidong.William Tu2020-04-301-0/+1
| | | | Signed-off-by: William Tu <u9012063@gmail.com>
* AUTHORS: Add Anton Ivanov.William Tu2020-04-291-0/+1
| | | | | Signed-off-by: William Tu <u9012063@gmail.com> Acked-by: Numan Siddique <numans@ovn.org>
* AUTHORS: Add Usman Ansari.William Tu2020-03-201-0/+1
| | | | Signed-off-by: William Tu <u9012063@gmail.com>
* AUTHORS: Add Martin Varghese.Ben Pfaff2020-02-071-0/+1
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* AUTHORS: Add Emma Finn.Ian Stokes2020-01-171-0/+1
| | | | Signed-off-by: Ian Stokes <ian.stokes@intel.com>
* AUTHORS: update email for Lance RichardsonLance Richardson2020-01-081-1/+1
| | | | | | | Update email address for Lance Richardson. Signed-off-by: Lance Richardson <lance.richardson@broadcom.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* AUTHORS: Add Krishna Kolakaluri.Ben Pfaff2020-01-061-0/+1
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* AUTHORS: Add Lance Yang.Ilya Maximets2019-12-131-0/+1
| | | | Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
* AUTHORS: Add Yi Yang.William Tu2019-12-031-0/+1
| | | | | Signed-off-by: William Tu <u9012063@gmail.com> Acked-by: Ben Pfaff <blp@ovn.org>
* AUTHORS: Add Wang Li.Ben Pfaff2019-11-211-0/+1
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* AUTHORS: Add Tomasz Konieczny.Ilya Maximets2019-11-041-0/+1
| | | | Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
* AUTHORS: Add Gowrishankar Muthukrishnan.Ben Pfaff2019-10-301-0/+1
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* AUTHORS: Add Alessandro Pilotti.Alin Gabriel Serdean2019-10-151-0/+1
| | | | | Signed-off-by: Alin Gabriel Serdean <aserdean@ovn.org> Acked-by: Ben Pfaff <blp@ovn.org>
* AUTHORS: Add Liu Chang.Ben Pfaff2019-09-301-0/+1
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* AUTHORS: Add Lukasz Pawlik.Ian Stokes2019-09-301-0/+1
| | | | Signed-off-by: Ian Stokes <ian.stokes@intel.com>
* AUTHORS: Add Martin Zhang and Dujie.Ben Pfaff2019-09-241-0/+2
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* MAINTAINERS: Update email for Ilya Maximets.Ilya Maximets2019-09-121-1/+1
| | | | | | CC: Ilya Maximets <i.maximets@ovn.org> Signed-off-by: Ilya Maximets <i.maximets@samsung.com> Acked-by: Ben Pfaff <blp@ovn.org>
* AUTHORS: Add Surya Rudra.Ben Pfaff2019-08-221-0/+1
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* AUTHORS: Add Harry Van Haaren.Ian Stokes2019-07-191-0/+1
| | | | Signed-off-by: Ian Stokes <ian.stokes@intel.com>
* AUTHORS: Add Michele Baldessari.Ben Pfaff2019-07-171-0/+1
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* AUTHORS: Add Yanqin Wei and Malvika Gupta.Ben Pfaff2019-06-131-0/+2
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* AUTHORS: Add Damijan Skvarc and Jaime Caamaño Ruiz.Ben Pfaff2019-06-091-0/+2
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* AUTHORS: Add Maciej Józefczyk.Ben Pfaff2019-06-071-0/+1
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* AUTHORS: Add Liliia Butorina.Ilya Maximets2019-05-241-0/+1
| | | | | Signed-off-by: Ilya Maximets <i.maximets@samsung.com> Acked-by: Ben Pfaff <blp@ovn.org>
* AUTHORS: Add Klemens Nanni.Ben Pfaff2019-05-231-0/+1
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* AUTHORS: Add Nicolas J. Bouliane.Ben Pfaff2019-05-101-0/+1
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* AUTHORS: Add Dumitru Ceara.Numan Siddique2019-05-091-0/+1
| | | | | Signed-off-by: Numan Siddique <nusiddiq@redhat.com> Signed-off-by: Alin Gabriel Serdean <aserdean@ovn.org>
* AUTHORS: Add Liu Chang.Ben Pfaff2019-04-161-0/+1
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* AUTHORS: Add Roni Bar Yanai.Ian Stokes2019-03-191-0/+1
| | | | Signed-off-by: Ian Stokes <ian.stokes@intel.com>
* AUTHORS: Add Sharon Krendel.Ben Pfaff2019-03-141-0/+1
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* AUTHORS: Add parameswaran krishnamurthy.Ben Pfaff2019-03-051-0/+1
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* AUTHORS: Add Brian Haley.Ben Pfaff2019-02-281-0/+1
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* AUTHORS: Add Moshe Levi.Ben Pfaff2019-02-261-0/+1
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* AUTHORS: Add Matthias May.Ben Pfaff2019-02-221-0/+1
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* AUTHORS: Add Eli Britstein <elibr@mellanox.com>Ian Stokes2019-02-181-0/+1
| | | | Signed-off-by: Ian Stokes <ian.stokes@intel.com>
* AUTHORS: Add Ophir Munk <ophirmu@mellanox.com>Ian Stokes2019-02-061-0/+1
| | | | Signed-off-by: Ian Stokes <ian.stokes@intel.com>
* AUTHORS: Add Asaf Penso <asafp@mellanox.com>Ian Stokes2019-02-061-0/+1
| | | | Signed-off-by: Ian Stokes <ian.stokes@intel.com>
View Lorry Controller Status