summaryrefslogtreecommitdiff
path: root/AUTHORS.rst
Commit message (Collapse)AuthorAgeFilesLines
* ofproto: Keep inserting buckets into a group from changing group type.Ben Pfaff2017-12-111-0/+1
| | | | | | | | | | | The "insert buckets" and "delete buckets" operations on a group should not change the group's type or properties, but the implementation did this by mistake. This fixes the problem. Reported-by: shivani dommeti <shivani.dommeti@gmail.com> Tested-by: shivani dommeti <shivani.dommeti@gmail.com> Reported-at: https://mail.openvswitch.org/pipermail/ovs-discuss/2017-December/045830.html Signed-off-by: Ben Pfaff <blp@ovn.org>
* AUTHORS: Update email address for Thadeu Lima de Souza Cascardo.Ben Pfaff2017-12-081-1/+1
| | | | | Signed-off-by: Ben Pfaff <blp@ovn.org> Acked-by: Thadeu Lima de Souza Cascardo <cascardo@cascardo.eti.br>
* AUHTORS: Add Vishal Deep Ajmera.Ben Pfaff2017-11-201-0/+1
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* netdev, dpif: fix the crash/assert on port deleteAshish Varma2017-11-131-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | a crash is seen in "netdev_ports_remove" when an interface is deleted and added back in the system and when the interface is part of a bridge configuration. e.g. steps: create a tap0 interface using "ip tuntap add.." add the tap0 interface to br0 using "ovs-vsctl add-port.." delete the tap0 interface from system using "ip tuntap del.." add the tap0 interface back in system using "ip tuntap add.." (this changes the ifindex of the interface) delete tap0 from br0 using "ovs-vsctl del-port.." In the function "netdev_ports_insert", two hmap entries were created for mapping "portnum -> netdev" and "ifindex -> portnum". When the interface is deleted from the system, the "netdev_ports_remove" function is not getting called and the old ifindex entry is not getting cleaned up from the "ifindex_to_port" hmap. As part of the fix, added function "dpif_port_remove" which will call "netdev_ports_remove" in the path where the interface deletion from the system is detected. Also, in "netdev_ports_remove", added the code where the "ifindex_to_port_data" (ifindex -> portnum map node) is getting freed when the ifindex is not available any more. (as the interface is already deleted.) VMware-BZ: #1975788 Signed-off-by: Ashish Varma <ashishvarma.ovs@gmail.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* AUTHORS: Add Matteo Croce.Ben Pfaff2017-11-031-0/+1
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* AUTHORS: Add Duan Jiong.Ben Pfaff2017-11-031-0/+1
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* netdev-dummy: Avoid double-free in netdev_dummy_ip4addr().Yifeng Sun2017-11-021-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | netdev_dummy_ip6addr() calls netdev_close() twice though it increases netdev's reference only once from netdev_from_name(). As a result, Valgrind test 788 (tunnel_push_pop - action) reports the error below: ==20465== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0) Invalid read of size 8 at 0x493FE0: netdev_get_name (netdev.c:911) by 0x5125D3: tnl_port_map_delete_ipdev (tnl-ports.c:470) by 0x4E551C: __rt_entry_delete (ovs-router.c:252) by 0x4E64AA: ovs_router_flush (ovs-router.c:478) by 0x475CA8: call_hooks.part.2 (fatal-signal.c:254) by 0x5E53FF7: __run_exit_handlers (exit.c:82) by 0x5E54044: exit (exit.c:104) by 0x5E3A836: (below main) (libc-start.c:325) Address 0x65ea680 is 0 bytes inside a block of size 640 free'd at 0x4C2EDEB: free (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) by 0x492BA2: netdev_unref (netdev.c:572) by 0x41646E: ofport_destroy__ (ofproto.c:2516) by 0x41FD58: ofproto_destroy (ofproto.c:1645) by 0x40B96B: bridge_destroy (bridge.c:3273) by 0x410238: bridge_exit (bridge.c:506) by 0x40700E: main (ovs-vswitchd.c:135) Block was alloc'd at at 0x4C2FB55: calloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) by 0x516A82: xcalloc (util.c:103) by 0x48D74D: netdev_dummy_alloc (netdev-dummy.c:661) by 0x4931D1: netdev_open.part.12 (netdev.c:406) by 0x40A985: iface_do_create (bridge.c:1784) by 0x40A985: iface_create (bridge.c:1837) by 0x40A985: bridge_add_ports__ (bridge.c:931) by 0x40C7EA: bridge_add_ports (bridge.c:947) by 0x40C7EA: bridge_reconfigure (bridge.c:663) by 0x410485: bridge_run (bridge.c:2998) by 0x406F64: main (ovs-vswitchd.c:119) Signed-off-by: Yifeng Sun <pkusunyifeng@gmail.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* AUTHORS: Add Kaige Fu.Ben Pfaff2017-10-301-0/+1
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* timeval: Check for OS-provided clock_gettime on macOSRichard Oliver2017-10-301-0/+1
| | | | | | | | | | | | | | | | [Problem] Compilation error on newer versions of macOS (Sierra onwards) due to multiple declarations of clock_gettime. [Solution] Have configure check for clock_gettime and check this result in timeval to avoid incorrectly declaring/defining clock_gettime again. [Testing] Source code now successfully builds on macOS. Signed-off-by: Richard Oliver <richard@richard-oliver.co.uk> Signed-off-by: Ben Pfaff <blp@ovn.org>
* vswitch.xml: Better document patch ports.Ben Pfaff2017-10-121-0/+1
| | | | | | Reported-by: Hui Xiang <xianghuir@gmail.com> Signed-off-by: Ben Pfaff <blp@ovn.org> Acked-by: Andy Zhou <azhou@ovn.org>
* ofproto-dpif-xlate: Remove assertion for truncatedIWASE Yusuke2017-10-101-0/+1
| | | | | | | | | | | | | | Because OpenFlow Spec does not clearly stipulate that "max_len" in OUTPUT action must be zero when "port" is other than OFPP_CONTROLLER, it is too strict assertion that confirm "max_len" is not zero, and "max_len" should be ignored when not used. Also this assertion causes the lack of the interoperability with some controller implementations. This patch removes these redundant assertions of if truncated or not. Signed-off-by: IWASE Yusuke <iwase.yusuke0@gmail.com> Signed-off-by: Andy Zhou <azhou@ovn.org>
* Fix a typo in the controller name in the howtoIman Tabrizian2017-10-021-0/+1
| | | | | | | | | This commit fixes potential unintended mistake in howto guide of userspace tunneling. Submitted-at: https://github.com/openvswitch/ovs/pull/209 Signed-off-by: Iman Tabrizian <tabrizian@outlook.com> Signed-off-by: Russell Bryant <russell@ovn.org>
* ovn-controller: pending_ct_zones should be destroyed000379972017-09-251-0/+1
| | | | | | | | pending_ct_zones in ovn-controller main should be destroyed when exit. Signed-off-by: xu rong <xu.rong@zte.com.cn> Acked-by: Miguel Angel Ajo <majopela@redhat.com> Signed-off-by: Russell Bryant <russell@ovn.org>
* AUTHORS.rst: Update Daniele VenturinoDaniele Venturino2017-09-211-1/+1
| | | | | | | Update email address. Signed-off-by: Daniele Venturino <venturino.daniele+ovs@gmail.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* bridge: Fix controller status update to passive connectionsAndy Zhou2017-09-141-0/+1
| | | | | | | | | | | | The bug can cause ovs-vswitchd to crash (due to assert) when it is set up with a passive controller connection. Since only active connections are kept, the passive connection status update should be ignored and not trigger asserts. Fixes: 85c55772a453 ("bridge: Fix controller status update") Reported-by: Josh Bailey <josh@faucet.nz> Signed-off-by: Andy Zhou <azhou@ovn.org> Acked-by: Joe Stringer <joe@ovn.org>
* add libressl compatibilityStuart Cardall2017-09-101-0/+1
| | | | | | | | fixes undefined reference to ASN1_STRING_get0_data Submitted-at: https://github.com/openvswitch/ovs/pull/202 Signed-off-by: Stuart Cardall <developer@it-offshore.co.uk> Signed-off-by: Russell Bryant <russell@ovn.org>
* AUTHORS.rst: Add Jakub Sitnicki.Russell Bryant2017-09-061-0/+1
| | | | Signed-off-by: Russell Bryant <russell@ovn.org>
* conntrack: Fix ct-clean thread crash bug.Lily Huang2017-08-251-0/+1
| | | | | | | | | | | | | | | | | | | Conn should be removed from the connection expiry list when the connection tracker experiences NAT resource exhaustion and the connection needing NAT mapping cannot get it. If this is not done, the connection tracker can crash during cleanup of expired connections by the clean thread. This crash will be triggered when a established flow do ct(nat) again, like "ip,actions=ct(table=1) table=1,in_port=1,ip,actions=ct(commit,nat(dst=5.5.5.5)),2 table=1,in_port=2,ip,ct_state=+est,actions=1 table=1,in_port=1,ip,ct_state=+est,actions=2" Fixes: bd5e81a0e596 ("Userspace Datapath: Add ALG infra and FTP.") Signed-off-by: Lili Huang <huanglili.huang@huawei.com> Signed-off-by: Darrell Ball <dlu998@gmail.com>
* AUTHORS: Add Wang Zhike.Joe Stringer2017-08-071-0/+1
| | | | | Signed-off-by: Joe Stringer <joe@ovn.org> Acked-by: Ben Pfaff <blp@ovn.org>
* ovsdb-server: Document clarification for some bad wording in RFC 7047.Ben Pfaff2017-08-041-0/+1
| | | | | | Reported-by: Harish Kanakaraju <hkanakaraju@vmware.com> Signed-off-by: Ben Pfaff <blp@ovn.org> Acked-by: Andy Zhou <azhou@ovn.org>
* debian.rst: Clarify that "dpkg" needs manual help with dependencies.Ben Pfaff2017-08-041-0/+1
| | | | | | Reported-by: Mircea Ulinic <ping@mirceaulinic.net> Signed-off-by: Ben Pfaff <blp@ovn.org> Acked-by: Andy Zhou <azhou@ovn.org>
* AUTHORS: Add Jorge Arturo Sauma Vargas and fix a misspelling.Ben Pfaff2017-08-031-1/+2
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* ovn-northd: Optimize acl of localnet-port.wangqianyu2017-07-261-0/+1
| | | | | | | | | | | | | Localnet port is not an endpoint, and have no security requirements to use localnet port at present. So, for performance consideration, we could do not use ct for localnet port. The more specific discussion can be found from https://mail.openvswitch.org/pipermail/ovs-dev/2017-July/335048.html Signed-off-by: wangqianyu <wang.qianyu@zte.com.cn> Acked-by: Han Zhou <zhouhan@gmail.com> Signed-off-by: Russell Bryant <russell@ovn.org>
* AUTHORS.rst: Add Mark Michelson.Russell Bryant2017-07-251-0/+1
| | | | Signed-off-by: Russell Bryant <russell@ovn.org>
* AUTHORS.rst: Update name and e-mail.Tonghao Zhang2017-07-211-1/+1
| | | | | Signed-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com> Signed-off-by: Joe Stringer <joe@ovn.org>
* AUTHORS: Add Venkata Anil KommaddiVenkata Anil Kommaddi2017-07-171-0/+1
| | | | | Signed-off-by: Venkata Anil Kommaddi <vkommadi@redhat.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* AUTHORS: Add ZhiPeng Lu.Ben Pfaff2017-07-131-0/+1
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* id-pool: Fix allocation overflow and the leak of the first ID.Zhou Yangchao2017-07-131-0/+1
| | | | | | | | | The range of IDs should be [base, base + n_ids), but id_pool_alloc_id() allocated the range of IDs is [base, base + n_ids]. And id_pool_free_id() cannot free the ID value base correctly. Signed-off-by: Yangchao Zhou <zhouyates@gmail.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* AUTHORS: Add zhaozhanxu.Ben Pfaff2017-07-121-0/+1
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* AUTHORS: Add zhongbaisong.Ben Pfaff2017-07-071-0/+1
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* AUTHORS: Add Clint Byrum.Ben Pfaff2017-07-071-0/+1
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* AUTHORS: Add Jason Wessel.Ben Pfaff2017-07-061-0/+1
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* rhel-systemd: start vswitchd after udevaaron conole2017-06-291-0/+1
| | | | | | | | | | | | | | | | It's possible to race with the udev service, such that dpdk ports are not finished being bound until after ovs-vswitchd has been started. This means that attempts to use the port will fail. While it is possible to work around this for some NICs using port hotplug, not all port types are supported (for instance vfio), and it requires manual intervention. Fixes: 36af136b690c ("rhel-systemd: Delay shutting down the services") Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1397299 Suggested-by: Flavio Leitner <fbl@sysclose.org> Signed-off-by: Aaron Conole <aconole@redhat.com> Tested-by: Karthik Sundaravel <ksundara@redhat.com> Signed-off-by: Russell Bryant <russell@ovn.org>
* AUTHORS: Add Yunjian Wang.Ben Pfaff2017-05-311-0/+1
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* netdev-linux: Refactor netdev_linux_send() in forwarding batch packets.Zhenyu Gao2017-05-311-0/+1
| | | | | | | | We don't need to initialize sock,msg and sll before calling sendmsg each time. Just initialize them before the loop, it can reduce cpu cycles. Signed-off-by: Zhenyu Gao <sysugaozhenyu@gmail.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* AUTHORS: Add Daniel Alvarez.Ben Pfaff2017-05-301-0/+1
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* debian: Add SYSTEMCTL_SKIP_REDIRECT to init filesRaymond Burkholder2017-05-301-0/+1
| | | | | | | | | | Current versions of systemd in Debian Stretch use SYSTEMCTL_SKIP_REDIRECT instead of _SYSTEMCTL_SKIP_REDIRECT. Provide both variables in the .init files. Signed-off-by: Raymond Burkholder <ray@oneunified.net> Suggested-by: Guru Shetty <guru@ovn.org> Signed-off-by: Gurucharan Shetty <guru@ovn.org>
* AUTHORS: Correct spelling of Przemyslaw.Ben Pfaff2017-05-191-1/+1
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* AUTHORS: Add PrzemyslawX Szczerbik.Ben Pfaff2017-05-181-0/+1
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* bridge: Fix controller status updateAndy Zhou2017-05-151-0/+1
| | | | | | | | | | | | | When multiple bridges connects to the same controller, the controller status should be maintained separately for each bridge. Current logic pushes status updates only based on the connection string, which is the same across multiple bridges when connecting to the same controller. Report-at: https://mail.openvswitch.org/pipermail/ovs-discuss/2017-May/044412.html Reported-by: Tulio Ribeiro <tribeiro@lasige.di.fc.ul.pt> Signed-off-by: Andy Zhou <azhou@ovn.org> Reviewed-by: Greg Rose <gvrose@8192@gmail.com>
* packets: add compose_nd_raZong Kai LI2017-05-041-0/+1
| | | | | | | | | | | | | | | This patch introduces methods to compose a Router Advertisement (RA) packet, introduces flags for RA. RA packet composed structures against specification in RFC4861. Caller can use compse_nd_ra_with_sll_mtu_opts to compose a RA packet with Source Link-layer Address Option and MTU Option. Caller can use packet_put_ra_prefix_opt to append a Prefix Information Option to a RA packet. Signed-off-by: Zongkai LI <zealokii@gmail.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* ovn: Document limitation in the L3HA planMiguel Angel Ajo2017-05-011-0/+1
| | | | | | | | | | | | | The intergateway monitoring covers host failure well, but it doesn't cover path failure which is a more complicated problem. By this change I don't mean we should implement something to cover path failure right away, but that we should keep the limitation in mind. Signed-off-by: Miguel Angel Ajo <majopela@redhat.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
* datapath: openvswitch: Add missing case OVS_TUNNEL_KEY_ATTR_PADKris Murphy2017-04-191-0/+1
| | | | | | | | | | | | | | | | | | | | | openvswitch: Add missing case OVS_TUNNEL_KEY_ATTR_PAD Added a case for OVS_TUNNEL_KEY_ATTR_PAD to the switch statement in ip_tun_from_nlattr in order to prevent the default case returning an error. Fixes: b46f6ded906e ("libnl: nla_put_be64(): align on a 64-bit area") Signed-off-by: Kris Murphy <kriskend@linux.vnet.ibm.com> Acked-by: Joe Stringer <joe@ovn.org> Signed-off-by: David S. Miller <davem@davemloft.net> Upstream: 8f3dbfd79ed9("openvswitch: Add missing case OVS_TUNNEL_KEY_ATTR_PAD") Fixes: f34648187b03 ("datapath: backport: libnl: nla_put_be64(): align on a 64-bit area") Signed-off-by: Andy Zhou <azhou@ovn.org> Acked-by: Joe Stringer <joe@ovn.org>
* datapath: net/openvswitch: Set the ipv6 source tunnel key address attribute ↵Or Gerlitz2017-04-191-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | correctly Upstream commit: net/openvswitch: Set the ipv6 source tunnel key address attribute correctly When dealing with ipv6 source tunnel key address attribute (OVS_TUNNEL_KEY_ATTR_IPV6_SRC) we are wrongly setting the tunnel dst ip, fix that. Fixes: 6b26ba3a7d95 ('openvswitch: netlink attributes for IPv6 tunneling') Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com> Reported-by: Paul Blakey <paulb@mellanox.com> Acked-by: Jiri Benc <jbenc@redhat.com> Acked-by: Joe Stringer <joe@ovn.org> Signed-off-by: David S. Miller <davem@davemloft.net> Upstream: 3d20f1f7bd575 ("net/openvswitch: Set the ipv6 source tunnel key address attribute correctly") Fixes: 8a2d4905a00f ("datapath: Add support for IPv6 tunnels.") Signed-off-by: Andy Zhou <azhou@ovn.org> Acked-by: Joe Stringer <joe@ovn.org>
* datapath: actions: fixed a brace coding style warning.Peter Downs2017-04-191-0/+1
| | | | | | | | | | | | | | Upstream commit: openvswitch: actions: fixed a brace coding style warning Fixed a brace coding style warning reported by checkpatch.pl Signed-off-by: Peter Downs <padowns@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net> Upstream: f1304f7ba398 ("openvswitch: actions: fixed a brace coding style warning") Signed-off-by: Joe Stringer <joe@ovn.org> Signed-off-by: Andy Zhou <azhou@ovn.org>
* compat: ipv6: orphan skbs in reassembly unit.Eric Dumazet2017-04-191-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Upstream commit: ipv6: orphan skbs in reassembly unit Andrey reported a use-after-free in IPv6 stack. Issue here is that we free the socket while it still has skb in TX path and in some queues. It happens here because IPv6 reassembly unit messes skb->truesize, breaking skb_set_owner_w() badly. We fixed a similar issue for IPV4 in commit 8282f27449bf ("inet: frag: Always orphan skbs inside ip_defrag()") Acked-by: Joe Stringer <joe@ovn.org> ================================================================== BUG: KASAN: use-after-free in sock_wfree+0x118/0x120 Read of size 8 at addr ffff880062da0060 by task a.out/4140 page:ffffea00018b6800 count:1 mapcount:0 mapping: (null) index:0x0 compound_mapcount: 0 flags: 0x100000000008100(slab|head) raw: 0100000000008100 0000000000000000 0000000000000000 0000000180130013 raw: dead000000000100 dead000000000200 ffff88006741f140 0000000000000000 page dumped because: kasan: bad access detected CPU: 0 PID: 4140 Comm: a.out Not tainted 4.10.0-rc3+ #59 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Bochs 01/01/2011 Call Trace: __dump_stack lib/dump_stack.c:15 dump_stack+0x292/0x398 lib/dump_stack.c:51 describe_address mm/kasan/report.c:262 kasan_report_error+0x121/0x560 mm/kasan/report.c:370 kasan_report mm/kasan/report.c:392 __asan_report_load8_noabort+0x3e/0x40 mm/kasan/report.c:413 sock_flag ./arch/x86/include/asm/bitops.h:324 sock_wfree+0x118/0x120 net/core/sock.c:1631 skb_release_head_state+0xfc/0x250 net/core/skbuff.c:655 skb_release_all+0x15/0x60 net/core/skbuff.c:668 __kfree_skb+0x15/0x20 net/core/skbuff.c:684 kfree_skb+0x16e/0x4e0 net/core/skbuff.c:705 inet_frag_destroy+0x121/0x290 net/ipv4/inet_fragment.c:304 inet_frag_put ./include/net/inet_frag.h:133 nf_ct_frag6_gather+0x1125/0x38b0 net/ipv6/netfilter/nf_conntrack_reasm.c:617 ipv6_defrag+0x21b/0x350 net/ipv6/netfilter/nf_defrag_ipv6_hooks.c:68 nf_hook_entry_hookfn ./include/linux/netfilter.h:102 nf_hook_slow+0xc3/0x290 net/netfilter/core.c:310 nf_hook ./include/linux/netfilter.h:212 __ip6_local_out+0x52c/0xaf0 net/ipv6/output_core.c:160 ip6_local_out+0x2d/0x170 net/ipv6/output_core.c:170 ip6_send_skb+0xa1/0x340 net/ipv6/ip6_output.c:1722 ip6_push_pending_frames+0xb3/0xe0 net/ipv6/ip6_output.c:1742 rawv6_push_pending_frames net/ipv6/raw.c:613 rawv6_sendmsg+0x2cff/0x4130 net/ipv6/raw.c:927 inet_sendmsg+0x164/0x5b0 net/ipv4/af_inet.c:744 sock_sendmsg_nosec net/socket.c:635 sock_sendmsg+0xca/0x110 net/socket.c:645 sock_write_iter+0x326/0x620 net/socket.c:848 new_sync_write fs/read_write.c:499 __vfs_write+0x483/0x760 fs/read_write.c:512 vfs_write+0x187/0x530 fs/read_write.c:560 SYSC_write fs/read_write.c:607 SyS_write+0xfb/0x230 fs/read_write.c:599 entry_SYSCALL_64_fastpath+0x1f/0xc2 arch/x86/entry/entry_64.S:203 RIP: 0033:0x7ff26e6f5b79 RSP: 002b:00007ff268e0ed98 EFLAGS: 00000206 ORIG_RAX: 0000000000000001 RAX: ffffffffffffffda RBX: 00007ff268e0f9c0 RCX: 00007ff26e6f5b79 RDX: 0000000000000010 RSI: 0000000020f50fe1 RDI: 0000000000000003 RBP: 00007ff26ebc1220 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000206 R12: 0000000000000000 R13: 00007ff268e0f9c0 R14: 00007ff26efec040 R15: 0000000000000003 The buggy address belongs to the object at ffff880062da0000 which belongs to the cache RAWv6 of size 1504 The buggy address ffff880062da0060 is located 96 bytes inside of 1504-byte region [ffff880062da0000, ffff880062da05e0) Freed by task 4113: save_stack_trace+0x16/0x20 arch/x86/kernel/stacktrace.c:57 save_stack+0x43/0xd0 mm/kasan/kasan.c:502 set_track mm/kasan/kasan.c:514 kasan_slab_free+0x73/0xc0 mm/kasan/kasan.c:578 slab_free_hook mm/slub.c:1352 slab_free_freelist_hook mm/slub.c:1374 slab_free mm/slub.c:2951 kmem_cache_free+0xb2/0x2c0 mm/slub.c:2973 sk_prot_free net/core/sock.c:1377 __sk_destruct+0x49c/0x6e0 net/core/sock.c:1452 sk_destruct+0x47/0x80 net/core/sock.c:1460 __sk_free+0x57/0x230 net/core/sock.c:1468 sk_free+0x23/0x30 net/core/sock.c:1479 sock_put ./include/net/sock.h:1638 sk_common_release+0x31e/0x4e0 net/core/sock.c:2782 rawv6_close+0x54/0x80 net/ipv6/raw.c:1214 inet_release+0xed/0x1c0 net/ipv4/af_inet.c:425 inet6_release+0x50/0x70 net/ipv6/af_inet6.c:431 sock_release+0x8d/0x1e0 net/socket.c:599 sock_close+0x16/0x20 net/socket.c:1063 __fput+0x332/0x7f0 fs/file_table.c:208 ____fput+0x15/0x20 fs/file_table.c:244 task_work_run+0x19b/0x270 kernel/task_work.c:116 exit_task_work ./include/linux/task_work.h:21 do_exit+0x186b/0x2800 kernel/exit.c:839 do_group_exit+0x149/0x420 kernel/exit.c:943 SYSC_exit_group kernel/exit.c:954 SyS_exit_group+0x1d/0x20 kernel/exit.c:952 entry_SYSCALL_64_fastpath+0x1f/0xc2 arch/x86/entry/entry_64.S:203 Allocated by task 4115: save_stack_trace+0x16/0x20 arch/x86/kernel/stacktrace.c:57 save_stack+0x43/0xd0 mm/kasan/kasan.c:502 set_track mm/kasan/kasan.c:514 kasan_kmalloc+0xad/0xe0 mm/kasan/kasan.c:605 kasan_slab_alloc+0x12/0x20 mm/kasan/kasan.c:544 slab_post_alloc_hook mm/slab.h:432 slab_alloc_node mm/slub.c:2708 slab_alloc mm/slub.c:2716 kmem_cache_alloc+0x1af/0x250 mm/slub.c:2721 sk_prot_alloc+0x65/0x2a0 net/core/sock.c:1334 sk_alloc+0x105/0x1010 net/core/sock.c:1396 inet6_create+0x44d/0x1150 net/ipv6/af_inet6.c:183 __sock_create+0x4f6/0x880 net/socket.c:1199 sock_create net/socket.c:1239 SYSC_socket net/socket.c:1269 SyS_socket+0xf9/0x230 net/socket.c:1249 entry_SYSCALL_64_fastpath+0x1f/0xc2 arch/x86/entry/entry_64.S:203 Memory state around the buggy address: ffff880062d9ff00: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc ffff880062d9ff80: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc >ffff880062da0000: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb ^ ffff880062da0080: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb ffff880062da0100: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb ================================================================== Reported-by: Andrey Konovalov <andreyknvl@google.com> Signed-off-by: Eric Dumazet <edumazet@google.com> Signed-off-by: David S. Miller <davem@davemloft.net> This patch is a bugfix, and will be progressively backported to earlier kernels. If it is backported to any kernel 4.5 through 4.10, then users use that updated kernel with the OVS kernel module prior to this patch, it could cause a crash. The compat code here resolves such issues. Upstream: 48cac18ecf1d ("ipv6: orphan skbs in reassembly unit") Signed-off-by: Joe Stringer <joe@ovn.org> Signed-off-by: Andy Zhou <azhou@ovn.org> Acked-by: Joe Stringer <joe@ovn.org>
* AUTHORS: Add Greg Rose.Ben Pfaff2017-04-171-0/+1
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* python: Allow tuning the session probe_interval from IDLLucas Alvares Gomes2017-04-131-0/+1
| | | | | | | | | | | | | This patch is adding a new parameter called "probe_interval" to the constructor of the Idl class. This new parameter will be used to tune the database connection probing for that IDL session, some users might want to tune it to be less agressive than the current 5s default in OVS or even disable it. Reported-at: https://bugs.launchpad.net/networking-ovn/+bug/1680146 Signed-off-by: Lucas Alvares Gomes <lucasagomes@gmail.com> Acked-by: Daniel Alvarez <dalvarez@redhat.com> Signed-off-by: Russell Bryant <russell@ovn.org>
* AUTHORS: Add wenxu.Ben Pfaff2017-04-061-0/+1
| | | | Signed-off-by: Ben Pfaff <blp@ovn.org>
* Document how to get Open vSwitch source code.Ben Pfaff2017-03-291-0/+1
| | | | | | Suggested-by: "Nadathur, Sundar" <sundar.nadathur@intel.com> Signed-off-by: Ben Pfaff <blp@ovn.org> Acked-by: Gurucharan Shetty <guru@ovn.org>
View Lorry Controller Status