summaryrefslogtreecommitdiff
path: root/AUTHORS
Commit message (Collapse)AuthorAgeFilesLines
* dpctl: Fix jump through wild pointer in "dpctl/help".Ben Pfaff2015-11-031-0/+1
| | | | | | | | | | | | | | | dpctl_unixctl_handler() didn't fully initialize the dpctl_params structure it passed to the handler, which meant that dpctl_help() could see a nonnull (indeterminate) 'usage' pointer and jump through it, causes a crash. This commit fixes the crash by fully initializing the structure. The dpctl/help command wasn't going to do anything useful anyway, so this commit also stops registering it. Reported-by: Murali R <muralirdev@gmail.com> Reported-at: http://openvswitch.org/pipermail/discuss/2015-October/019135.html Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Daniele Di Proietto <diproiettod@vmware.com>
* debian: place kernel module to satisfy depmod search.Saurabh Mohan2015-11-021-0/+1
| | | | | | | | | | | | On Ubuntu depmod's search priority is configured in /etc/depmod to be updates and then the kernel built-in directory. $ cat /etc/depmod.d/ubuntu.conf search updates ubuntu built-in Thus change the placement of openvswitch.ko under updates/ not kernel/updates. Acked-by: Ansis Atteka <aatteka@nicira.com> Signed-off-by: Saurabh Mohan <saurabh@cplanenetworks.com>
* AUTHORS: use actual address for emaste@freebsd.orgEd Maste2015-10-301-1/+1
| | | | | Signed-off-by: Ed Maste <emaste@freebsd.org> Signed-off-by: Russell Bryant <rbryant@redhat.com>
* ovsdb-idl: Test script for Python register_columns functionShad Ansari2015-10-131-0/+1
| | | | | | | | | | | | | | | | | | | | Add test scripts to exercise the register_columns() function of the Python IDL. Add ability to specify columns in the "idl" command of test-ovsdb.py. All columns of all tables are monitored by default. The new "?" option can be used to monitor specific Table:Column(s). The table and their columns are listed as a string of the form starting with "?": ?<table-name>:<column-name>,<column-name>,... e.g.: ?simple:b - Monitor column "b" in table "simple" Entries for multiple tables are seperated by "?": ?<table-name>:<column-name>,...?<table-name>:<column-name>,... e.g.: ?simple:b?link1:i,k - Monitor column "b" in table "simple", and column "i", "k" in table "link1" Signed-off-by: Shad Ansari <shad.ansari@hp.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
* AUTHORS: Add John Reumann.Jarno Rajahalme2015-10-091-0/+1
| | | | Signed-off-by: Jarno Rajahalme <jrajahalme@nicira.com>
* util: Fix definition of LIST_FOR_EACH_CONTINUE macro.Mauricio Vásquez2015-10-021-0/+1
| | | | | | | | | | | | | The definition of the INIT_CONTAINER macro initializes ITER to NULL, it will cause a segmentation fault when it is deferenced on (ITER)->MEMBER.next, then, I changed it to the ASSIGN_CONTAINER macro that does not initialize ITER. This does not fix any observable bug because LIST_FOR_EACH_CONTINUE is not used anywhere. Signed-off-by: Mauricio Vasquez B <mauricio.vasquezbernal@studenti.polito.it> Signed-off-by: Ben Pfaff <blp@nicira.com>
* Revert "poll-loop: Fix assertion in poll_create_node()."Gurucharan Shetty2015-09-301-2/+0
| | | | | | | | This reverts commit ae09fae8a6b43299a628ae0989fe2fedb924d560. Commit ae09fae8a6b432 caused segfaults while running unit tests on Windows as pollfd.fd on Windows does not take negative values. Signed-off-by: Gurucharan Shetty <gshetty@nicira.com>
* tests: Ignore more error messages for hidden rules test.Ben Pfaff2015-09-291-0/+1
| | | | | | | | | | | | | | | This test intentionally configures an unreachable controller. It ignored some error messages in the log, specifically br0: cannot find route for controller (240.0.0.1): ... but a bug report says that other forms of messages can also appear, e.g. br0<->tcp:240.0.0.1:6653: connection dropped (No route to host) This commit therefore expands the logged error messages that will be ignored to any message that includes the IP address 240.0.0.1. Reported-by: "Kurek, Tytus" <Tytus.Kurek@pega.com> Reported-at: http://openvswitch.org/pipermail/discuss/2015-September/018910.html Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Justin Pettit <jpettit@nicira.com>
* ofproto/bond: simplify rebalancing logicAndy Zhou2015-09-221-0/+1
| | | | | | | | | | | | | | | | | | | The current bond relancing logic is more complicated than necessary. When considering a bucket for rebalancing, we just need to make sure post rebalancing traffic will be closer to the ideal traffic split than before. This patch implements the simplification. There is a bug is current algorithm that causes a heavyly loaded bucket to ping-pong for each reblancing interval. The simplied loigc also fixes this bug. Though not the main motivation for the change, computations are now done with integer math rather than floating math. Reported-by: Gregory Smith <gasmith@nutanix.com> tested-by: Gregory Smith <gasmith@nutanix.com> Signed-off-by: Andy Zhou <azhou@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>
* poll-loop: Fix assertion in poll_create_node().Ilya Maximets2015-09-221-0/+2
| | | | | | | | Zero is a valid value for a file descriptor. Reported-by: Nikita Kalyazin <n.kalyazin@samsung.com> Signed-off-by: Ilya Maximets <i.maximets@samsung.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
* rhel: Make python 2.7 a requirement of build.Gurucharan Shetty2015-09-181-0/+1
| | | | | Reported-by: 张强 <zhangqiang@meizu.com> Signed-off-by: Gurucharan Shetty <gshetty@nicira.com>
* AUTHORS: Move Ciara Loftus to list of code contributors.Ciara Loftus2015-09-161-1/+1
| | | | | Signed-off-by: Ciara Loftus <ciara.loftus@intel.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
* ofproto-dpif-sflow: Use xzalloc() instead of calloc() to allocate memory.Ben Pfaff2015-09-161-0/+1
| | | | | | | | | | Memory allocation shouldn't be allowed to fail. CC: Neil McKee <neil.mckee@inmon.com> Reported-by: neeraj mehta <mehtaneeraj07@gmail.com> Reported-at: http://openvswitch.org/pipermail/discuss/2015-September/018776.html Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Russell Bryant <rbryant@redhat.com>
* dpdk: add support for v2.1.0Timo Puha2015-09-081-0/+2
| | | | | | | | | | | | | | | | | | | | Update relevant artifacts to add support for DPDK v2.1.0 - INSTALL.DPDK.md - acinclude.m4: Change DPDK library name - netdev-dpdk: Limit minimum mbuf size to to adapt to DPDK bug fix that changes the treatment of the requested mbuf size - build.sh: Change DPDK version number Note that this breaks compatibility with DPDK v2.0.0 although only for the library name change. Note that throughput for vhost ports with mergeable buffers is reduced about 10% due to a necessary bug fix in DPDK vhost code. Signed-off-by: Mark Kavanagh <mark.b.kavanagh@intel.com> Signed-off-by: Michal Weglicki <michalx.weglicki@intel.com> Signed-off-by: Timo Puha <timox.puha@intel.com> Acked-by: Daniele Di Proietto <diproiettod@vmware.com>
* ovsdb: Update _version more accurately in transaction commit.Ben Pfaff2015-09-041-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | The _version column in each OVSDB row is supposed to be updated whenever any other column in the row changes. However, the transaction code was not careful to do this only when a row actually changed--there were other cases where a row was considered at transaction commit time and _version updated even though the row did not actually change. For example, ovsdb_txn_adjust_atom_refs() calls find_or_make_txn_row(), which calls ovsdb_txn_row_modify(), which updates _version, but ovsdb_txn_adjust_atom_refs() doesn't actually update any data. One way to fix this would be to carefully consider and adjust all the code that looks at transaction rows. However, this seems somewhat error prone and thus difficult to test. This commit takes a different approach: it drops the code that adjusts _version on the fly, instead replacing it by a final pass over the database at the end of the commit process that checks for each row whether any columns changed and updates _version at that point if any did. That seems pretty foolproof to me. Reported-by: RishiRaj Maulick <rishi.raj2509@gmail.com> Reported-at: http://openvswitch.org/pipermail/dev/2015-August/059439.html Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Andy Zhou <azhou@nicira.com> Tested-by: RishiRaj Maulick <rishi.raj2509@gmail.com>
* Very pleased to make this change request.Aaron Conole2015-09-041-1/+1
| | | | | Signed-off-by: Aaron Conole <aconole@redhat.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
* authors: Update authors list with my new email.Ethan J. Jackson2015-09-011-1/+1
| | | | | Signed-off-by: Ethan J. Jackson <ejj@eecs.berkeley.edu> Acked-by: Justin Pettit <jpettit@nicira.com>
* AUTHORS: Add Sairam VenugopalNithin Raju2015-08-281-0/+1
| | | | | | Signed-off-by: Nithin Raju <nithin@vmware.com> Signed-off-by: Justin Pettit <jpettit@nicira.com> Acked-by: Russell Bryant <rbryant@redhat.com>
* Update my email address.Alex Wang2015-08-281-1/+1
| | | | | Signed-off-by: Alex Wang <ee07b291@gmail.com> Acked-by: Justin Pettit <jpettit@nicira.com>
* openflow: Add OpenFlow1.5 port desc request.Minoru TAKAHASHI2015-07-311-0/+1
| | | | | Signed-off-by: Minoru TAKAHASHI <takahashi.minoru7@gmail.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
* AUTHORS: Add Alexander Duyck.Joe Stringer2015-07-301-0/+1
| | | | Signed-off-by: Joe Stringer <joestringer@nicira.com>
* ofproto: Implement OF1.4 Set/Get asynchronous configuration messages.Niti Rohilla2015-07-271-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch adds support for Openflow1.4 set/get asynchronous configuration messages. OpenVSwitch already supports set/get asynchronous configuration messages for Openflow1.3. In this patch OFPT_SET_ASYNC_CONFIG message allows the controllers to set the configuration for OFPT_ROLE_STATUS, OFPT_TABLE_STATUS and OFPT_REQUESTFORWARD in addition to the Openflow1.3 messages. In a OFPT_SET_ASYNC, only the properties that shall be changed need to be included, properties that are omitted from the message are unchanged. The OFPT_GET_ASYNC_CONFIG is used to query the asynchronous configuration of switch. In a OFPT_GET_ASYNC_REPLY message, all properties must be included. According to Openflow1.4 the initial configuration shall be: - In the “master” or “equal” role, enable all OFPT_PACKET_IN messages, except those with reason OFPR_INVALID_TTL, enable all OFPT_PORT_STATUS and OFPT_FLOW_REMOVED messages, and disable all OFPT_ROLE_STATUS, OFPT_TABLE_STATUS and OFPT_REQUESTFORWARD messages. - In the “slave” role, enable all OFPT_PORT_STATUS messages and disable all OFPT_PACKET_IN, OFPT_FLOW_REMOVED, OFPT_ROLE_STATUS, OFPT_TABLE_STATUS and OFPT_REQUESTFORWARD messages. Signed-off-by: Niti Rohilla <niti.rohilla@tcs.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
* .travis.yml: Tell travis-ci that sudo support is requiredAaron Conole2015-07-211-0/+1
| | | | | | | .travis/prepare.sh calls sudo. Signed-off-by: Aaron Conole <aaron@bytheb.org> Signed-off-by: Ben Pfaff <blp@nicira.com>
* lib/automake.mk: Fix dependency typos.Kyle Upton2015-07-141-0/+1
| | | | | | | | Fix dependency issues with lib/ofp-errors.lo and lib/ofp-msgs.lo that caused problems when building debian packages. Signed-off-by: Kyle Upton <kupton@baymicrosystems.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
* tests: Skip IPv6 tests if the system does not support IPv6.Ben Pfaff2015-07-131-0/+1
| | | | | | | | | | | This is only for the tests that actually create IPv6 sockets. The tests that merely use IPv6 addresses in flow entries, etc., do not depend on kernel support. Reported-by: 俊 赵 <zhaojun12@outlook.com> Reported-at: http://openvswitch.org/pipermail/discuss/2015-July/018173.html Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Andy Zhou <azhou@nicira.com>
* hash: Add symmetric L3/L4 hash functions for multipath, bundle hashing.Jeroen van Bemmel2015-07-081-0/+1
| | | | | | Signed-off-by: Jeroen van Bemmel <jvb127@gmail.com> [blp@nicira.com made code style fixes, expanded documentation] Signed-off-by: Ben Pfaff <blp@nicira.com>
* FAQ: Fix headline.Steffen Gebert2015-07-081-0/+1
| | | | | | | There must be no line break within the headline. Signed-off-by: Steffen Gebert <steffen.gebert@informatik.uni-wuerzburg.de> Signed-off-by: Ben Pfaff <blp@nicira.com>
* ovs-bugtool: Remove argument of "ovs-appctl dpif/show".Huanle Han2015-07-061-0/+1
| | | | | | | | "ovs-appctl dpif/show" no longer takes any argument after commit dc54ef36 (ofproto: Track subfacet stats in the backer). Signed-off-by: Huanle Han <hanxueluo@gmail.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
* stream-ssl: Set SSL session cache mode to disables.Guru Chaitanya Perakam2015-07-061-0/+1
| | | | | | | | | | | | | | | | | | | | | To enable SSL clients to reconnect with the ovs-testcontoller without being rejected, one must either set the SSL Session ID flag or disable the SSL caching. This patch disables the SSL caching/reuse. In the absence of this fix, the error message from ovs-testcontroller is as below: SSL protocol error: SSL_accept (error:140D9115:SSL routines:SSL_GET_PREV_SESSION:session id context uninitialized) See <https://www.openssl.org/docs/ssl/SSL_CTX_set_session_id_context.html>. Validation: Tested with ovs-testcontroller, by performing SSL reconnection with OpenSSL based SSL client. Signed-off-by: Guru Chaitanya Perakam <gperakam@brocade.com> Reported-by: Guru Chaitanya Perakam <gperakam@brocade.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
* datapath/README: Fix some typos.Luis E. P2015-07-021-0/+1
| | | | | | Signed-off-by: Luis E. P <lpena@vmware.com> Signed-off-by: Ethan Jackson <ethan@nicira.com> Acked-by: Ethan Jackson <ethan@nicira.com>
* INSTALL.DPDK.md: Fix wrong command for creating dpdkvhostuser.Wei li2015-07-011-0/+1
| | | | | Signed-off-by: Wei li <liw@dtdream.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
* ofproto-dpif-xlate: Add support for OpenFlow group chaining.Ben Pfaff2015-06-221-0/+1
| | | | | | Requested-by: Vinllen Chen <cvinllen@gmail.com> Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Alex Wang <alexw@nicira.com>
* Merge remote-tracking branch 'origin/master' into ovn4Justin Pettit2015-06-181-0/+1
|\
| * AUTHORS: Add Thadeu Lima de Souza Cascardo.Ben Pfaff2015-06-171-0/+1
| | | | | | | | Signed-off-by: Ben Pfaff <blp@nicira.com>
* | Merge "master" into "ovn".Ben Pfaff2015-06-131-1/+8
|\ \ | |/ | | | | | | | | | | | | | | This allows OVN to take advantage of the client scalability changes that have been committed to ovsdb-server on master recently. Conflicts: Makefile.am lib/learn.c
| * ovsdb-idl: Document that the IDL always presents a consistent view.Ben Pfaff2015-06-111-0/+1
| | | | | | | | | | | | | | We've had this question a couple of times so we might as well document it. Requested-by: Saurabh Shrivastava (सौरभ श्रीवास्तव) <saurabh@gmail.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
| * Add support functions for 8021.ad push and pop vlan.Thomas F. Herbert2015-06-071-0/+1
| | | | | | | | | | | | | | | | Changes to allow the tpid to be specified and all vlan tpid checking to be generalized. Signed-off-by: Thomas F Herbert <thomasfherbert@gmail.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
| * ofproto-dpif: Avoid creating OpenFlow ports for duplicate tunnels.Ben Pfaff2015-06-051-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | Until now, when two tunnels had an identical configuration, both of them were assigned OpenFlow ports, but only one of those OpenFlow ports was functional. With this commit, only one of the two (or more) identically configured tunnels will be assigned an OpenFlow port number. Reported-by: Keith Holleman <hollemanietf@gmail.com> Signed-off-by: Ben Pfaff <blp@nicira.com> Co-authored-by: Andy Zhou <azhou@nicira.com> Signed-off-by: Andy Zhou <azhou@nicira.com>
| * Update my email addressYAMAMOTO Takashi2015-06-031-1/+1
| | | | | | | | | | Signed-off-by: YAMAMOTO Takashi <yamamoto@midokura.com> Acked-by: Justin Pettit <jpettit@nicira.com>
| * ofp-errors: Add Nicira extension code for OFPBMC_BAD_FIELD.Ben Pfaff2015-05-291-0/+1
| | | | | | | | | | | | | | | | | | | | There are a couple of cases where OpenFlow 1.0 controllers that use Nicira extensions can get OFPBMC_BAD_FIELD, so we should have an error code for it in that protocol. Reported-by: Soner Sevinc <sevincs@vmware.com> Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Jarno Rajahalme <jrajahalme@nicira.com>
| * ovs-docker: Ability to set the MTU of the container interface.Gurucharan Shetty2015-05-271-0/+1
| | | | | | | | | | | | | | | | When containers are connected to a OVS bridge and tunnels are created, it makese sense to reduce the MTU of the interafce. Reported-by: Aurélien Poulai <aurepoulain@viacesi.fr> Signed-off-by: Gurucharan Shetty <shettyg@nicira.com>
| * AUTHORS: Add Dan McGregor.Ben Pfaff2015-05-201-0/+1
| | | | | | | | Signed-off-by: Ben Pfaff <blp@nicira.com>
| * ofp-util: Use OFPGMFC_OUT_OF_BUCKETS for indirect groups with !=1 buckets.Ben Pfaff2015-05-081-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | OpenFlow 1.3 says: If a switch cannot add the incoming group entry due to restrictions (hardware or otherwise) limiting the number of group buckets, it must refuse to add the group entry and must send an ofp_error_msg with OFPET_GROUP_MOD_FAILED type and OFPGMFC_OUT_OF_BUCKETS code. This indicates that OFPGMFC_OUT_OF_BUCKETS is appropriate for an indirect group with the wrong number of buckets, but OVS was using a different error. This fixes the problem. ONF-JIRA: EXT-546 Reported-by: Mrinmoy Das <mrdas@ixiacom.com> Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Justin Pettit <jpettit@nicira.com>
* | Merge "master" into "ovn".Justin Pettit2015-05-071-0/+5
|\ \ | |/ | | | | | | | | | | This brings in STT. Conflicts: tutorial/ovs-sandbox
| * AUTHORS: Add Billy O'Mahony.Ben Pfaff2015-05-071-0/+1
| | | | | | | | Signed-off-by: Ben Pfaff <blp@nicira.com>
| * FAQ: Explain how "tap" devices work and why you should not use them.Ben Pfaff2015-05-051-0/+1
| | | | | | | | | | | | CC: 张伟 <zhangwqh@126.com> Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Daniele Di Proietto <diproiettod@vmware.com>
| * datapath: Prevent linker error of unknown symbol.Alex Wang2015-04-261-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | With the latest change of separating vports into their own modules, it is necessary to export all public functions in linux/compat/ directory. Also, we should prefix functions which replace the upstream ones with 'rpl_' and others with 'ovs_'. This will prevent the linker error when vport modules use those functions in the future. e.g., the to be merged vport-stt module will use the flex_array_* functions which are not currently exported. Co-authored-by: Tuan Nguyen <tuan.nguyen@veriksystems.com> Signed-off-by: Alex Wang <alexw@nicira.com> Acked-by: Jesse Gross <jesse@nicira.com>
| * testsuite: Don't apply the testsuite.patch on non-Windows platforms.Gurucharan Shetty2015-04-231-0/+1
| | | | | | | | | | | | | | | | | | On CentOS machines which use autoconf version 2.63, the patch application would fail. Reported-by: Ian Stokes <ian.stokes@intel.com> Tested-by: Ian Stokes <ian.stokes@intel.com> Signed-off-by: Gurucharan Shetty <gshetty@nicira.com>
| * bridge: Remove unused macro OFP_PORT_ACTION_WINDOW.Ben Pfaff2015-04-201-0/+1
| | | | | | | | | | | | | | | | I guess that this was missed when the corresponding feature was removed. Reported-by: David Evans <davidjoshuaevans@gmail.com> Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Russell Bryant <rbryant@redhat.com>
* | AUTHORS: Add Gal Sagie.Ben Pfaff2015-04-151-0/+1
|/ | | | Signed-off-by: Ben Pfaff <blp@nicira.com>